Maniphest T75819

Don't use psuedo-selectors that are not supported in IE 8.
Closed, ResolvedPublic
Actions

Description

Our LESS should not use psuedo-selectors that are not supported in IE 8 (using it in a jQuery selector is fine). Common ones that are not supported are :not and :empty.

The obvious exception is things like:

.mw-ui-fieldtag-input:not(.ie8WillIgnoreThis)

where it intentionally uses the construct so IE 8 drops the rule.

There is one sub-bug about this already, but I'm not planning to make a separate one for each other case. Let's just fix them.

Details

	Subject	Repo	Branch	Lines +/-
	Fix multiple major IE 8 issues	mediawiki/extensions/Flow	master	+217 -189

Customize query in gerrit

Related Objects
Search...

		Status	Subtype	Assigned	Task
		Declined		None	T87121 IE 8 support - Flow issues (tracking)
		Resolved		• Mattflaschen-WMF	T75819 Don't use psuedo-selectors that are not supported in IE 8.
		Resolved		• Mattflaschen-WMF	T74059 Parentheses around cur \| prev \| topic do not show in IE 8

Event Timeline

• Mattflaschen-WMF created this task.Nov 25 2014, 1:19 AM

• Mattflaschen-WMF raised the priority of this task from to Needs Triage.

• Mattflaschen-WMF updated the task description. (Show Details)

• Mattflaschen-WMF added a project: StructuredDiscussions.

• Mattflaschen-WMF changed Security from none to None.

• Mattflaschen-WMF added a subtask: T74059: Parentheses around cur | prev | topic do not show in IE 8.

• Mattflaschen-WMF subscribed.

• Mattflaschen-WMF updated the task description. (Show Details)Nov 25 2014, 1:23 AM

• Mattflaschen-WMF updated the task description. (Show Details)Nov 25 2014, 1:30 AM

There is another in modules/styles/board/timestamps.less.

Change 185392 had a related patch set uploaded (by Mattflaschen):
WIP: Fix most noticeable IE 8 issues

https://gerrit.wikimedia.org/r/185392

Patch-For-Review

• DannyH triaged this task as Medium priority.Jan 16 2015, 6:43 PM

• DannyH added a project: Collaboration-Team-Triage.

• DannyH moved this task from Untriaged to Sprint O (ends Jan 27) on the Collaboration-Team-Triage board.

Aklapper added a project: Browser-Support-Internet-Explorer.Jan 18 2015, 1:43 AM

Aklapper subscribed.

• Mattflaschen-WMF moved this task from Sprint O (ends Jan 27) to Code Review on the Collaboration-Team-Triage board.Jan 20 2015, 6:48 PM

• Mattflaschen-WMF added a project: Collaboration-Team-Sprint-P-2015-02-11/q3.Jan 28 2015, 7:22 PM

• Mattflaschen-WMF removed a project: Collaboration-Team-Triage.Jan 28 2015, 7:28 PM

matthiasmullie moved this task from Sprint P - ends Feb 11 to Code Review on the Collaboration-Team-Sprint-P-2015-02-11/q3 board.Jan 28 2015, 7:28 PM

Change 185392 merged by jenkins-bot:
Fix multiple major IE 8 issues

https://gerrit.wikimedia.org/r/185392

EBernhardson mentioned this in rEFLW7eff1816b73d: Fix multiple major IE 8 issues.Jan 30 2015, 10:38 PM

EBernhardson moved this task from Code Review to Product Review on the Collaboration-Team-Sprint-P-2015-02-11/q3 board.Jan 30 2015, 11:18 PM

• DannyH closed this task as Resolved.Feb 3 2015, 11:58 PM

• DannyH claimed this task.

• DannyH closed subtask T74059: Parentheses around cur | prev | topic do not show in IE 8 as Resolved.

• DannyH moved this task from Product Review to Done on the Collaboration-Team-Sprint-P-2015-02-11/q3 board.

• Mattflaschen-WMF claimed this task.Feb 4 2015, 5:56 AM

Diffusion mentioned this in rMEXT4cc150f26ae4: Updated mediawiki/extensions Project: mediawiki/extensions/Flow….Mar 11 2015, 6:25 AM

Danny_B added a parent task: T87121: IE 8 support - Flow issues (tracking).Jul 20 2016, 1:31 AM

Danny_B removed a parent task: T75817: CSS is broken in IE 8.

Restricted Application added a project: Growth-Team. · View Herald TranscriptSep 4 2018, 2:38 PM