Page MenuHomePhabricator
Create Task
Maniphest T76294

weblinkchecker.py enhancements from compat
Closed, ResolvedPublic
Actions

Description

Two features recently landed in compat and need to be ported to core so that core remains feature compatible with compat

https://gerrit.wikimedia.org/r/#/c/175610/
https://gerrit.wikimedia.org/r/#/c/175638/

Details

SubjectRepoBranchLines +/-
Introduce config.weblink_dead_days instead of daypywikibot/coremaster+15 -8
Introduce config.weblink_dead_days instead of global daypywikibot/coremaster+13 -8
[FIX] Weblinkchecker: Report malformed URLs (port)pywikibot/coremaster+13 -0
Customize query in gerrit

Related Objects

Event Timeline

jayvdb created this task.Nov 30 2014, 3:26 PM
jayvdb renamed this task from weblinkchecker.py enhancements from core to weblinkchecker.py enhancements from compat.
jayvdb raised the priority of this task from to High.
jayvdb updated the task description. (Show Details)
jayvdb added a project: Pywikibot.
jayvdb changed Security from none to None.
jayvdb moved this task from Backlog to Needs Review on the Pywikibot board.
jayvdb added subscribers: jayvdb, saper.
gerritbot added a project: Patch-For-Review.Nov 30 2014, 5:04 PM

Change 176509 had a related patch set uploaded (by XZise):
[FIX] Weblinkchecker: Report malformed URLs (port)

https://gerrit.wikimedia.org/r/176509

Patch-For-Review

gerritbot added a comment.Nov 30 2014, 5:09 PM

Change 176509 merged by jenkins-bot:
[FIX] Weblinkchecker: Report malformed URLs (port)

https://gerrit.wikimedia.org/r/176509

jayvdb removed a project: Patch-For-Review.Dec 5 2014, 4:23 AM
saper lowered the priority of this task from High to Lowest.Dec 7 2014, 12:13 PM

Backport is easy, testing is not. Anyone runnng weblinkchecker.py happy to test?

jayvdb added a subscriber: Beta16.Dec 7 2014, 12:15 PM
Rubin16 subscribed.Jan 11 2015, 11:38 AM
XZise mentioned this in rPWBC2a02501d2a64: [FIX] Weblinkchecker: Report malformed URLs (port).Mar 4 2015, 8:46 AM
jayvdb added a comment.Dec 9 2015, 2:55 PM

@saper, are you interested in putting up a weblink_dead_days patch to core for review?

It looks like we wont find any regular uses of this script willing to test on Phabricator. Maybe ask for tests on the mailing list?

Anyway, for changes like this one, I would +2 based on looking at the diff and maybe some very basic testing if there is anything I wasnt very confident about. Then other users can report a bug when they use it.

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptDec 9 2015, 2:55 PM
jayvdb added a comment.Dec 14 2015, 12:51 PM

Created a GCI task to complete this: https://codein.withgoogle.com/dashboard/tasks/5088334493777920/

Mhutti1 claimed this task.Dec 14 2015, 9:54 PM
gerritbot subscribed.Dec 14 2015, 10:29 PM

Change 259163 had a related patch set uploaded (by Mhutti1):
Introduce config.weblink_dead_days instead of global day

https://gerrit.wikimedia.org/r/259163

gerritbot added a project: Patch-For-Review.Dec 14 2015, 10:29 PM
gerritbot added a comment.Dec 14 2015, 11:10 PM

Change 259179 had a related patch set uploaded (by Mhutti1):
Introduce config.weblink_dead_days instead of day

https://gerrit.wikimedia.org/r/259179

gerritbot added a comment.Dec 14 2015, 11:13 PM

Change 259163 abandoned by Mhutti1:
Introduce config.weblink_dead_days instead of global day

Reason:
Moved to https://gerrit.wikimedia.org/r/#/c/259179/

https://gerrit.wikimedia.org/r/259163

gerritbot added a comment.Dec 15 2015, 7:44 AM

Change 259179 merged by jenkins-bot:
Introduce config.weblink_dead_days instead of day

https://gerrit.wikimedia.org/r/259179

jayvdb closed this task as Resolved.Dec 15 2015, 8:23 AM
jayvdb mentioned this in T121948: Pywikibot 2.0rc5.Dec 19 2015, 1:03 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits