Page MenuHomePhabricator
Create Task
Maniphest T76853

integration-config-tox-py27 fails existing master when repos get deleted from Gerrit
Closed, ResolvedPublic
Actions

Description

See https://gerrit.wikimedia.org/r/#/c/174619/

https://integration.wikimedia.org/ci/job/integration-config-tox-py27/414/console

12:20:54 ======================================================================
12:20:54 FAIL: test_zuul_project_in_gerrit.test_zuul_project_in_gerrit('mediawiki/extensions/FacebookOpenGraph',)
12:20:54 ----------------------------------------------------------------------
12:20:54 Traceback (most recent call last):
12:20:54   File "/mnt/jenkins-workspace/workspace/integration-config-tox-py27/.tox/py27/local/lib/python2.7/site-packages/nose/case.py", line 197, in runTest
12:20:54     self.test(*self.arg)
12:20:54   File "/mnt/jenkins-workspace/workspace/integration-config-tox-py27/tests/test_zuul_project_in_gerrit.py", line 34, in is_in_gerrit
12:20:54     assert zuul_project in GERRIT_REPOS
12:20:54 AssertionError

Last night, mediawiki/extensions/FacebookOpenGraph was deleted from Gerrit.

Details

SubjectRepoBranchLines +/-
Make integration-config-tox-py27 non-votingintegration/configmaster+3 -0
Customize query in gerrit

Related Objects

Event Timeline

Krinkle created this task.Dec 5 2014, 12:30 PM
Krinkle raised the priority of this task from to Needs Triage.
Krinkle updated the task description. (Show Details)
Krinkle added projects: Continuous-Integration-Infrastructure, Zuul.
Krinkle changed Security from none to None.
Krinkle subscribed.
gerritbot added a project: Patch-For-Review.Dec 5 2014, 12:30 PM

Change 177783 had a related patch set uploaded (by Krinkle):
Make integration-config-tox-py27 non-voting

https://gerrit.wikimedia.org/r/177783

Patch-For-Review

gerritbot added a comment.Dec 5 2014, 12:31 PM

Change 177783 merged by Krinkle:
Make integration-config-tox-py27 non-voting

https://gerrit.wikimedia.org/r/177783

hashar removed a project: Zuul.Dec 5 2014, 1:11 PM
hashar subscribed.Dec 5 2014, 1:21 PM

I have reverted the non voting patch with https://gerrit.wikimedia.org/r/#/c/177787/ , I want the tests to be enforced to prevent bad configuration to be sent.

Since mediawiki/extensions/FacebookOpenGraph has been removed, lets clean it up from the configuration files. It is not ideal to detect such issue when an unrelated patch is proposed, but that is all we got for now. Maybe we could get the job to run once per hour and report on state change to some mail address.

hashar added a comment.Dec 5 2014, 1:24 PM

FacebookOpenGraph has been removed from Gerrit via T65374. https://gerrit.wikimedia.org/r/177788 adjusts the CI configuration.

Krinkle triaged this task as Low priority.Dec 16 2014, 5:22 PM
Krinkle mentioned this in rCICF99e7534acea1: Make integration-config-tox-py27 non-voting.Dec 31 2014, 6:27 PM
Krinkle moved this task from Untriaged to Backlog on the Continuous-Integration-Infrastructure board.Apr 13 2015, 4:40 PM
hashar closed this task as Resolved.Mar 27 2017, 10:45 AM
hashar claimed this task.

This has been fixed by moving that specific check out of the default text to a 'qa' suite. Can be invoked via tox -e qa.

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL