Move image size calculations into calculator class
Closed, ResolvedPublic
Actions

Assigned To

None

Authored By

	MingleTerminator
	Dec 8 2014, 4:44 PM

Description

Image resizing code is located at several places now (ThumbnailWidthCalculator, LightBoxImage.autoResize, MultimediaViewer.displayPlaceholderThumbnail); that should be consolidated and documented + tested better. See e.g. comments at<a href="https://gerrit.wikimedia.org/r/#/c/113963/15/resources/mmv/mmv.js" style="color: rgb(17, 85, 204); font-family: arial, sans-serif; font-size: 13px;" target="_blank">https://gerrit.wikimedia.org/<wbr>r/#/c/113963/15/resources/mmv/<wbr>mmv.js</wbr></wbr></a>

In mingle on 2014-02-25 at 20:11:06, @Tgr wrote:

Also MultimediaViewer.setImage.

In mingle on 2014-03-04 at 17:28:14, aarcos wrote:

All these calculations are now under ThumbnailWidthCalculator and Canvas, see: https://gerrit.wikimedia.org/r/#/c/116685/

In mingle on 2014-03-04 at 17:29:41, aarcos wrote:

See previous comment.

In mingle on 2014-03-05 at 00:22:45, @Tgr wrote:

Moving to accepted since it ended up being a duplicate of #239 .