Page MenuHomePhabricator
Create Task
Maniphest T77773

HTML embed always using the original size even when picking something else
Closed, DuplicatePublic
Actions

Description

Migrated from: https://wikimedia.mingle.thoughtworks.com/projects/multimedia/cards/896

Tests need to be complemented as well so that we catch this early!

Steps to reproduce

  • Go tohttp://en.wikipedia.beta.wmflabs.org/wiki/Lightbox_demo#mediaviewer/File:Swallow_flying_drinking.jpg
  • Click share icon
  • Click "Embed"
  • Click "HTML"
  • Select "Small"

Expected behavior

Image tag in textbox will be<img src="http://upload.wikimedia.org/wikipedia/commons/thumb/5/51/Swallow_flying_drinking.jpg/220px-Swallow_flying_drinking.jpg" alt="Swallow flying drinking.jpg" height="134" width="220">

(or something close enough, arguably we might want to use a bucket size)

Actual behavior

Image tag will be<img src="http://upload.wikimedia.org/wikipedia/commons/5/51/Swallow_flying_drinking.jpg" alt="Swallow flying drinking.jpg" height="134" width="220">

Related Bugs

https://bugzilla.wikimedia.org/show_bug.cgi?id=67323

Related Stories

Related Changesets

Event Timeline

MingleTerminator raised the priority of this task from to High.Dec 8 2014, 6:53 PM
MingleTerminator added projects: Multimedia, MediaViewer.
In mingle on 2014-09-25 at 18:27:58, @Fabrice_Florin wrote:

I just tested #896 on beta. I am not seeing the issue reported there (HTM embed always using the original size even when picking something else). However, I am seeing a different issue, which is that if you select the small size in Wikitext, then click on HTML, you get a different size (either original, or whatever you selected last when in HTML mode). Ideally, once you select a size, both Wikitext and HTML should display that size, when you switch back and forth between them. I will create a new card to reflect that issue.

MingleTerminator added a comment.Dec 8 2014, 6:53 PM
In mingle on 2014-09-25 at 18:38:12, @Tgr wrote:

Added reproduction steps.

MingleTerminator added a comment.Dec 8 2014, 6:53 PM
In mingle on 2014-10-01 at 16:46:58, @MarkTraceur wrote:

Waiting for #473

Tgr closed this task as a duplicate of T69323: MultimediaViewer "HTML embed" shouldn't default to original (unsuitably large).Dec 10 2014, 11:59 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits