Page MenuHomePhabricator

MultimediaViewer "HTML embed" shouldn't default to original (unsuitably large)
Open, LowPublic

Description

screenshot showing 3000x2078px PNG embed

The HTML embed mode in the 'use' dialog seems to embed the full-resolution original image, which can be unconscionably huge.

See attached screenshot & URL.


URL: https://en.wikipedia.org/wiki/Coloman,_King_of_Hungary#mediaviewer/File:Hungary_11th_cent.png

Attached:

Details

Reference
bz67323

Event Timeline

bzimport raised the priority of this task from to High.Nov 22 2014, 3:38 AM
bzimport added a project: MediaViewer.
bzimport set Reference to bz67323.
bzimport added a subscriber: Unknown Object (MLST).
brion created this task.Jun 30 2014, 6:08 PM
Tgr added a comment.Jun 30 2014, 6:32 PM

Well, you have selected "Original size"...
I guess it should not be the default for embedding, though.

brion added a comment.Jun 30 2014, 6:49 PM

Yes, it's the default... which seems unwise for multi-megapixel images. :)

This is pretty rough on the unsuspecting user.

It's unclear to me why the HTML output is not directly equivalent to the wikitext --> HTML output (i.e., the HTML we provide to users via MediaViewer's embed feature should try to be identical to the HTML we provide to users already via "[[File:Foo.png]]"-type syntax). Currently the two HTML outputs are not directly equivalent.

MZMcBride added a comment.EditedSep 16 2014, 11:55 PM

(In reply to Tisza Gergő from comment #1)

Well, you have selected "Original size"...

If I go to https://en.wikipedia.org/wiki/State_of_the_Union#mediaviewer/File:Livingood_Obama_State_of_the_Union_2011.jpg, click "Use this file", click "Embed", click "HTML", and then select "small 217 x 145 px" from the drop-down menu, the suggested embed HTML is:

<p><a href="https://commons.wikimedia.org/wiki/File:Livingood_Obama_State_of_the_Union_2011.jpg#mediaviewer/File:Livingood_Obama_State_of_the_Union_2011.jpg"><img src="https://upload.wikimedia.org/wikipedia/commons/6/65/Livingood_Obama_State_of_the_Union_2011.jpg" alt="Livingood Obama State of the Union 2011.jpg" height="145" width="217"></a><br>"<a href="https://commons.wikimedia.org/wiki/File:Livingood_Obama_State_of_the_Union_2011.jpg#mediaviewer/File:Livingood_Obama_State_of_the_Union_2011.jpg">Livingood Obama State of the Union 2011</a>" by <a href="//commons.wikimedia.org/wiki/Pete_Souza" title="Pete Souza" class="mw-redirect">Pete Souza</a> (<a href="//en.wikipedia.org/wiki/Executive_Office_of_the_President_of_the_United_States" class="extiw" title="w:Executive Office of the President of the United States">Executive Office of the President of the United States</a>) - <a rel="nofollow" class="external free" href="http://www.whitehouse.gov/photos-and-video/photogallery/2011-state-union-address">http://www.whitehouse.gov/photos-and-video/photogallery/2011-state-union-address</a>. Licensed under Public domain via <a href="//commons.wikimedia.org/wiki/">Wikimedia Commons</a>.</p>

<img src="https://upload.wikimedia.org/wikipedia/commons/6/65/Livingood_Obama_State_of_the_Union_2011.jpg" alt="Livingood Obama State of the Union 2011.jpg" height="145" width="217"> is pretty clearly wrong. You're embedding the full-size image and resizing it in-browser. This is a major bug.

(In reply to MZMcBride from comment #5)

Created attachment 16492 [details]
Screenshot of
https://en.wikipedia.org/wiki/State_of_the_Union#mediaviewer/File:Livingood_Obama_State_of_the_Union_2011.jpg, 2014-09-16

I'm well aware that the drop-down menu says "Original file <span garbage>", but it's clearly having issues (I'll file further bug reports) and the HTML markup makes it clear that the small option has been selected by the user.

Attached:

Tgr added a comment.Sep 23 2014, 3:50 PM

Currently we fetch thumbnail URLs when the user first selects the given file/size combination, which comes with a lot of quirks (such as the embed text appearing seconds later than the menu select action). For a decent fix, we would want multi-size support in imageinfo.

Tgr lowered the priority of this task from High to Normal.Dec 11 2014, 12:45 AM

Lowering priority as we do not plan to work on this anytime soon.

In T69323#839673, @Tgr wrote:

Lowering priority as we do not plan to work on this anytime soon.

Assuming the behavior is still the same, as I said in T69323#736333, I think this is a major bug. Large images aren't, like, uncommon and we're telling users to embed really big images to then have their browsers resize them locally. Owww.

Tgr raised the priority of this task from Normal to High.Dec 16 2014, 8:04 AM

You are right. I'll see if we can pick this up.

Gilles moved this task from Untriaged to Next up on the Multimedia board.Dec 17 2014, 5:55 PM
Gilles moved this task from Next up to Prototyping on the Multimedia board.Feb 11 2015, 1:31 PM
Gilles moved this task from Prototyping to Untriaged on the Multimedia board.Apr 6 2015, 9:23 AM
Restricted Application added a subscriber: Matanya. · View Herald TranscriptJul 20 2015, 7:05 AM
Krinkle renamed this task from HTML embed uses unsuitably large image size to HTML embed shouldn't default to original (unsuitably large).Aug 25 2015, 4:44 AM
Krinkle updated the task description. (Show Details)
Krinkle set Security to None.
Krinkle removed a subscriber: wikibugs-l-list.
Jdforrester-WMF moved this task from Untriaged to Backlog on the Multimedia board.Sep 4 2015, 6:44 PM

Mass-removing the Multimedia tag from MediaViewer tasks, as this is now being worked on by the Reading department, not Editing's Multimedia team.

Dzahn removed a subscriber: Dzahn.May 18 2016, 12:01 AM
Jhernandez lowered the priority of this task from High to Low.May 25 2016, 4:26 PM
Jhernandez moved this task from To Triage to Triaged but Future on the Readers-Web-Backlog board.
Krinkle renamed this task from HTML embed shouldn't default to original (unsuitably large) to MultimediaViewer "HTML embed" shouldn't default to original (unsuitably large).Jul 14 2016, 1:17 PM
Tgr removed a subscriber: Tgr.Tue, Jul 9, 6:04 PM