Page MenuHomePhabricator
Create Task
Maniphest T78290

Remove deprecated claim methods from Entity
Closed, ResolvedPublic
Actions

Description

"This is part of [ https://phabricator.wikimedia.org/T78287 ]"
https://github.com/wmde/WikibaseDataModel/issues/282

Details

SubjectRepoBranchLines +/-
[DNM] Drop unused EntityTestHelper::getTestEntity() methodmediawiki/extensions/Wikibasemaster+0 -280
Replace deprecated Item::setClaims in ChangeOp testsmediawiki/extensions/Wikibasemaster+144 -195
Replace deprecated Entity::addClaimmediawiki/extensions/Wikibasemaster+73 -109
Customize query in gerrit

Related Objects

Event Timeline

Lucie created this task.Dec 11 2014, 3:08 PM
Lucie raised the priority of this task from to Needs Triage.
Lucie updated the task description. (Show Details)
Lucie added projects: Wikibase-DataModel, Wikidata.
Lucie changed Security from none to None.
Lucie subscribed.
gerritbot subscribed.Apr 7 2015, 1:49 PM

Change 202389 had a related patch set uploaded (by Thiemo Mättig (WMDE)):
Replace deprecated Entity::addClaim

https://gerrit.wikimedia.org/r/202389

gerritbot added a project: Patch-For-Review.Apr 7 2015, 1:49 PM
gerritbot added a comment.Apr 7 2015, 4:48 PM

Change 202389 merged by jenkins-bot:
Replace deprecated Entity::addClaim

https://gerrit.wikimedia.org/r/202389

thiemowmde mentioned this in rEWBAc8fd18a78adf: Replace deprecated Entity::addClaim.Apr 7 2015, 4:48 PM
Diffusion mentioned this in rMEXTfaa368ae2aae: Updated mediawiki/extensions Project: mediawiki/extensions/Wikibase….Apr 7 2015, 4:48 PM
gerritbot added a comment.Apr 7 2015, 5:54 PM

Change 202453 had a related patch set uploaded (by Thiemo Mättig (WMDE)):
Drop dead code from EntityTestHelper

https://gerrit.wikimedia.org/r/202453

gerritbot added a comment.Apr 7 2015, 6:53 PM

Change 202468 had a related patch set uploaded (by Thiemo Mättig (WMDE)):
Replace deprecated Item::setClaims in ChangeOp tests

https://gerrit.wikimedia.org/r/202468

JanZerebecki added a project: Wikidata-Sprint-2015-04-07.Apr 8 2015, 1:21 PM
JanZerebecki moved this task from Backlog to Review on the Wikidata-Sprint-2015-04-07 board.
Tobi_WMDE_SW assigned this task to thiemowmde.Apr 16 2015, 12:51 PM
daniel subscribed.Apr 16 2015, 5:02 PM

One of the patches is marked [DNM] for some reason: https://gerrit.wikimedia.org/r/#/c/202453/

Also, are there additional changes needed before we can drop the old methods from the data model?

gerritbot added a comment.Apr 16 2015, 5:06 PM

Change 202468 merged by jenkins-bot:
Replace deprecated Item::setClaims in ChangeOp tests

https://gerrit.wikimedia.org/r/202468

thiemowmde mentioned this in rEWBAe9947e464d65: Replace deprecated Item::setClaims in ChangeOp tests.Apr 16 2015, 5:07 PM
Diffusion mentioned this in rMEXT9aad3c9512b4: Updated mediawiki/extensions Project: mediawiki/extensions/Wikibase….Apr 16 2015, 5:07 PM
thiemowmde added a comment.Apr 17 2015, 10:46 AM
gerritbot added a comment.Apr 17 2015, 1:13 PM

Change 202453 merged by jenkins-bot:
[DNM] Drop unused EntityTestHelper::getTestEntity() method

https://gerrit.wikimedia.org/r/202453

Diffusion mentioned this in rMEXTf1edeeee1fff: Updated mediawiki/extensions Project: mediawiki/extensions/Wikibase….Apr 17 2015, 1:13 PM
thiemowmde mentioned this in rEWBA3927967db322: [DNM] Drop unused EntityTestHelper::getTestEntity() method.Apr 17 2015, 1:14 PM
daniel closed this task as Resolved.Apr 20 2015, 5:55 PM

All patches are merged now

daniel moved this task from Review to Done on the Wikidata-Sprint-2015-04-07 board.Apr 20 2015, 5:55 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL