Nearby main menu button not hidden in browsers that don't support geolocation
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	phuedx
	Dec 17 2014, 12:00 PM

Description

While testing 180232 I noticed that the #mw-mf-page-left li.icon-nearby in

if ( !M.supportsGeoLocation() ) {		
    $( '#mw-mf-page-left li.icon-nearby' ).remove();		
}

no longer selects the menu item and so it isn't removed in browsers that don't support geolocation.

Related Changes in Gerrit:

	Subject	Repo	Branch	Lines +/-
	Hide the Nearby main menu button correctly	mediawiki/extensions/MobileFrontend	master	+2 -2

Mentioned In: rMEXT2744f497e8c7: Updated mediawiki/extensions Project: mediawiki/extensions/MobileFrontend…
rEMFRae5606a74f70: Hide the Nearby main menu button correctly

phuedx raised the priority of this task from to Needs Triage.

phuedx updated the task description. (Show Details)

phuedx changed Security from none to None.

phuedx subscribed.

Change 180454 had a related patch set uploaded (by Phuedx):
Hide the Nearby main menu button correctly

Change 180454 merged by jenkins-bot:
Hide the Nearby main menu button correctly

Jdlrobson closed this task as Resolved.Dec 17 2014, 7:18 PM

Jdlrobson claimed this task.