Page MenuHomePhabricator

Nearby main menu button not hidden in browsers that don't support geolocation
Closed, ResolvedPublic

Description

While testing 180232 I noticed that the #mw-mf-page-left li.icon-nearby in

if ( !M.supportsGeoLocation() ) {		
    $( '#mw-mf-page-left li.icon-nearby' ).remove();		
}

no longer selects the menu item and so it isn't removed in browsers that don't support geolocation.

Event Timeline

phuedx created this task.Dec 17 2014, 12:00 PM
phuedx raised the priority of this task from to Needs Triage.
phuedx updated the task description. (Show Details)
phuedx added a project: MobileFrontend-stable.
phuedx changed Security from none to None.
phuedx added a subscriber: phuedx.

Change 180454 had a related patch set uploaded (by Phuedx):
Hide the Nearby main menu button correctly

https://gerrit.wikimedia.org/r/180454

Patch-For-Review

Change 180454 merged by jenkins-bot:
Hide the Nearby main menu button correctly

https://gerrit.wikimedia.org/r/180454

Jdlrobson closed this task as Resolved.Dec 17 2014, 7:18 PM
Jdlrobson claimed this task.