Page MenuHomePhabricator

Nearby main menu button not hidden in browsers that don't support geolocation
Closed, ResolvedPublic

Description

While testing 180232 I noticed that the #mw-mf-page-left li.icon-nearby in

if ( !M.supportsGeoLocation() ) {		
    $( '#mw-mf-page-left li.icon-nearby' ).remove();		
}

no longer selects the menu item and so it isn't removed in browsers that don't support geolocation.

Event Timeline

phuedx raised the priority of this task from to Needs Triage.
phuedx updated the task description. (Show Details)
phuedx added a project: MobileFrontend-stable.
phuedx changed Security from none to None.
phuedx subscribed.

Change 180454 had a related patch set uploaded (by Phuedx):
Hide the Nearby main menu button correctly

https://gerrit.wikimedia.org/r/180454

Patch-For-Review

Change 180454 merged by jenkins-bot:
Hide the Nearby main menu button correctly

https://gerrit.wikimedia.org/r/180454

Jdlrobson claimed this task.