Page MenuHomePhabricator

With $wgUseTidy=false, </td> and </tr> is output as text.
Closed, ResolvedPublic

Description

Author: wegge

Description:
The URL points to a default installation of SVN HEAD. As can be seen, </td> is
translateted to &lt;/td&gt;, instead of being put into the html as normal close
tags. The only happens when $wgUseTidy is false.

Compare to the same text in my dawiki sandbox:
http://da.wikipedia.org/wiki/Bruger:Wegge/Sandkassen/Strange_things_when_%24wgUseTidy%3Dfalse


Version: 1.7.x
Severity: normal
URL: http://testwiki.wegge.dk/index.php/Strange_things_when_%24wgUseTidy%3Dfalse

Details

Reference
bz6171

Event Timeline

bzimport raised the priority of this task from to Medium.Nov 21 2014, 9:20 PM
bzimport added a project: MediaWiki-Parser.
bzimport set Reference to bz6171.
bzimport added a subscriber: Unknown Object (MLST).

wegge wrote:

Better handling of tags with optional close tags

Push optionally-closed tags on the parser stack, and skip them during unwind,
if no close tags are found.

Attached:

Cannot reproduce problem at the given URL.

wegge wrote:

No, not after i fixed it on my test installation. I still need someone to take a
look at the patch though.

wegge wrote:

Fixed in SVN. Added a testcase to the parser test, demonstrating that the
sanitizer still have a problem with optional end tags.

Fixed in r19400. We now automaticly close tags.

Parser tests seems fine:

<snip>
1 previously failing test(s) now PASSING! :)

  • TODO: Parsing optional HTML elements (Bug 6171)

18 still FAILING test(s) :(
<snip>