Page MenuHomePhabricator

Deleted images can still be deleted.
Closed, ResolvedPublic

Description

Author: supersammyfluff

Description:
I discovered this at the Homestar Runner Fanstuff Wiki
(http://fanstuff.hrwiki.org) a few days ago. While I was running my bot
(deleting images), I discovered that even if images had already been deleted,
they had been reported successfully deleted.

Basically, if I go to an URL such as
"/index.php?title=Non-existant_page&action=delete", it will tell me that the
page doesn't exist and won't let me do anything else. However, if I go to
something like "/index.php?title=Image:Non-existant_image.ext&action=delete",
the deletion page will come up as if it existed. I can then proceed to press
"Confirm", and it will tell me that the image has been deleted, although it
never even existed. No log entry or anything like that is generated.

Marked as minor because it doesn't really affect anything, although it can give
false outputs on bot runs.


Version: 1.8.x
Severity: minor

Details

Reference
bz6290

Event Timeline

bzimport raised the priority of this task from to Medium.Nov 21 2014, 9:21 PM
bzimport set Reference to bz6290.
bzimport added a subscriber: Unknown Object (MLST).

jimmy.collins wrote:

Bug is still present in 1.8-svn. This minor bug will not be backported to 1.5
branch - I will change Version to 1.8-svn.

jimmy.collins wrote:

patch for trunk

Attached you will find a patch.
Can somebody please double check it? I`m not sure concerning side effects.

Thanks!

Attached:

Images can have image revisions and no file revisions, so deleting non-existant
image pages is not "a bug". Perhaps if it also checks for the lack of existance
of file revisions, then action=delete could throw a bad title error.