I'm splitting this patch out of patch 1762 (bug 5985, "Allow images in the bad
image list to be used on specific pages"), as these changes have nothing to with
the bad image list whatsoever.
Version: 1.7.x
Severity: enhancement
Description
Description
Details
Details
- Reference
- bz6490
| Status | Subtype | Assigned | Task | ||
|---|---|---|---|---|---|
| Resolved | None | T8491 Apply bad image list in categories | |||
| Resolved | None | T8490 Clean up rendering code in ImageGallery.php |
Event Timeline
Comment Actions
Patch to clean up image gallery rendering code
This patch cleans up ImageGallery::toHTML(), factoring the HTML generation out
of the various error and corner cases.
attachment cleanupgalleryrendering.diff ignored as obsolete
Comment Actions
Patch to clean up image gallery rendering code (fixed)
Oops, didn't split the patch cleanly last time, the check for mParsing was
wrong. Should be fixed now.
attachment cleanupgalleryrendering.diff ignored as obsolete
Comment Actions
Patch to clean up image gallery rendering code (minor tweak)
Yet another version, this one wraps the error message given if thumbnailing
fails into a div, hopefully making it look better. (Can't really test that,
since I don't know how to generate such an error.)
attachment cleanupgalleryrendering.diff ignored as obsolete
Comment Actions
Patch to clean up image gallery rendering code (fixed after tweak)
That last patch had a bunch of unrelated crap included. This one's what I
meant to upload.
Attached: