Dropping user.user_options on wmf databases
Open, LowPublic

Description

DBA Update

The change is prepared at https://docs.google.com/document/d/1mw4CQxYyNP2PruzlG30dPVQjVOqJTC3Q_DLViIhWrm0/edit?usp=sharing

The alter to run is:

ALTER TABLE user DROP COLUMN IF EXISTS user_options;

Where to run the alter: s1, s2, s3, s4, s5, s6, s7, s8
When to run: start at 2018-11-14
If the schema change is backwards compatible: compatible with the current code deployed
If the schema change has been tested already on some of the test/beta wikis.: wikis created since 2011-09-28 doesn't have this column
If it is involves new columns to tables: no, it's a drop

Phases

Testing

  • db2046
  • db1088

Execution

  • s1
  • s2
  • s3
  • s4
  • s5
  • s6
  • s7
  • s8

s6

  • db2039 codfw master, execute with replication!
  • db1088
  • db1093
  • db1113
  • db1098
  • db1096
  • dbstore1002
  • dbstore1001
  • db1085 Sanitarium master, execute with replication!
  • db1061 MASTER

s2

  • db2035 codfw master, execute with replication!
  • db1076
  • db1090
  • db1095
  • db1103
  • db1105
  • db1122
  • dbstore1002
  • db1074 Sanitarium master , execute with replication!
  • db1066 MASTER

s5

  • db2052 codfw master, execute with replication!
  • db1096
  • db1097
  • db1100
  • db1102
  • db1110
  • db1113
  • dbstore1002
  • db1082 Sanitarium master , execute with replication!
  • db1070 MASTER

s4

  • db2051 codfw master, execute with replication!
  • db1081
  • db1084
  • db1091
  • db1097
  • db1102
  • db1103
  • dbstore1002
  • db1121 Sanitarium master , execute with replication!
  • db1068 MASTER

s7

  • db2040 codfw master, execute with replication!
  • db1086
  • db1090
  • db1094
  • db1098
  • db1101
  • db1116
  • dbstore1002
  • db1079 Sanitarium master , execute with replication!
  • db1062 MASTER

s8

  • db2045 codfw master, execute with replication!
  • db1092
  • db1099
  • db1101
  • db1104
  • db1109
  • db1116
  • db1087 Sanitarium master , execute with replication!
  • db1071 MASTER

s1

  • db2048 codfw master, execute with replication!
  • db1080
  • db1083
  • db1089
  • db1099
  • db1105
  • db1114
  • db1119
  • dbstore1002
  • dbstore1001
  • db1106 Sanitarium master , execute with replication!
  • db1066 MASTER

s3

  • db2043 codfw master, execute with replication!
  • db1078
  • db1095
  • db1123
  • dbstore1002
  • db1077 Sanitarium master , execute with replication!
  • db1075 MASTER

In CODFW (Secondary datacenter) the alter table command we need to use is:

./wmfmariadbpy/wmfmariadbpy/osc_host.py --method=ddl --host <section_codfw_master>.codfw.wmnet --dblist mediawiki-config/dblists/<section>.dblist --table user "DROP COLUMN IF EXISTS user_options"

On EQIAD (primary datacenter) the alter command will be (on all hots one by one, depooled except sanitarium master where we need replication):

./wmfmariadbpy/wmfmariadbpy/osc_host.py --no-repicate --method=ddl --host <hostname>.codfw.wmnet --dblist mediawiki-config/dblists/<section>.dblist --table user "DROP COLUMN IF EXISTS user_options"

On Sanitarium hosts we need to recreate the TRIGGERS as:

/home/banyek/T85757/fix_triggers.sh db2094:3315 s5

Original text
The column user.user_options is visible on ToolLabs (at least on dewiki_p). I assume that the field also exists on wmf wikis.

It was dropped with http://git.wikimedia.org/commit/mediawiki%2Fcore.git/eda06e8593c12b4359a46cf3b428c1a1a88e40c4 and should be dropped in production as well.

If it already dropped from production wikis, please move this task to ToolLabs to get the field also dropped there. Thanks.

There are a very large number of changes, so older changes are hidden. Show Older Changes

Mentioned in SAL (#wikimedia-operations) [2018-11-27T10:51:46Z] <banyek> repooling db1090 after schema change (T85757)

Mentioned in SAL (#wikimedia-operations) [2018-11-27T10:55:24Z] <banyek@deploy1001> Synchronized wmf-config/db-eqiad.php: T85757: repool db1090 (duration: 00m 46s)

Banyek updated the task description. (Show Details)Tue, Nov 27, 10:56 AM

Mentioned in SAL (#wikimedia-operations) [2018-11-27T10:59:35Z] <banyek> executing schema change on db1095 (T85757)

Banyek updated the task description. (Show Details)Tue, Nov 27, 11:27 AM

Mentioned in SAL (#wikimedia-operations) [2018-11-27T11:28:55Z] <banyek> depooling db1103 due a schema change (T85757)

Change 475742 merged by Banyek:
[operations/mediawiki-config@master] mariadb: depool db1103

https://gerrit.wikimedia.org/r/475742

Mentioned in SAL (#wikimedia-operations) [2018-11-27T11:32:09Z] <banyek@deploy1001> Synchronized wmf-config/db-eqiad.php: T85757: depool db1103 (duration: 00m 46s)

Mentioned in SAL (#wikimedia-operations) [2018-11-27T11:32:39Z] <banyek> executing schema change on db1103:3312 (T85757)

Mentioned in SAL (#wikimedia-operations) [2018-11-27T11:50:28Z] <banyek> repooling db1103 after schema change (T85757)

Banyek updated the task description. (Show Details)Tue, Nov 27, 11:51 AM

Mentioned in SAL (#wikimedia-operations) [2018-11-27T11:56:12Z] <banyek@deploy1001> Synchronized wmf-config/db-eqiad.php: T85757: repool db1103 (duration: 00m 46s)

Make sure to check whether wikitech (labswiki and labtestwiki) need this schema change

I checked on m5 master, the user tables doesn't have that column

Mentioned in SAL (#wikimedia-operations) [2018-11-27T13:14:21Z] <banyek> depooling db1105 due a schema change (T85757)

Change 475743 merged by Banyek:
[operations/mediawiki-config@master] mariadb: depool db1105

https://gerrit.wikimedia.org/r/475743

Mentioned in SAL (#wikimedia-operations) [2018-11-27T13:18:22Z] <banyek@deploy1001> Synchronized wmf-config/db-eqiad.php: T85757: depool db1105 (duration: 00m 46s)

Mentioned in SAL (#wikimedia-operations) [2018-11-27T13:18:42Z] <banyek> executing schema change on db1105 (T85757)

Make sure to check whether wikitech (labswiki and labtestwiki) need this schema change

I checked on m5 master, the user tables doesn't have that column

Great! Thanks for confirming!

Mentioned in SAL (#wikimedia-operations) [2018-11-27T14:00:26Z] <banyek> repooling db1105 due a schema change (T85757)

Banyek updated the task description. (Show Details)Tue, Nov 27, 5:56 PM

Mentioned in SAL (#wikimedia-operations) [2018-11-28T15:10:46Z] <banyek> depooling db1122 due schema change (T85757)

Change 475744 merged by jenkins-bot:
[operations/mediawiki-config@master] mariadb: depool db1122

https://gerrit.wikimedia.org/r/475744

Mentioned in SAL (#wikimedia-operations) [2018-11-28T15:17:35Z] <banyek@deploy1001> Synchronized wmf-config/db-eqiad.php: T85757: depool db1122 (duration: 00m 53s)

Mentioned in SAL (#wikimedia-operations) [2018-11-28T15:19:12Z] <banyek> Deploy schema change on db1122 - T85757

Mentioned in SAL (#wikimedia-operations) [2018-11-28T15:52:10Z] <banyek> repooling db1122 after schema change (T85757)

Mentioned in SAL (#wikimedia-operations) [2018-11-28T15:55:24Z] <banyek@deploy1001> Synchronized wmf-config/db-eqiad.php: T85757: repool db1122 (duration: 00m 53s)

Banyek updated the task description. (Show Details)Wed, Nov 28, 3:55 PM

Mentioned in SAL (#wikimedia-operations) [2018-11-30T11:07:48Z] <banyek> deploy schema change on dbstore1002 - T85757

Banyek updated the task description. (Show Details)Fri, Nov 30, 11:10 AM

Mentioned in SAL (#wikimedia-operations) [2018-12-03T08:43:10Z] <banyek> depooling db1074 - T85757

Change 475739 merged by jenkins-bot:
[operations/mediawiki-config@master] mariadb: depool db1074

https://gerrit.wikimedia.org/r/475739

Mentioned in SAL (#wikimedia-operations) [2018-12-03T08:49:30Z] <banyek@deploy1001> Synchronized wmf-config/db-eqiad.php: T85757: depool db1074 (duration: 00m 48s)

Mentioned in SAL (#wikimedia-operations) [2018-12-03T08:50:45Z] <banyek> stopping replication on db1074 - T85757

Mentioned in SAL (#wikimedia-operations) [2018-12-03T09:16:42Z] <banyek> repooling db1074 - T85757

Banyek updated the task description. (Show Details)Mon, Dec 3, 9:17 AM

Mentioned in SAL (#wikimedia-operations) [2018-12-03T09:22:10Z] <banyek@deploy1001> Synchronized wmf-config/db-eqiad.php: T85757: repool db1074 (duration: 00m 47s)

Mentioned in SAL (#wikimedia-operations) [2018-12-03T09:27:25Z] <banyek> executing schema change on db1066 (s2 master) - T85757

Banyek updated the task description. (Show Details)Mon, Dec 3, 9:37 AM

Change 477588 had a related patch set uploaded (by Banyek; owner: Banyek):
[operations/mediawiki-config@master] mariadb: depool db1082

https://gerrit.wikimedia.org/r/477588

Change 477589 had a related patch set uploaded (by Banyek; owner: Banyek):
[operations/mediawiki-config@master] mariadb: depool db1096:3315

https://gerrit.wikimedia.org/r/477589

Change 477590 had a related patch set uploaded (by Banyek; owner: Banyek):
[operations/mediawiki-config@master] mariadb: depool db1097:3315

https://gerrit.wikimedia.org/r/477590

Change 477591 had a related patch set uploaded (by Banyek; owner: Banyek):
[operations/mediawiki-config@master] mariadb: depool db1100

https://gerrit.wikimedia.org/r/477591

Change 477592 had a related patch set uploaded (by Banyek; owner: Banyek):
[operations/mediawiki-config@master] mariadb: depool db1110

https://gerrit.wikimedia.org/r/477592

Change 477593 had a related patch set uploaded (by Banyek; owner: Banyek):
[operations/mediawiki-config@master] mariadb: depool db1113:3315

https://gerrit.wikimedia.org/r/477593

Mentioned in SAL (#wikimedia-operations) [2018-12-05T14:56:27Z] <banyek> executing schema change on s5 codfw master replication lag could be expected - T85757

Banyek updated the task description. (Show Details)Wed, Dec 5, 3:10 PM
Banyek updated the task description. (Show Details)

Mentioned in SAL (#wikimedia-operations) [2018-12-06T10:29:55Z] <banyek> depooling db1096 for schema change - T85757

Change 477589 merged by jenkins-bot:
[operations/mediawiki-config@master] mariadb: depool db1096:3315

https://gerrit.wikimedia.org/r/477589

Mentioned in SAL (#wikimedia-operations) [2018-12-06T10:36:57Z] <banyek@deploy1001> Synchronized wmf-config/db-eqiad.php: T85757: depool db1096:3315 (duration: 00m 49s)

Mentioned in SAL (#wikimedia-operations) [2018-12-06T10:56:16Z] <banyek> repooling db1096 for schema change - T85757

Mentioned in SAL (#wikimedia-operations) [2018-12-06T10:59:49Z] <banyek@deploy1001> Synchronized wmf-config/db-eqiad.php: T85757: repool db1096:3315 (duration: 00m 47s)

Banyek updated the task description. (Show Details)Mon, Dec 10, 3:12 PM

Mentioned in SAL (#wikimedia-operations) [2018-12-10T15:13:05Z] <banyek> depooling db1097:3315 on a schema change - T85757

Change 477590 merged by Banyek:
[operations/mediawiki-config@master] mariadb: depool db1097:3315

https://gerrit.wikimedia.org/r/477590

Mentioned in SAL (#wikimedia-operations) [2018-12-10T15:24:45Z] <banyek@deploy1001> Synchronized wmf-config/db-eqiad.php: T85757: depool db1097:3315 (duration: 00m 46s)

Mentioned in SAL (#wikimedia-operations) [2018-12-10T15:31:02Z] <banyek> repooling db1097:3315 after schema change - T85757

Mentioned in SAL (#wikimedia-operations) [2018-12-10T15:36:39Z] <banyek@deploy1001> Synchronized wmf-config/db-eqiad.php: T85757: repool db1097:3315 (duration: 00m 45s)

Banyek updated the task description. (Show Details)Mon, Dec 10, 3:37 PM

Mentioned in SAL (#wikimedia-operations) [2018-12-11T16:09:45Z] <banyek> depooling db1100 for schema change - T85757

Change 477591 merged by Banyek:
[operations/mediawiki-config@master] mariadb: depool db1100

https://gerrit.wikimedia.org/r/477591

Mentioned in SAL (#wikimedia-operations) [2018-12-11T16:15:00Z] <banyek@deploy1001> Synchronized wmf-config/db-eqiad.php: T85757: depool db1100 (duration: 00m 52s)

Mentioned in SAL (#wikimedia-operations) [2018-12-11T16:20:24Z] <banyek> repooling db1100 after schema change - T85757

Banyek updated the task description. (Show Details)Tue, Dec 11, 4:21 PM

Mentioned in SAL (#wikimedia-operations) [2018-12-11T16:23:15Z] <banyek@deploy1001> Synchronized wmf-config/db-eqiad.php: T85757: repool db1100 (duration: 00m 51s)

Mentioned in SAL (#wikimedia-operations) [2018-12-11T16:25:44Z] <banyek> depooling db1110 for schema change - T85757

Change 477592 merged by Banyek:
[operations/mediawiki-config@master] mariadb: depool db1110

https://gerrit.wikimedia.org/r/477592

Mentioned in SAL (#wikimedia-operations) [2018-12-11T16:28:46Z] <banyek@deploy1001> Synchronized wmf-config/db-eqiad.php: T85757: depool db1110 (duration: 00m 50s)

Mentioned in SAL (#wikimedia-operations) [2018-12-11T16:32:18Z] <banyek> repooling db1110 after schema change - T85757

Mentioned in SAL (#wikimedia-operations) [2018-12-11T16:33:35Z] <banyek@deploy1001> Synchronized wmf-config/db-eqiad.php: T85757: repool db1110 (duration: 00m 51s)

Banyek updated the task description. (Show Details)Tue, Dec 11, 4:34 PM

Mentioned in SAL (#wikimedia-operations) [2018-12-11T16:35:27Z] <banyek> depooling db1113:3315 for schema change - T85757

Change 477593 merged by Banyek:
[operations/mediawiki-config@master] mariadb: depool db1113:3315

https://gerrit.wikimedia.org/r/477593

Mentioned in SAL (#wikimedia-operations) [2018-12-11T16:38:12Z] <banyek@deploy1001> Synchronized wmf-config/db-eqiad.php: T85757: depool db1113:3315 (duration: 00m 51s)

Mentioned in SAL (#wikimedia-operations) [2018-12-11T16:44:19Z] <banyek> repooling db1113:3315 after schema change - T85757

Banyek updated the task description. (Show Details)Tue, Dec 11, 4:45 PM

Mentioned in SAL (#wikimedia-operations) [2018-12-11T16:48:32Z] <banyek@deploy1001> Synchronized wmf-config/db-eqiad.php: T85757: repool db1113:3315 (duration: 00m 51s)

Mentioned in SAL (#wikimedia-operations) [2018-12-11T16:49:12Z] <banyek> executing schema change on db1102 - T85757

Banyek updated the task description. (Show Details)Tue, Dec 11, 4:55 PM

Mentioned in SAL (#wikimedia-operations) [2018-12-11T16:55:19Z] <banyek> executing schema change on dbstore1002 - T85757

Banyek updated the task description. (Show Details)Tue, Dec 11, 4:57 PM

Mentioned in SAL (#wikimedia-operations) [2018-12-12T08:38:29Z] <banyek> depooling db1082 for schema change - T85757

Change 477588 merged by jenkins-bot:
[operations/mediawiki-config@master] mariadb: depool db1082

https://gerrit.wikimedia.org/r/477588

Mentioned in SAL (#wikimedia-operations) [2018-12-12T08:48:57Z] <banyek@deploy1001> Synchronized wmf-config/db-eqiad.php: T85757: depool db1082 (duration: 00m 51s)

Mentioned in SAL (#wikimedia-operations) [2018-12-12T09:20:58Z] <banyek> stopping replication on db1082 for schema change - T85757

Mentioned in SAL (#wikimedia-operations) [2018-12-12T09:22:38Z] <banyek> executing schema change with replication on db1082 - T85757

Mentioned in SAL (#wikimedia-operations) [2018-12-12T09:25:08Z] <banyek> fixing triggers on db1124:3315- T85757

Mentioned in SAL (#wikimedia-operations) [2018-12-12T09:25:40Z] <banyek> restarting replication on db1082 after schema change - T85757

Mentioned in SAL (#wikimedia-operations) [2018-12-12T09:29:06Z] <banyek> repooling db1082 - T85757

Mentioned in SAL (#wikimedia-operations) [2018-12-12T09:34:44Z] <banyek@deploy1001> Synchronized wmf-config/db-eqiad.php: T85757: repool db1082 (duration: 00m 52s)

Banyek updated the task description. (Show Details)Wed, Dec 12, 9:35 AM

Mentioned in SAL (#wikimedia-operations) [2018-12-12T10:08:45Z] <banyek> executing schema change on db1070 (s5 master) - T85757

Banyek updated the task description. (Show Details)Wed, Dec 12, 10:16 AM
hoo removed a subscriber: hoo.Wed, Dec 12, 11:05 AM

Change 479631 had a related patch set uploaded (by Banyek; owner: Banyek):
[operations/mediawiki-config@master] mariadb: depool db1081

https://gerrit.wikimedia.org/r/479631

Change 479634 had a related patch set uploaded (by Banyek; owner: Banyek):
[operations/mediawiki-config@master] mariadb: depool db1084

https://gerrit.wikimedia.org/r/479634

Change 479638 had a related patch set uploaded (by Banyek; owner: Banyek):
[operations/mediawiki-config@master] mariadb: depool db1091

https://gerrit.wikimedia.org/r/479638

Change 479642 had a related patch set uploaded (by Banyek; owner: Banyek):
[operations/mediawiki-config@master] mariadb: depool db1097:3314

https://gerrit.wikimedia.org/r/479642

Change 479644 had a related patch set uploaded (by Banyek; owner: Banyek):
[operations/mediawiki-config@master] mariadb: depool db1103:3314

https://gerrit.wikimedia.org/r/479644

Change 479646 had a related patch set uploaded (by Banyek; owner: Banyek):
[operations/mediawiki-config@master] mariadb: depool db1121

https://gerrit.wikimedia.org/r/479646