Page MenuHomePhabricator
Create Task
Maniphest T86139

Messages with names starting with a capital letter appear in unexpected places in Special:AllMessages
Closed, ResolvedPublic
Actions

Description

The third message on https://en.wikipedia.org/wiki/Special:AllMessages is wikiLove.js, between the numbers and the messages starting with a. On the second and probably all other pages (https://en.wikipedia.org/w/index.php?title=Special:AllMessages&offset=Abusefilter-edit-builder-funcs-ccnorm) it is the first message. The same happens in de.wikipedia and probably other projects.

This has obviously something to do with the fact that in WikiLove/i18n/en.json (and the other localization files) WikiLove.js is defined with a capital letter.

Either at some place in core the first letter of a message key has to be transformed into lowercase, or (possible easier) that message should just be changed to wikiLove.js

Details

SubjectRepoBranchLines +/-
Special:AllMessages: Ignore case of first letter when sortingmediawiki/coremaster+4 -3
Customize query in gerrit

Related Objects

Event Timeline

Schnark created this task.Jan 8 2015, 8:30 AM
Schnark raised the priority of this task from to Needs Triage.
Schnark updated the task description. (Show Details)
Schnark added projects: MediaWiki-Special-pages, WikiLove, I18n.
Schnark subscribed.
Aklapper triaged this task as Lowest priority.Jan 8 2015, 1:43 PM
• Mattflaschen-WMF subscribed.Jan 8 2015, 7:09 PM

This seems like a core issue (specifically, the weird way WikiLove.js is at the top of the second and all later pages).

However, we can work around it by changing the name to wikiLove.js (due to the auto-capitalization of the initial character, MediaWiki:wikiLove.js and MediaWiki:WikiLove.js are the same anyway, just as https://en.wikipedia.org/wiki/MediaWiki:common.js and https://en.wikipedia.org/wiki/MediaWiki:Common.js are the same).

Schnark added a comment.Jan 9 2015, 8:38 AM

Looking at https://wikiapiary.com/wiki/Extension:WikiLove this behavior seems to be introduced with the conversion to JSON, http://cidian.jidutu.org/wiki/Special:%E6%89%80%E6%9C%89%E6%B6%88%E6%81%AF (which uses MW 1.22.6) is correct, while all wikis with 1.23 and newer show the described bug.

Umherirrender claimed this task.Jan 24 2015, 10:05 AM
gerritbot added a project: Patch-For-Review.Jan 24 2015, 10:06 AM
gerritbot subscribed.

Change 186584 had a related patch set uploaded (by Umherirrender):
Special:AllMessages: Ignore case of first letter when sorting

https://gerrit.wikimedia.org/r/186584

Patch-For-Review

Schniggendiller subscribed.Jan 28 2015, 2:55 PM
gerritbot added a comment.Jan 28 2015, 8:52 PM

Change 186584 merged by jenkins-bot:
Special:AllMessages: Ignore case of first letter when sorting

https://gerrit.wikimedia.org/r/186584

Umherirrender mentioned this in rMW227205f6d5ce: Special:AllMessages: Ignore case of first letter when sorting.Jan 28 2015, 8:52 PM
Umherirrender closed this task as Resolved.Jan 28 2015, 8:54 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL