Page MenuHomePhabricator

PHP fatal error on bad input to Special:Movepage
Closed, ResolvedPublic

Description

Author: nickpj

Description:
http://en.wikipedia.org/w/index.php?title=Special:Movepage&action=success

Will show blank page (due to error logging); but on a non-error-logging wiki,

the same thing will display this PHP fatal error as the output:

Fatal error: Call to a member function isTalkPage() on a non-object in

/var/www/hosts/mediawiki/phase3/includes/SpecialMovepage.php on line 269


Version: 1.8.x
Severity: normal
URL: http://en.wikipedia.org/w/index.php?title=Special:Movepage&action=success

Details

Reference
bz6615

Event Timeline

bzimport raised the priority of this task from to Medium.Nov 21 2014, 9:16 PM
bzimport set Reference to bz6615.
bzimport added a subscriber: Unknown Object (MLST).

I'm not sure if this is a bug. There are lots of ways to generate PHP error
messages, some of them are beyond our control. I don't think it's a
security issue, it's barely a code quality issue. I guess the only issue is
whether it generates unwanted noise in automated testing.

It's certainly a bug, though quite likely entirely harmless.

wclark wrote:

Patch to fix null object bug

Attached:

rotemliss wrote:

Applied to r16436, but changed a bit.