Maniphest T86158

Add regression tests for slave-script tools
Closed, DeclinedPublic
Actions

Assigned To

Authored By

	Krinkle
	Jan 8 2015, 12:24 PM

Tags

Referenced Files

None

Subscribers

Description

Simple tests to verify basic boolean test cases for all tools:

yamllint pass valid file, rejects invalid file. (T76508)
jshint pass valid file, rejects invalid file.
..

Details

	Subject	Repo	Branch	Lines +/-
	Test for /tools/yamllint.py	integration/jenkins	master	+84 -0

Customize query in gerrit

Related Objects

Mentioned Here: T76508: yamllint no longer fails on invalid syntax

Event Timeline

Krinkle created this task.Jan 8 2015, 12:24 PM

Krinkle raised the priority of this task from to Needs Triage.

Krinkle updated the task description. (Show Details)

Krinkle added a project: Continuous-Integration-Infrastructure.

Krinkle updated the task description. (Show Details)

Krinkle set Security to None.

Krinkle added subscribers: Krinkle, hashar.

Change 183525 had a related patch set uploaded (by Hashar):
Test for /tools/yamllint.py

https://gerrit.wikimedia.org/r/183525

Patch-For-Review

Change 183525 abandoned by Hashar:
Test for /tools/yamllint.py

Reason:
YAML is used by different implementations (python/javascript etc). Lets delegate the YAML validation to the repository tests instead of trying to get a generic yaml linter.

https://gerrit.wikimedia.org/r/183525

Most integration/slave-script tools have been frozen and deprecated in favour of test entry points. Writing tests will not be needed.

Krinkle removed a project: Patch-For-Review.Mar 2 2015, 2:03 PM

hashar moved this task from Untriaged to Done on the Continuous-Integration-Infrastructure board.Mar 4 2015, 10:13 AM

I agree, thanks Timo for the cleanup.