Page MenuHomePhabricator
Create Task
Maniphest T86651

Fix LVS "sh" shortcomings
Closed, DuplicatePublic
Actions

Description

The LVS^WIPVS' "sh" (source hash) scheduler which we use for traffic to 443, currently has several shortcomings, among them the lack of a consistent hash ring and a limitation of sum(weight) == 256 (adjustable via build-time kernel option). We should fix these shortcomings and push them upstream.

Related Objects
Search...

StatusSubtypeAssignedTask
 OpenNoneT175203 Implement stateless TCP balancing in our LVS servers
 DuplicateNoneT86651 Fix LVS "sh" shortcomings

Event Timeline

faidon created this task.Jan 13 2015, 1:59 PM
faidon raised the priority of this task from to Low.
faidon updated the task description. (Show Details)
faidon added a project: ops-core.
faidon added subscribers: Aklapper, faidon, mark.
mark added a comment.Jan 13 2015, 2:02 PM

FWIW: An alternative sh implementation that I've written for an old kernel and fixes some of these issues (a looong time ago), lives here.

faidon set Security to None.Jan 13 2015, 2:04 PM
faidon added a subscriber: BBlack.
BBlack mentioned this in T175203: Implement stateless TCP balancing in our LVS servers.Sep 6 2017, 7:36 PM
BBlack added a parent task: T175203: Implement stateless TCP balancing in our LVS servers.
BBlack added a comment.Jul 26 2018, 8:02 PM

https://github.com/vincentbernat/ip_vs_mh is available as a backport, or will be in 4.18 upstream releases.

• Phabricator_maintenance moved this task from Backlog to Acknowledged on the SRE board.Jan 26 2019, 7:58 PM
LSobanski added a project: Traffic.Jan 9 2023, 2:42 PM
BBlack closed this task as a duplicate of T263797: Switch Source Hashing ('sh') scheduling on LVS hosts to Maglev hashing ('mh').Jan 9 2023, 2:44 PM
Krinkle subscribed.Jun 5 2023, 4:00 PM
In T86651#973435, @mark wrote:

FWIW: An alternative sh implementation that I've written for an old kernel and fixes some of these issues (a looong time ago), lives here.

Updated link: https://phabricator.wikimedia.org/diffusion/SVN/browse/trunk/routing/lvs/net/ipv4/ipvs/ip_vs_wcsh.c

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits