Page MenuHomePhabricator

yamllint on integration/jenkins.git broken due to running on example files from vendor/node_modules
Closed, ResolvedPublic

Description

yamllint is broken on master because it also runs on vendor and node_modules directories and some upstream modules contain example files that don't lint (by design).

https://integration.wikimedia.org/ci/job/integration-jenkins-yamllint/149/console

23:52:35 + /srv/deployment/integration/slave-scripts/tools/yamllint.py /srv/ssd/jenkins-slave/workspace/integration-jenkins-yamllint
23:52:35 ERROR Invalid file /srv/ssd/jenkins-slave/workspace/integration-jenkins-yamllint/tools/node_modules/grunt/node_modules/js-yaml/examples/custom_types.yaml raised: could not determine a constructor for the tag '!space'
23:52:35   in "/srv/ssd/jenkins-slave/workspace/integration-jenkins-yamllint/tools/node_modules/grunt/node_modules/js-yaml/examples/custom_types.yaml", line 3, column 3

We need a way to exclude directories and files. Or alternatively, switch to something like Grunt with a yamllint task and run it with a whitelist file pattern (like for jscs).

Event Timeline

Krinkle raised the priority of this task from to Needs Triage.
Krinkle updated the task description. (Show Details)
Krinkle added subscribers: Krinkle, hashar.
Krinkle assigned this task to hashar.
Krinkle triaged this task as Unbreak Now! priority.
Krinkle set Security to None.