Page MenuHomePhabricator
Create Task
Maniphest T86886

{{noexternallanglinks}} stopped working
Closed, ResolvedPublic2 Estimated Story Points
Actions

Description

See https://de.wikipedia.org/wiki/Wikipedia:Hauptseite (or any other main page). Only the 51 language links defined in https://de.wikipedia.org/wiki/Wikipedia:Hauptseite/Interwikis should be shown, but the {{noexternallanglinks}}, that should prevent the automatic use of all links from the Wikidata item apparently stopped working with the update to 1.25wmf14.

Details

SubjectRepoBranchLines +/-
Fix passing arguments in NoLangLinkHandlermediawiki/extensions/Wikibasemaster+27 -15
Revert "Make NoLangLinkHandler testable."mediawiki/extensions/Wikibasemaster+11 -86
Revert "Make NoLangLinkHandler testable."mediawiki/extensions/Wikibasewmf/1.25wmf14+11 -86
Customize query in gerrit

Related Objects

Event Timeline

Schnark created this task.Jan 15 2015, 8:45 AM
Schnark raised the priority of this task from to Needs Triage.
Schnark updated the task description. (Show Details)
Schnark added projects: MediaWiki-extensions-WikibaseClient, Regression.
Schnark subscribed.
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJan 15 2015, 8:45 AM
Raymond subscribed.Jan 15 2015, 8:49 AM
Stryn subscribed.Jan 15 2015, 9:15 AM
gerritbot added a project: Patch-For-Review.Jan 15 2015, 9:30 AM
gerritbot subscribed.

Change 185135 had a related patch set uploaded (by Aude):
Revert "Make NoLangLinkHandler testable."

https://gerrit.wikimedia.org/r/185135

Patch-For-Review

gerritbot added a comment.Jan 15 2015, 9:32 AM

Change 185136 had a related patch set uploaded (by Aude):
Revert "Make NoLangLinkHandler testable."

https://gerrit.wikimedia.org/r/185136

Patch-For-Review

gerritbot added a comment.Jan 15 2015, 9:45 AM

Change 185136 merged by jenkins-bot:
Revert "Make NoLangLinkHandler testable."

https://gerrit.wikimedia.org/r/185136

aude mentioned this in rEWBA9979bb324a88: Revert "Make NoLangLinkHandler testable.".Jan 15 2015, 9:45 AM
aude subscribed.Jan 15 2015, 10:11 AM

fixed and just deployed the fix.

aude added a project: Wikidata-Sprint-2015-01-08§.Jan 15 2015, 10:11 AM
aude set Security to None.

still not fixed in master though. ideally we do a real fix instead of revert, but either way needs to be fixed.

gerritbot added a comment.Jan 15 2015, 12:49 PM

Change 185161 had a related patch set uploaded (by Aude):
Fix passing arguments in NoLangLinkHandler

https://gerrit.wikimedia.org/r/185161

Patch-For-Review

aude edited a custom field.Jan 15 2015, 12:50 PM
aude moved this task from Backlog to Review on the Wikidata-Sprint-2015-01-08§ board.
gerritbot added a comment.Jan 15 2015, 12:52 PM

Change 185135 abandoned by Aude:
Revert "Make NoLangLinkHandler testable."

Reason:
see https://gerrit.wikimedia.org/r/#/c/185161/ instead

https://gerrit.wikimedia.org/r/185135

Lydia_Pintscher added a project: Wikidata.Jan 15 2015, 1:32 PM
gerritbot added a comment.Jan 15 2015, 2:04 PM

Change 185161 merged by jenkins-bot:
Fix passing arguments in NoLangLinkHandler

https://gerrit.wikimedia.org/r/185161

aude mentioned this in rEWBAc7e6c0521bfc: Fix passing arguments in NoLangLinkHandler.Jan 15 2015, 2:04 PM
aude closed this task as Resolved.Jan 15 2015, 4:48 PM
aude moved this task from Review to Done on the Wikidata-Sprint-2015-01-08§ board.
Ricordisamoa subscribed.Jan 21 2015, 1:26 PM
Diffusion mentioned this in rMEXTdaae284d5d5f: Updated mediawiki/extensions Project: mediawiki/extensions/Wikibase….Mar 11 2015, 6:24 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits