Flow - Error in component handler: loadHandler
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	Quiddity
	Jan 20 2015, 11:28 PM

Description

Error in webconsole, when navigating to https://www.mediawiki.org/wiki/Topic:S6q53exrf5ir908w
or any Topic page.

Error not seen at beta.wmflabs, but it is at test.wikipedia e.g. https://test.wikipedia.org/wiki/Topic:S9rxj99szthm6z3h

"[FLOW] " "Error in component handler:" "loadHandler" Error: Template undefined.handlebars not found in module ext.flow.templating
Stack trace:
mw.template.get@https://bits.wikimedia.org/www.mediawiki.org/load.php?debug=false&lang=en&modules=jquery%2Cmediawiki&only=scripts&skin=vector&version=20150114T203203Z line 4 > eval:3:58
FlowHandlebars.prototype.getTemplate@https://bits.wikimedia.org/www.mediawiki.org/load.php?debug=false&lang=en&modules=jquery%2Cmediawiki&only=scripts&skin=vector&version=20150114T203203Z line 4 > eval:116:72489
FlowHandlebars.prototype.processTemplate@https://bits.wikimedia.org/www.mediawiki.org/load.php?debug=false&lang=en&modules=jquery%2Cmediawiki&only=scripts&skin=vector&version=20150114T203203Z line 4 > eval:116:72819
FlowHandlebars.prototype.processTemplateGetFragment@https://bits.wikimedia.org/www.mediawiki.org/load.php?debug=false&lang=en&modules=jquery%2Cmediawiki&only=scripts&skin=vector&version=20150114T203203Z line 4 > eval:117:161
flowBoardComponentTocFeatureElementLoadTopicTitle@https://bits.wikimedia.org/www.mediawiki.org/load.php?debug=false&lang=en&modules=jquery%2Cmediawiki&only=scripts&skin=vector&version=20150114T203203Z line 4 > eval:251:228
flowLoadHandlerCallback/<@https://bits.wikimedia.org/www.mediawiki.org/load.php?debug=false&lang=en&modules=jquery%2Cmediawiki&only=scripts&skin=vector&version=20150114T203203Z line 4 > eval:188:16
.each@https://bits.wikimedia.org/www.mediawiki.org/load.php?debug=false&lang=en&modules=jquery%2Cmediawiki&only=scripts&skin=vector&version=20150114T203203Z:5:226
flowLoadHandlerCallback@https://bits.wikimedia.org/www.mediawiki.org/load.php?debug=false&lang=en&modules=jquery%2Cmediawiki&only=scripts&skin=vector&version=20150114T203203Z line 4 > eval:187:1
bindFlowComponentHandlers/</<@https://bits.wikimedia.org/www.mediawiki.org/load.php?debug=false&lang=en&modules=jquery%2Cmediawiki&only=scripts&skin=vector&version=20150114T203203Z line 4 > eval:182:192
emitWithReturn@https://bits.wikimedia.org/www.mediawiki.org/load.php?debug=false&lang=en&modules=jquery%2Cmediawiki&only=scripts&skin=vector&version=20150114T203203Z line 4 > eval:181:814
flowMakeContentInteractiveCallback/<@https://bits.wikimedia.org/www.mediawiki.org/load.php?debug=false&lang=en&modules=jquery%2Cmediawiki&only=scripts&skin=vector&version=20150114T203203Z line 4 > eval:187:249
.each@https://bits.wikimedia.org/www.mediawiki.org/load.php?debug=false&lang=en&modules=jquery%2Cmediawiki&only=scripts&skin=vector&version=20150114T203203Z:5:226
jQuery.prototype.each@https://bits.wikimedia.org/www.mediawiki.org/load.php?debug=false&lang=en&modules=jquery%2Cmediawiki&only=scripts&skin=vector&version=20150114T203203Z:2:215
flowMakeContentInteractiveCallback@https://bits.wikimedia.org/www.mediawiki.org/load.php?debug=false&lang=en&modules=jquery%2Cmediawiki&only=scripts&skin=vector&version=20150114T203203Z line 4 > eval:186:1
bindFlowComponentHandlers/</<@https://bits.wikimedia.org/www.mediawiki.org/load.php?debug=false&lang=en&modules=jquery%2Cmediawiki&only=scripts&skin=vector&version=20150114T203203Z line 4 > eval:182:192
emitWithReturn@https://bits.wikimedia.org/www.mediawiki.org/load.php?debug=false&lang=en&modules=jquery%2Cmediawiki&only=scripts&skin=vector&version=20150114T203203Z line 4 > eval:181:814
flowBoardComponentReinitializeContainer@https://bits.wikimedia.org/www.mediawiki.org/load.php?debug=false&lang=en&modules=jquery%2Cmediawiki&only=scripts&skin=vector&version=20150114T203203Z line 4 > eval:203:336
FlowBoardComponent@https://bits.wikimedia.org/www.mediawiki.org/load.php?debug=false&lang=en&modules=jquery%2Cmediawiki&only=scripts&skin=vector&version=20150114T203203Z line 4 > eval:201:945
initFlowComponent/_RecursiveConstructor@https://bits.wikimedia.org/www.mediawiki.org/load.php?debug=false&lang=en&modules=jquery%2Cmediawiki&only=scripts&skin=vector&version=20150114T203203Z line 4 > eval:173:571
initFlowComponent@https://bits.wikimedia.org/www.mediawiki.org/load.php?debug=false&lang=en&modules=jquery%2Cmediawiki&only=scripts&skin=vector&version=20150114T203203Z line 4 > eval:174:152
@https://bits.wikimedia.org/www.mediawiki.org/load.php?debug=false&lang=en&modules=jquery%2Cmediawiki&only=scripts&skin=vector&version=20150114T203203Z line 4 > eval:253:461
jQuery.Callbacks/fire@https://bits.wikimedia.org/www.mediawiki.org/load.php?debug=false&lang=en&modules=jquery%2Cmediawiki&only=scripts&skin=vector&version=20150114T203203Z:45:106
jQuery.Callbacks/self.add@https://bits.wikimedia.org/www.mediawiki.org/load.php?debug=false&lang=en&modules=jquery%2Cmediawiki&only=scripts&skin=vector&version=20150114T203203Z:45:664
jQuery.fn.ready@https://bits.wikimedia.org/www.mediawiki.org/load.php?debug=false&lang=en&modules=jquery%2Cmediawiki&only=scripts&skin=vector&version=20150114T203203Z:49:40
@https://bits.wikimedia.org/www.mediawiki.org/load.php?debug=false&lang=en&modules=jquery%2Cmediawiki&only=scripts&skin=vector&version=20150114T203203Z line 4 > eval:253:432
@https://bits.wikimedia.org/www.mediawiki.org/load.php?debug=false&lang=en&modules=jquery%2Cmediawiki&only=scripts&skin=vector&version=20150114T203203Z line 4 > eval:253:420
runScript@https://bits.wikimedia.org/www.mediawiki.org/load.php?debug=false&lang=en&modules=jquery%2Cmediawiki&only=scripts&skin=vector&version=20150114T203203Z:161:153
execute/</checkCssHandles@https://bits.wikimedia.org/www.mediawiki.org/load.php?debug=false&lang=en&modules=jquery%2Cmediawiki&only=scripts&skin=vector&version=20150114T203203Z:161:638
execute@https://bits.wikimedia.org/www.mediawiki.org/load.php?debug=false&lang=en&modules=jquery%2Cmediawiki&only=scripts&skin=vector&version=20150114T203203Z:162:417
mw.loader</<.implement@https://bits.wikimedia.org/www.mediawiki.org/load.php?debug=false&lang=en&modules=jquery%2Cmediawiki&only=scripts&skin=vector&version=20150114T203203Z:168:858
@https://bits.wikimedia.org/www.mediawiki.org/load.php?debug=false&lang=en&modules=jquery%2Cmediawiki&only=scripts&skin=vector&version=20150114T203203Z line 4 > eval:154:1
.globalEval/<@https://bits.wikimedia.org/www.mediawiki.org/load.php?debug=false&lang=en&modules=jquery%2Cmediawiki&only=scripts&skin=vector&version=20150114T203203Z:4:666
.globalEval@https://bits.wikimedia.org/www.mediawiki.org/load.php?debug=false&lang=en&modules=jquery%2Cmediawiki&only=scripts&skin=vector&version=20150114T203203Z:4:632
mw.loader</<.work@https://bits.wikimedia.org/www.mediawiki.org/load.php?debug=false&lang=en&modules=jquery%2Cmediawiki&only=scripts&skin=vector&version=20150114T203203Z:164:737
request@https://bits.wikimedia.org/www.mediawiki.org/load.php?debug=false&lang=en&modules=jquery%2Cmediawiki&only=scripts&skin=vector&version=20150114T203203Z:162:928
mw.loader</<.load@https://bits.wikimedia.org/www.mediawiki.org/load.php?debug=false&lang=en&modules=jquery%2Cmediawiki&only=scripts&skin=vector&version=20150114T203203Z:170:449
@https://www.mediawiki.org/wiki/Topic:S6q53exrf5ir908w:1003:1
 Arguments { 0: "topicTitle", 1: Object, 2 more… }

Details

	Subject	Repo	Branch	Lines +/-
	Fix TOC error caused by there being no TOC on Topic pages	mediawiki/extensions/Flow	master	+15 -8

Customize query in gerrit

Related Objects

Mentioned In: rMEXTd17fd0c13c88: Updated mediawiki/extensions Project: mediawiki/extensions/Flow…
rEFLW999b895631cc: Fix TOC error caused by there being no TOC on Topic pages

Event Timeline

Quiddity created this task.Jan 20 2015, 11:28 PM

Quiddity raised the priority of this task from to Unbreak Now!.

Quiddity updated the task description. (Show Details)

Quiddity added a project: StructuredDiscussions.

Quiddity subscribed.

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJan 20 2015, 11:28 PM

Quiddity updated the task description. (Show Details)Jan 20 2015, 11:29 PM

Quiddity set Security to None.

@Quiddity: are you still seeing that? I don't see it on either of the links.

Liuxinyu970226 subscribed.Jan 26 2015, 10:00 AM

I can still reproduce it.

• Mattflaschen-WMF claimed this task.Feb 9 2015, 6:57 PM

I can reproduce this in chrome against the linked mw.org page. This is basically happening because the topic load handler is trying to add the topic to the toc, but that toc was never initialized. We will fix this, but its not an 'unbreak now' as this shouldn't effect any user visible features, just spams their (typically unseen) console a little bit.

In flow-board-toc.js the processTemplateGetFragment method is called with this.tocTemplate as the template to render, but that variable was never initialized as there is no TOC on topic pages.

• Mattflaschen-WMF moved this task from Sprint P - ends Feb 11 to In Development on the Collaboration-Team-Sprint-P-2015-02-11/q3 board.Feb 10 2015, 6:39 PM

• Mattflaschen-WMF edited projects, added Collaboration-Team-Sprint-Q-2015-02-25; removed Collaboration-Team-Sprint-P-2015-02-11/q3.Feb 11 2015, 10:30 PM

Change 190612 had a related patch set uploaded (by Mattflaschen):
Fix TOC error caused by there being no TOC on Topic pages

https://gerrit.wikimedia.org/r/190612

Patch-For-Review

The reason it was a pain to reproduce (and probably the reason the bug made it to master) is due to the weird behavior of mw.flow.debug.

In https://gerrit.wikimedia.org/r/190606 (pending review), I've made it just log for everyone (even anons). This will not break the page, and will help us find bugs earlier.

• Mattflaschen-WMF moved this task from Sprint Q - ends Feb 25 to Code Review on the Collaboration-Team-Sprint-Q-2015-02-25 board.Feb 14 2015, 12:35 AM

EBernhardson moved this task from Code Review to Product Review on the Collaboration-Team-Sprint-Q-2015-02-25 board.Feb 17 2015, 11:42 PM

Change 190612 merged by jenkins-bot:
Fix TOC error caused by there being no TOC on Topic pages

https://gerrit.wikimedia.org/r/190612

• Mattflaschen-WMF mentioned this in rEFLW999b895631cc: Fix TOC error caused by there being no TOC on Topic pages.Feb 17 2015, 11:43 PM

• DannyH closed this task as Resolved.Feb 18 2015, 12:01 AM

• DannyH subscribed.

Liuxinyu970226 unsubscribed.Feb 18 2015, 2:13 AM

Diffusion mentioned this in rMEXTd17fd0c13c88: Updated mediawiki/extensions Project: mediawiki/extensions/Flow….Mar 11 2015, 6:26 AM