Page MenuHomePhabricator
Create Task
Maniphest T88248

Don't request image resizes from the API if we already have a larger image in the cache
Closed, ResolvedPublic1 Estimated Story Points
Actions

Description

Image resizing in the browser is pretty good these days so if we have a large image there's no need to fetch a smaller one from the API. For images which are originally tens of megapixels this places a large strain on the servers.

Details

SubjectRepoBranchLines +/-
Only re-render if the images is larger than the last renderingmediawiki/extensions/VisualEditormaster+20 -6
Customize query in gerrit

Related Objects

Event Timeline

Esanders created this task.Feb 1 2015, 8:28 PM
Esanders raised the priority of this task from to Needs Triage.
Esanders updated the task description. (Show Details)
Esanders added projects: VisualEditor, VisualEditor-MediaWiki-Media.
Esanders subscribed.
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptFeb 1 2015, 8:28 PM
gerritbot added a project: Patch-For-Review.Feb 1 2015, 9:10 PM
gerritbot subscribed.

Change 187967 had a related patch set uploaded (by Esanders):
Only re-render if the images is larger than the last rendering

https://gerrit.wikimedia.org/r/187967

Patch-For-Review

Jdforrester-WMF assigned this task to Esanders.Feb 2 2015, 3:49 AM
Jdforrester-WMF moved this task from To Triage to Blocked on the VisualEditor board.
Jdforrester-WMF added projects: Performance Issue, VisualEditor-Performance, WMF-deploy-2015-02-04_(1.25wmf16).
Jdforrester-WMF set Security to None.
Jdforrester-WMF triaged this task as Medium priority.Feb 2 2015, 3:59 AM
gerritbot added a comment.Feb 2 2015, 7:04 PM

Change 187967 merged by jenkins-bot:
Only re-render if the images is larger than the last rendering

https://gerrit.wikimedia.org/r/187967

Jdforrester-WMF moved this task from Blocked to FY 18-19 Q3/Q4 on the VisualEditor board.Feb 2 2015, 7:07 PM
Esanders mentioned this in rEVEDf4bb7de786fb: Only re-render if the images is larger than the last rendering.Feb 2 2015, 7:09 PM
Jdforrester-WMF closed this task as Resolved.Feb 2 2015, 10:03 PM
Jdforrester-WMF removed a project: Patch-For-Review.
ori moved this task from Backlog to Done on the VisualEditor-Performance board.Feb 19 2015, 2:29 AM
Jdforrester-WMF added a project: VisualEditor 2014/15 Q3 blockers.Mar 9 2015, 6:04 PM
Jdforrester-WMF edited a custom field.Mar 9 2015, 6:08 PM
Jdforrester-WMF moved this task from Nominated to Done on the VisualEditor 2014/15 Q3 blockers board.Mar 9 2015, 6:13 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL