Page MenuHomePhabricator

Copy and pasting complex templates between instances results in blank renderings and non-template garbage
Closed, ResolvedPublic8 Estimated Story Points

Description

When we copy DM HTML to the clipboard we mark the first child as not having a valid rendering, so when it is pasted to another VE instance the rendering is recomputed, and we mark the rendering we do provide as ignorable (because we don't trust it not to get screwed by the browser). One or both of these are skipped if the converter is using originalDomElements, so unmodified templates from Parsoid don't copy very well.

Event Timeline

Esanders claimed this task.
Esanders raised the priority of this task from to Needs Triage.
Esanders updated the task description. (Show Details)
Esanders added a project: VisualEditor.
Esanders added a subscriber: Esanders.
gerritbot added a subscriber: gerritbot.

Change 190814 had a related patch set uploaded (by Esanders):
Correctly tag clipboard DM from MWTransclusionNodes

https://gerrit.wikimedia.org/r/190814

Patch-For-Review

Change 190814 merged by jenkins-bot:
Correctly tag clipboard DM from MWTransclusionNodes

https://gerrit.wikimedia.org/r/190814

Jdforrester-WMF triaged this task as High priority.
Jdforrester-WMF moved this task from To Triage to Q4 on the VisualEditor board.
Jdforrester-WMF set Security to None.