Currently when LP fails (for no matter what reason), the spinner is removed, but there is no feedback given to the user.
Instead we should show an error, and ask the user to try again or something similar.
Description
Description
Details
Details
| Status | Subtype | Assigned | Task | ||
|---|---|---|---|---|---|
| Open | None | T41272 Bugs in "Live preview" feature (tracking) | |||
| Resolved | TheDJ | T90490 LivePreview should give feedback when failing |
Event Timeline
Comment Actions
Change 193578 had a related patch set uploaded (by TheDJ):
LivePreview: Notifiy user about errors
Comment Actions
Jmm, i was a bit in doubt how far I should go with this. It also doesn't seem we have much of an established flow for this.
Initially I figured mw.notify would be just fine, but now I'm wondering. Perhaps connection issues are much more common, and a 'load on demand' mw.notify doesn't help you too much in that case...
- Hard depend on mw.notification ?
- Use .errorbox class and just write html into the page ?
- Disable livepreview, and submit again the traditional way ?
Comment Actions
I've chosen to go with errorbox. it seemed the most simple solution, that would work the most reliable.
Comment Actions
Change 199792 had a related patch set uploaded (by TheDJ):
LivePreview: Let's not potentially mangle #wikiPreview
Comment Actions
Change 199792 merged by jenkins-bot:
LivePreview: Let's not potentially mangle #wikiPreview