Maniphest T92039

webservice2 failing to start Python web services with xml.etree.ElementTree.ParseError
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	• Mattflaschen-WMF
	Mar 9 2015, 10:55 PM

Description

My Python web API (https://tools.wmflabs.org/phabricator-bug-status/queryTasks) stopped working for unclear reasons.

When I try:

tools.phabricator-bug-status@tools-trusty:~$ webservice2 uwsgi-python restart

I get:

Traceback (most recent call last):
  File "/usr/local/bin/webservice2", line 150, in <module>
    job_id = get_job_id(queue_name, job_name)
  File "/usr/local/bin/webservice2", line 103, in get_job_id
    return xpath_string(output, './/JB_job_number')
  File "/usr/local/bin/webservice2", line 85, in xpath_string
    xml = ET.fromstring(string)
  File "/usr/lib/python2.7/xml/etree/ElementTree.py", line 1300, in XML
    parser.feed(text)
  File "/usr/lib/python2.7/xml/etree/ElementTree.py", line 1642, in feed
    self._raiseerror(v)
  File "/usr/lib/python2.7/xml/etree/ElementTree.py", line 1506, in _raiseerror
    raise err
xml.etree.ElementTree.ParseError: not well-formed (invalid token): line 97, column 16

It looks like ET.fromstring is failing in /usr/local/bin/webservice2, probably because qstat_xml is not returning valid XML.

Details

	Subject	Repo	Branch	Lines +/-
	Tools: Fix XML output of qstat for webservice2	operations/puppet	production	+4 -0

Customize query in gerrit

Related Objects

Mentioned In: rOPUP333abb83f2ca: Tools: Fix XML output of qstat for webservice2

Event Timeline

• Mattflaschen-WMF created this task.Mar 9 2015, 10:55 PM

• Mattflaschen-WMF raised the priority of this task from to Needs Triage.

• Mattflaschen-WMF updated the task description. (Show Details)

• Mattflaschen-WMF added a project: Toolforge.

• Mattflaschen-WMF subscribed.

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMar 9 2015, 10:55 PM

Betacommand subscribed.Mar 9 2015, 11:32 PM

Technical13 subscribed.Mar 10 2015, 1:23 AM

You're right, qstat_xml() does not return valid XML :-). In labs/toollabs's www/content/status.php, we worked around that with sed. I just tested doing that in Python and'll upload the patch soon. As part of testing, I restarted the webservice:

tools.phabricator-bug-status@tools-login:~$ /tmp/webservice2 uwsgi-python start
Your webservice is already running
tools.phabricator-bug-status@tools-login:~$ qstat
job-ID  prior   name       user         state submit/start at     queue                          slots ja-task-ID 
-----------------------------------------------------------------------------------------------------------------
8557644 0.31114 uwsgi-pyth tools.phabri r     03/02/2015 07:52:28 webgrid-generic@tools-webgrid-     1        
tools.phabricator-bug-status@tools-login:~$ /tmp/webservice2 uwsgi-python restart
Restarting
tools.phabricator-bug-status@tools-login:~$ qstat
job-ID  prior   name       user         state submit/start at     queue                          slots ja-task-ID 
-----------------------------------------------------------------------------------------------------------------
8816144 0.30000 uwsgi-pyth tools.phabri r     03/10/2015 13:49:07 webgrid-generic@tools-webgrid-     1        
tools.phabricator-bug-status@tools-login:~$

So if something's broken in the interim, please scream loudly :-).

Change 195556 had a related patch set uploaded (by Tim Landscheidt):
Tools: Fix XML output of qstat for webservice2

https://gerrit.wikimedia.org/r/195556

gerritbot added a project: Patch-For-Review.Mar 10 2015, 2:08 PM

Change 195556 merged by Yuvipanda:
Tools: Fix XML output of qstat for webservice2

https://gerrit.wikimedia.org/r/195556

yuvipanda mentioned this in rOPUP333abb83f2ca: Tools: Fix XML output of qstat for webservice2.Mar 10 2015, 5:46 PM

Seems to work - I tested on a couple of services :)

!close

yuvipanda closed this task as Resolved.Mar 10 2015, 5:56 PM

yuvipanda claimed this task.

yuvipanda reassigned this task from yuvipanda to scfc.

yuvipanda set Security to None.

Ricordisamoa removed a project: Patch-For-Review.Mar 30 2015, 5:46 PM

Ricordisamoa subscribed.

• Elitre subscribed.Apr 16 2015, 8:50 PM

• Phabricator_maintenance removed a subscriber: yuvipanda.Jun 7 2017, 6:53 PM

Restricted Application added a project: Cloud-Services. · View Herald TranscriptJun 7 2017, 6:53 PM

webservice2 failing to start Python web services with xml.etree.ElementTree.ParseErrorClosed, ResolvedPublicActions

Description

Details

Related Objects

Event Timeline

webservice2 failing to start Python web services with xml.etree.ElementTree.ParseError
Closed, ResolvedPublic
Actions