Maniphest T92583

Audit and fix events bound to CE nodes but not unbound when destroy() is called
Closed, ResolvedPublic1 Estimated Story Points
Actions

Assigned To

• TrevorParscal

Authored By

	• TrevorParscal
	Mar 12 2015, 11:31 PM

Tags

Referenced Files

None

Subscribers

• TrevorParscal

Description

Lingering events have already caused T92427: [Regression wmf20] Internal links, when clicked in a Reference context menu does nothing. and may also be affecting performance by introducing memory leaks.

Related Objects

Mentioned In: rEVED5cbd04ac3e09: Stringify and parse rendered references
T92572: Nonfunctional slugs appear in reference context item
Mentioned Here: T92572: Nonfunctional slugs appear in reference context item
T92427: [Regression wmf20] Internal links, when clicked in a Reference context menu does nothing.

Event Timeline

• TrevorParscal created this task.Mar 12 2015, 11:31 PM

• TrevorParscal assigned this task to Catrope.

• TrevorParscal raised the priority of this task from to Needs Triage.

• TrevorParscal updated the task description. (Show Details)

• TrevorParscal added projects: VisualEditor-ContentEditable, VisualEditor 2014/15 Q3 blockers.

• TrevorParscal subscribed.

Restricted Application added a project: VisualEditor. · View Herald TranscriptMar 12 2015, 11:31 PM

Restricted Application added a subscriber: Aklapper. · View Herald Transcript

Jdforrester-WMF triaged this task as High priority.Mar 12 2015, 11:42 PM

Jdforrester-WMF added a project: Technical-Debt.

Jdforrester-WMF set Security to None.

Jdforrester-WMF edited a custom field.

Catrope mentioned this in T92572: Nonfunctional slugs appear in reference context item.Mar 13 2015, 11:49 AM

Jdforrester-WMF mentioned this in rEVED5cbd04ac3e09: Stringify and parse rendered references.Mar 13 2015, 11:49 AM

Hmm, maybe we could use the DM rendering rather than the CE rendering for context item previews? That would also avoid T92572.

Ricordisamoa subscribed.Mar 13 2015, 4:41 PM

Jdforrester-WMF moved this task from To Triage to Bug Fixes on the VisualEditor board.Mar 18 2015, 2:04 AM

Jdforrester-WMF moved this task from Nominated to Polish on the VisualEditor 2014/15 Q3 blockers board.Mar 18 2015, 11:19 PM

• TrevorParscal claimed this task.Mar 27 2015, 5:35 PM

Resolved in patch https://gerrit.wikimedia.org/r/#/c/197797/

• TrevorParscal moved this task from Polish to Done on the VisualEditor 2014/15 Q3 blockers board.Mar 27 2015, 6:13 PM

Jdforrester-WMF moved this task from Bug Fixes to FY 18-19 Q3/Q4 on the VisualEditor board.Mar 29 2015, 10:47 PM