Page MenuHomePhabricator

Audit and fix events bound to CE nodes but not unbound when destroy() is called
Closed, ResolvedPublic1 Estimated Story Points

Description

Lingering events have already caused T92427: [Regression wmf20] Internal links, when clicked in a Reference context menu does nothing. and may also be affecting performance by introducing memory leaks.

Event Timeline

TrevorParscal assigned this task to Catrope.
TrevorParscal raised the priority of this task from to Needs Triage.
TrevorParscal updated the task description. (Show Details)
Restricted Application added a project: VisualEditor. · View Herald TranscriptMar 12 2015, 11:31 PM
Restricted Application added a subscriber: Aklapper. · View Herald Transcript
Jdforrester-WMF triaged this task as High priority.Mar 12 2015, 11:42 PM
Jdforrester-WMF set Security to None.
Jdforrester-WMF edited a custom field.

Hmm, maybe we could use the DM rendering rather than the CE rendering for context item previews? That would also avoid T92572.

Jdforrester-WMF moved this task from Bug Fixes to Q4 on the VisualEditor board.Mar 29 2015, 10:47 PM