Page MenuHomePhabricator

Table border parameter does not display right border on mobile
Closed, ResolvedPublic

Description

Hi,

I've noticed a problem with the border= parameter for tables. When this parameter is included it will create a black outside border around the table in question on the mobile version of the site. However this border is always absent on the right, no matter what table you use it for.

Here is a screenshot to demonstrate this issue:

Event Timeline

Tvx1 created this task.Mar 16 2015, 11:23 PM
Tvx1 raised the priority of this task from to Normal.
Tvx1 updated the task description. (Show Details)
Tvx1 added a subscriber: Tvx1.
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMar 16 2015, 11:23 PM
Krenair added a subscriber: Krenair.
Tvx1 updated the task description. (Show Details)Mar 16 2015, 11:25 PM
Tvx1 set Security to None.

Please provide a link to where the problem can be seen. Also (probably unrelated in this case though), browser information always welcome :)

Tvx1 added a comment.Mar 17 2015, 12:58 PM

Here is a link where you can see the problem:

[https://en.m.wikipedia.org/wiki/2014_Formula_One_season#Teams_and_drivers]

I generally use Safari as mobile browser, but through discussion with fellow editors I have found out that it is the same in any mobile browser.

Aklapper renamed this task from Bug with border parameter for tables to Table border parameter does not display right border on mobile.Mar 17 2015, 2:24 PM
Aklapper lowered the priority of this task from Normal to Lowest.
Tvx1 raised the priority of this task from Lowest to Normal.Mar 19 2015, 11:11 PM

Change 199780 had a related patch set uploaded (by Bmansurov):
Fix table borders

https://gerrit.wikimedia.org/r/199780

bmansurov moved this task from 2015-16 Q4 to Needs Prioritization on the Readers-Web-Backlog board.
kaldari claimed this task.Mar 26 2015, 10:25 PM
kaldari added a subscriber: bmansurov.
Jdlrobson closed this task as Resolved.Apr 7 2015, 12:10 AM
Jdlrobson added a subscriber: Jdlrobson.

Change 199780 merged by jenkins-bot:
Fix wikitable table borders

https://gerrit.wikimedia.org/r/199780

Tvx1 reopened this task as Open.Apr 7 2015, 3:10 PM

This is not resolved. If you take a look at the tables that use the border= paramater in this link: [https://en.m.wikipedia.org/wiki/2014_Formula_One_season#Teams_and_drivers], you'll notice that the outside border on the right is still missing.

Jdlrobson closed this task as Resolved.Apr 7 2015, 3:58 PM

@Tvx1 the patch has not been deployed yet (it will go out when the site is next updated (this doesn't happen instantaneous) you can however verify this is fixed on our test cluster @http://en.m.wikipedia.beta.wmflabs.org/

Please only reopen if the issue is still present there.

Tvx1 added a comment.EditedApr 7 2015, 4:31 PM

@Jdlrobson I'm not able to test it on the test cluster, because the border= parameter doesn't seem to work there at all.

@Tvx1 I assume this is the page you are testing on:
https://en.m.wikipedia.org/wiki/2015_Formula_One_season
?
If so I have imported the page to the test cluster http://en.wikipedia.beta.wmflabs.org/wiki/2015_Formula_One_season

I don't see the black border on enwiki or betalabs- are you sure you don't have a gadget or something else adding that border?

Tvx1 added a comment.EditedApr 7 2015, 9:11 PM

@Jdlrobson No that's no the page I was testing on. It's http://en.m.wikipedia.org/wiki/2014_Formula_One_season#Teams_and_drivers. That page has some wikitables that use the border= parameter. Note that it is a mobile link. It's only the mobile version that creates this black outside border through that parameter. But the parameter does not seem to have any affect in the test cluster.

Tvx1 added a comment.EditedApr 11 2015, 2:50 PM

@bmansurov. Well no. Even though that is the correct page, like I said before the border= parameter does not seem to work on the test cluster. Therefore we don't get a black outside border at all in the test cluster's tables and I cannot check whether te bug has been successfully fixed. There seem to be other differences between the layout of the mobile wikitable on the test cluster and the main site as well.