| Tvx1 | |
| Mar 16 2015, 11:23 PM |
| F95614: Schermafbeelding_2015-03-16_om_21.56.54.png | |
| Mar 16 2015, 11:23 PM |
Hi,
I've noticed a problem with the border= parameter for tables. When this parameter is included it will create a black outside border around the table in question on the mobile version of the site. However this border is always absent on the right, no matter what table you use it for.
Here is a screenshot to demonstrate this issue:
| Subject | Repo | Branch | Lines +/- | |
|---|---|---|---|---|
| Fix wikitable table borders | mediawiki/extensions/MobileFrontend | master | +9 -17 |
Please provide a link to where the problem can be seen. Also (probably unrelated in this case though), browser information always welcome :)
Here is a link where you can see the problem:
[https://en.m.wikipedia.org/wiki/2014_Formula_One_season#Teams_and_drivers]
I generally use Safari as mobile browser, but through discussion with fellow editors I have found out that it is the same in any mobile browser.
This is not resolved. If you take a look at the tables that use the border= paramater in this link: [https://en.m.wikipedia.org/wiki/2014_Formula_One_season#Teams_and_drivers], you'll notice that the outside border on the right is still missing.
@Tvx1 the patch has not been deployed yet (it will go out when the site is next updated (this doesn't happen instantaneous) you can however verify this is fixed on our test cluster @http://en.m.wikipedia.beta.wmflabs.org/
Please only reopen if the issue is still present there.
@Jdlrobson I'm not able to test it on the test cluster, because the border= parameter doesn't seem to work there at all.
@Tvx1 I assume this is the page you are testing on:
https://en.m.wikipedia.org/wiki/2015_Formula_One_season
?
If so I have imported the page to the test cluster http://en.wikipedia.beta.wmflabs.org/wiki/2015_Formula_One_season
I don't see the black border on enwiki or betalabs- are you sure you don't have a gadget or something else adding that border?
@Jdlrobson No that's no the page I was testing on. It's http://en.m.wikipedia.org/wiki/2014_Formula_One_season#Teams_and_drivers. That page has some wikitables that use the border= parameter. Note that it is a mobile link. It's only the mobile version that creates this black outside border through that parameter. But the parameter does not seem to have any affect in the test cluster.
@Tvx1, you can see the same page at http://en.m.wikipedia.beta.wmflabs.org/wiki/2014_Formula_One_season where the issue is fixed.
@bmansurov. Well no. Even though that is the correct page, like I said before the border= parameter does not seem to work on the test cluster. Therefore we don't get a black outside border at all in the test cluster's tables and I cannot check whether te bug has been successfully fixed. There seem to be other differences between the layout of the mobile wikitable on the test cluster and the main site as well.