Page MenuHomePhabricator
Create Task
Maniphest T93101

(!!!) Ability to edit collection is broken
Closed, ResolvedPublic
Actions

Description

Visit one of your collections http://en.m.wikipedia.beta.wmflabs.org/wiki/Special:Gather/Jdlrobson/14
click edit

Uncaught TypeError: Cannot read property 'length' of null

Please add tests when fixing! :)

Details

SubjectRepoBranchLines +/-
QA: Add edit collection browser testsmediawiki/extensions/Gathermaster+34 -0
Reduce API requests on any given non-special page to 1mediawiki/extensions/Gathermaster+45 -10
Customize query in gerrit

Related Objects

Event Timeline

Jdlrobson created this task.Mar 18 2015, 5:15 PM
Jdlrobson raised the priority of this task from to Needs Triage.
Jdlrobson updated the task description. (Show Details)
Jdlrobson added projects: Gather Sprint Diplodocus, Gather.
Jdlrobson moved this task to In Analysis on the Gather Sprint Diplodocus board.
Jdlrobson subscribed.
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMar 18 2015, 5:15 PM
Jdlrobson moved this task from In Analysis to Ready for dev on the Gather Sprint Diplodocus board.Mar 18 2015, 5:15 PM
Jdlrobson claimed this task.Mar 18 2015, 6:19 PM
Jdlrobson moved this task from Ready for dev to In development on the Gather Sprint Diplodocus board.
gerritbot subscribed.Mar 18 2015, 6:25 PM

Change 197222 had a related patch set uploaded (by Jdlrobson):
Reduce API requests on any given non-special page to 1

https://gerrit.wikimedia.org/r/197222

gerritbot added a project: Patch-For-Review.Mar 18 2015, 6:25 PM
Jdlrobson moved this task from In development to Code review needed on the Gather Sprint Diplodocus board.Mar 18 2015, 7:52 PM
gerritbot added a comment.Mar 18 2015, 7:54 PM

Change 197722 had a related patch set uploaded (by Jdlrobson):
QA: Add edit collection browser tests

https://gerrit.wikimedia.org/r/197722

gerritbot added a comment.Mar 18 2015, 11:47 PM

Change 197222 merged by jenkins-bot:
Reduce API requests on any given non-special page to 1

https://gerrit.wikimedia.org/r/197222

Jdlrobson closed this task as Resolved.Mar 19 2015, 12:07 AM
Jdlrobson moved this task from Code review needed to Ready for signoff on the Gather Sprint Diplodocus board.
Jdlrobson moved this task from Ready for signoff to Code review needed on the Gather Sprint Diplodocus board.Mar 19 2015, 12:28 AM

Please someeone review the browser tests at https://gerrit.wikimedia.org/r/197722

gerritbot added a comment.Mar 19 2015, 12:14 PM

Change 197722 merged by jenkins-bot:
QA: Add edit collection browser tests

https://gerrit.wikimedia.org/r/197722

• Jhernandez moved this task from Code review needed to Ready for signoff on the Gather Sprint Diplodocus board.Mar 19 2015, 12:17 PM
Diffusion mentioned this in rMEXT44c95b669ac5: Updated mediawiki/extensions Project: mediawiki/extensions/Gather….Mar 23 2015, 3:55 PM
Jdlrobson mentioned this in rMEXTd4e6a26318f4: Updated mediawiki/extensions Project: mediawiki/extensions/Gather….Mar 23 2015, 3:55 PM
• JKatzWMF moved this task from Ready for signoff to Done on the Gather Sprint Diplodocus board.Mar 23 2015, 6:20 PM
Jdlrobson mentioned this in rEGAT1f22bdb47ac6: Reduce API requests on any given non-special page to 1.Apr 8 2015, 6:17 PM
Jdlrobson mentioned this in rEGATbd04ba15429a: QA: Add edit collection browser tests.
• JKatzWMF moved this task from Needs triage to In sprint on the Gather board.Apr 11 2015, 12:07 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL