Cosmetic changes is adding unnecessary newline at end
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	XZise
	Mar 25 2015, 5:39 PM

Description

At the end of the text the cosmetic changes script is adding unnecessary newlines:

python pwb.py cosmetic_changes.py -ns:0 -family:wiktionary -lang:cs -start:\! -summary:"cc" -simulate

ATTENTION: You can run this script as a stand-alone for testing purposes.
However, the changes that are made are only minor, and other users
might get angry if you fill the version histories and watchlists with such
irrelevant changes. Some wikis prohibit stand-alone running.
Do you really want to continue? ([y]es, [N]o) y
Retrieving 50 pages from wiktionary:cs.


>>> ! <<<
@@ -39 +39 @@
- [[th:!]]
+ [[th:!]]

Comment: cc
Do you want to accept these changes? ([y]es, [N]o, [a]ll, [q]uit)

It seems that textlib.replaceLanguageLinks is causing this so maybe it's not a cosmetic changes related problem but more general.

Revisions and Commits

rPWBC pywikibot
	rPWBC097245e7e347 Changes are wrongly detected in the last langlink

Related Objects

Mentioned Here: T184886: Fix the DeprecationWarning in TestDryCosmeticChanges#test_standardizePageFooter
rPWBC097245e7e347: Changes are wrongly detected in the last langlink

Event Timeline

XZise created this task.Mar 25 2015, 5:39 PM

XZise raised the priority of this task from to Needs Triage.

XZise updated the task description. (Show Details)

XZise added projects: Pywikibot, Pywikibot-cosmetic-changes.py.

XZise subscribed.

Restricted Application added subscribers: Aklapper, Unknown Object (MLST). · View Herald TranscriptMar 25 2015, 5:39 PM

JAnD subscribed.Mar 25 2015, 10:03 PM

The bug was fixed by 097245e7e3 . now it is a warning:

$ python pwb.py cosmetic_changes.py -ns:0 -family:wiktionary -lang:cs -page:'!' -summary:"cc" -simulate
ATTENTION: You can run this script as a stand-alone for testing purposes.
However, the changes that are made are only minor, and other users
might get angry if you fill the version histories and watchlists with such
irrelevant changes. Some wikis prohibit stand-alone running.
Do you really want to continue? ([y]es, [N]o): y
Retrieving 1 pages from wiktionary:cs.


>>> ! <<<
WARNING: /home/jayvdb/projects/pywiki/core/pywikibot/textlib.py:1180: DeprecationWarning: Using unstripped text is deprecated; use stripped text instead.
  addOnly=True)

No changes were needed on [[!]]

1 pages read
0 pages written
Execution time: 15 seconds
Read operation time: 15 seconds
Script terminated successfully.

jayvdb added a commit: rPWBC097245e7e347: Changes are wrongly detected in the last langlink.Oct 16 2015, 4:39 AM

In T93915#1730029, @jayvdb wrote: