A patch to ConfirmEdit was merged today as part of addressing T92357 that is now preventing Flow code from merging. The actual test failure is simply that we pass a mocked IContextSource in which does not respond to getRequest(), but the underlying bug is that the content of the previous revision is not available to ConfirmEdit.
- Mentioned In
- rEFLWfa9220f74c6f: Provide ConfirmEdit with the previous revision content
rMEXT8031dbeedc2d: Updated mediawiki/extensions Project: mediawiki/extensions/Flow…
rMEXTf2bec4fe8aba: Updated mediawiki/extensions Project: mediawiki/extensions/Flow…
rEFLW9ac8548504a5: Override $wgFlowContentFormat to wikitext if there is no Parsoid URL
T94025: Make tests pass with wikitext storage
rMEXTb7ace8ad3715: Updated mediawiki/extensions Project: mediawiki/extensions/ConfirmEdit…
rECOEf02b2c2c97a8: Allow previous revision text to be explicitly provided
- Mentioned Here
- T94025: Make tests pass with wikitext storage
T92357: Fix problematic database master queries performed on HTTP GET/HEAD
Adding into current sprint. Failing tests prevent us from being able to (safely) merge patches.
It looks like we may have to change unittest storage format to wikitext (instead of html) to get this working again.
Tests haven't recently been run for wikitext storage, so that'll introduce a couple of new blockers. I've created T94025 for that.