Page MenuHomePhabricator
Create Task
Maniphest T93956

Flow's ConfirmEdit integration no longer passes unit tests
Closed, ResolvedPublic
Actions

Description

A patch to ConfirmEdit was merged today as part of addressing T92357 that is now preventing Flow code from merging. The actual test failure is simply that we pass a mocked IContextSource in which does not respond to getRequest(), but the underlying bug is that the content of the previous revision is not available to ConfirmEdit.

Details

SubjectRepoBranchLines +/-
Provide ConfirmEdit with the previous revision contentmediawiki/extensions/Flowmaster+3 -2
Override $wgFlowContentFormat to wikitext if there is no Parsoid URLmediawiki/extensions/Flowmaster+9 -0
Allow previous revision text to be explicitly providedmediawiki/extensions/ConfirmEditmaster+10 -6
Customize query in gerrit

Related Objects

Event Timeline

EBernhardson created this task.Mar 25 2015, 10:24 PM
EBernhardson raised the priority of this task from to Needs Triage.
EBernhardson updated the task description. (Show Details)
EBernhardson subscribed.
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMar 25 2015, 10:24 PM
EBernhardson added a project: Collaboration-Team-Triage.Mar 25 2015, 10:24 PM
EBernhardson set Security to None.
gerritbot subscribed.Mar 25 2015, 10:42 PM

Change 199760 had a related patch set uploaded (by EBernhardson):
Allow previous revision text to be explicitly provided

https://gerrit.wikimedia.org/r/199760

gerritbot added a project: Patch-For-Review.Mar 25 2015, 10:42 PM

Change 199762 had a related patch set uploaded (by EBernhardson):
Provide ConfirmEdit with the previous revision content

https://gerrit.wikimedia.org/r/199762

gerritbot added a comment.Mar 25 2015, 11:39 PM

Change 199760 merged by jenkins-bot:
Allow previous revision text to be explicitly provided

https://gerrit.wikimedia.org/r/199760

EBernhardson mentioned this in rECOEf02b2c2c97a8: Allow previous revision text to be explicitly provided.Mar 25 2015, 11:40 PM
EBernhardson mentioned this in rMEXTb7ace8ad3715: Updated mediawiki/extensions Project: mediawiki/extensions/ConfirmEdit….
matthiasmullie added a project: Collaboration-Team-Sprint-T-2015-04-08.Mar 26 2015, 1:50 PM
matthiasmullie mentioned this in T94025: Make tests pass with wikitext storage.Mar 26 2015, 1:56 PM
matthiasmullie subscribed.Mar 26 2015, 2:17 PM

Adding into current sprint. Failing tests prevent us from being able to (safely) merge patches.

It looks like we may have to change unittest storage format to wikitext (instead of html) to get this working again.
Tests haven't recently been run for wikitext storage, so that'll introduce a couple of new blockers. I've created T94025 for that.

matthiasmullie moved this task from Sprint T - ends April 8 to Needs Code Review on the Collaboration-Team-Sprint-T-2015-04-08 board.Mar 26 2015, 2:18 PM
• DannyH triaged this task as Unbreak Now! priority.Mar 26 2015, 5:40 PM
• DannyH subscribed.
• Mattflaschen-WMF subscribed.Mar 26 2015, 6:06 PM
In T93956#1152990, @matthiasmullie wrote:

Adding into current sprint. Failing tests prevent us from being able to (safely) merge patches.

It looks like we may have to change unittest storage format to wikitext (instead of html) to get this working again.

Yes, I did this in https://gerrit.wikimedia.org/r/#/c/199818/ (still under discussion).

EBernhardson claimed this task.Mar 26 2015, 6:37 PM
gerritbot added a comment.Mar 26 2015, 7:23 PM

Change 199976 had a related patch set uploaded (by Mattflaschen):
Override $wgFlowContentFormat to wikitext if there is no Parsoid URL

https://gerrit.wikimedia.org/r/199976

gerritbot added a comment.Mar 26 2015, 7:28 PM

Change 199976 merged by Legoktm:
Override $wgFlowContentFormat to wikitext if there is no Parsoid URL

https://gerrit.wikimedia.org/r/199976

• Mattflaschen-WMF mentioned this in rEFLW9ac8548504a5: Override $wgFlowContentFormat to wikitext if there is no Parsoid URL.Mar 26 2015, 7:28 PM
• Mattflaschen-WMF mentioned this in rMEXTf2bec4fe8aba: Updated mediawiki/extensions Project: mediawiki/extensions/Flow….
gerritbot added a comment.Mar 26 2015, 7:37 PM

Change 199762 merged by jenkins-bot:
Provide ConfirmEdit with the previous revision content

https://gerrit.wikimedia.org/r/199762

EBernhardson mentioned this in rMEXT8031dbeedc2d: Updated mediawiki/extensions Project: mediawiki/extensions/Flow….Mar 26 2015, 7:37 PM
• Mattflaschen-WMF mentioned this in rEFLWfa9220f74c6f: Provide ConfirmEdit with the previous revision content.Mar 26 2015, 7:38 PM
• Mattflaschen-WMF closed this task as Resolved.Mar 26 2015, 7:42 PM
• Mattflaschen-WMF moved this task from Needs Code Review to Done on the Collaboration-Team-Sprint-T-2015-04-08 board.
• DannyH moved this task from Untriaged to Resolved on the Collaboration-Team-Triage board.Apr 1 2015, 7:29 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits