Page MenuHomePhabricator

Flow's ConfirmEdit integration no longer passes unit tests
Closed, ResolvedPublic

Description

A patch to ConfirmEdit was merged today as part of addressing T92357 that is now preventing Flow code from merging. The actual test failure is simply that we pass a mocked IContextSource in which does not respond to getRequest(), but the underlying bug is that the content of the previous revision is not available to ConfirmEdit.

Event Timeline

EBernhardson raised the priority of this task from to Needs Triage.
EBernhardson updated the task description. (Show Details)
EBernhardson added a subscriber: EBernhardson.
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMar 25 2015, 10:24 PM

Change 199760 had a related patch set uploaded (by EBernhardson):
Allow previous revision text to be explicitly provided

https://gerrit.wikimedia.org/r/199760

Change 199762 had a related patch set uploaded (by EBernhardson):
Provide ConfirmEdit with the previous revision content

https://gerrit.wikimedia.org/r/199762

Change 199760 merged by jenkins-bot:
Allow previous revision text to be explicitly provided

https://gerrit.wikimedia.org/r/199760

Adding into current sprint. Failing tests prevent us from being able to (safely) merge patches.

It looks like we may have to change unittest storage format to wikitext (instead of html) to get this working again.
Tests haven't recently been run for wikitext storage, so that'll introduce a couple of new blockers. I've created T94025 for that.

DannyH triaged this task as Unbreak Now! priority.Mar 26 2015, 5:40 PM
DannyH added a subscriber: DannyH.

Adding into current sprint. Failing tests prevent us from being able to (safely) merge patches.
It looks like we may have to change unittest storage format to wikitext (instead of html) to get this working again.

Yes, I did this in https://gerrit.wikimedia.org/r/#/c/199818/ (still under discussion).

Change 199976 had a related patch set uploaded (by Mattflaschen):
Override $wgFlowContentFormat to wikitext if there is no Parsoid URL

https://gerrit.wikimedia.org/r/199976

Change 199976 merged by Legoktm:
Override $wgFlowContentFormat to wikitext if there is no Parsoid URL

https://gerrit.wikimedia.org/r/199976

Change 199762 merged by jenkins-bot:
Provide ConfirmEdit with the previous revision content

https://gerrit.wikimedia.org/r/199762