Page MenuHomePhabricator
Create Task
Maniphest T94178

PMC pages with no results crash citoid
Closed, ResolvedPublic1 Estimated Story Points
Actions

Description

On deploy and master. This is due to Zotero returning 200 ok but with an empty list as a response.

Example bad input: http://www.ncbi.nlm.nih.gov/pmc/articles/PMC999999/

Details

SubjectRepoBranchLines +/-
Fix: Handle case where Zotero gives us empty listmediawiki/services/citoidmaster+15 -3
Customize query in gerrit

Related Objects

Event Timeline

Mvolz created this task.Mar 27 2015, 2:56 PM
Mvolz claimed this task.
Mvolz raised the priority of this task from to Unbreak Now!.
Mvolz updated the task description. (Show Details)
Mvolz added a project: Citoid.
Mvolz moved this task to IO Tasks on the Citoid board.
Mvolz subscribed.
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMar 27 2015, 2:56 PM
gerritbot subscribed.Mar 27 2015, 3:27 PM

Change 200163 had a related patch set uploaded (by Mvolz):
Fix: Handle case where Zotero gives us empty list

https://gerrit.wikimedia.org/r/200163

gerritbot added a project: Patch-For-Review.Mar 27 2015, 3:27 PM
Mvolz added a comment.Mar 27 2015, 10:38 PM

Related zotero ticket:

https://github.com/zotero/translation-server/issues/14#issuecomment-87019273

Mvolz renamed this task from http://www.ncbi.nlm.nih.gov/pmc/articles/PMC999999/ crashes citoid to PMC pages with no results crash citoid.Mar 27 2015, 10:39 PM
Mvolz updated the task description. (Show Details)
Mvolz set Security to None.
gerritbot added a comment.Mar 27 2015, 11:08 PM

Change 200163 merged by Mobrovac:
Fix: Handle case where Zotero gives us empty list

https://gerrit.wikimedia.org/r/200163

Jdforrester-WMF closed this task as Resolved.Mar 27 2015, 11:15 PM
Jdforrester-WMF added a project: WMF-deploy-2015-04-01_(1.25wmf24).
Jdforrester-WMF added a project: VisualEditor 2014/15 Q3 blockers.Mar 29 2015, 11:41 PM
Jdforrester-WMF edited a custom field.Mar 29 2015, 11:47 PM
Jdforrester-WMF moved this task from Nominated to Done on the VisualEditor 2014/15 Q3 blockers board.
Mvolz mentioned this in rGCIT1223d951f58f: Fix: Handle case where Zotero gives us empty list.Apr 8 2015, 4:11 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL