Page MenuHomePhabricator
Create Task
Maniphest T94443

Don't log page-impressions or widget-impressions in WikiGrok
Closed, ResolvedPublic1 Estimated Story Points
Actions

Description

You can leave them in the Schema:MobileWebWikiGrok Schema, but comment out the code that logs those two events.

Details

SubjectRepoBranchLines +/-
Don't log page-impression or widget-impressionmediawiki/extensions/WikiGrokmaster+4 -5
Customize query in gerrit

Related Objects

Event Timeline

• KLans_WMF created this task.Mar 30 2015, 6:15 PM
• KLans_WMF raised the priority of this task from to Needs Triage.
• KLans_WMF updated the task description. (Show Details)
• KLans_WMF added a project: Mobile-Web-Sprint-44-Road-Warrior:-Mad-Max-2.
• KLans_WMF moved this task to To Do on the Mobile-Web-Sprint-44-Road-Warrior:-Mad-Max-2 board.
• KLans_WMF subscribed.
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMar 30 2015, 6:15 PM
• KLans_WMF renamed this task from (1) Don't log page-impressions or widget-impressions in WikiGrok to Don't log page-impressions or widget-impressions in WikiGrok.Mar 30 2015, 6:15 PM
• KLans_WMF set Security to None.
• KLans_WMF edited a custom field.
• bmansurov claimed this task.Mar 30 2015, 8:28 PM
• bmansurov moved this task from To Do to Doing on the Mobile-Web-Sprint-44-Road-Warrior:-Mad-Max-2 board.
gerritbot subscribed.Mar 30 2015, 8:37 PM

Change 200731 had a related patch set uploaded (by Bmansurov):
Don't log page-impression or widget-impression

https://gerrit.wikimedia.org/r/200731

gerritbot added a project: Patch-For-Review.Mar 30 2015, 8:37 PM
• bmansurov moved this task from Doing to Code Review on the Mobile-Web-Sprint-44-Road-Warrior:-Mad-Max-2 board.Mar 30 2015, 8:37 PM
phuedx subscribed.EditedMar 31 2015, 9:31 AM

Why aren't we removing the code that does the logging? I feel like I've asked this before and forgotten the answer.

phuedx added a comment.Mar 31 2015, 9:32 AM

What about the widget-impression-success event?

gerritbot added a comment.Mar 31 2015, 10:49 AM

Change 200731 merged by jenkins-bot:
Don't log page-impression or widget-impression

https://gerrit.wikimedia.org/r/200731

• bmansurov mentioned this in rMEXT499817faee07: Updated mediawiki/extensions Project: mediawiki/extensions/WikiGrok….Mar 31 2015, 10:49 AM
• bmansurov mentioned this in rEWGRce811251faec: Don't log page-impression or widget-impression.
phuedx removed a project: Patch-For-Review.Mar 31 2015, 10:50 AM
phuedx moved this task from Code Review to Needs Analysis on the Mobile-Web-Sprint-44-Road-Warrior:-Mad-Max-2 board.
phuedx added a comment.Mar 31 2015, 10:52 AM

I merged @bmansurov's patch because removing widget-impression-success event logging can be done separately.

• bmansurov added a subscriber: kaldari.Mar 31 2015, 6:41 PM

@phuedx, I think @kaldari maybe able to answer your question about why we're not removing the code. I followed the bug description, which says: comment out the code that logs those two events.

phuedx added a comment.Apr 1 2015, 11:50 AM

@bmansurov: I understand that, which is why I merged your patch. However, "because that's what the task said" isn't the answer I'm looking for ;)

• KLans_WMF added a comment.Apr 1 2015, 5:08 PM

Should this get moved to Ready for Signoff now?

phuedx moved this task from Needs Analysis to Ready for Signoff on the Mobile-Web-Sprint-44-Road-Warrior:-Mad-Max-2 board.Apr 1 2015, 5:11 PM
phuedx added a comment.Apr 1 2015, 5:22 PM

@KLans_WMF: Since this is a technical task, should I sign it off?

• KLans_WMF added a comment.Apr 2 2015, 11:37 PM

@phuedx heck yeah

phuedx moved this task from Ready for Signoff to Done on the Mobile-Web-Sprint-44-Road-Warrior:-Mad-Max-2 board.Apr 3 2015, 9:46 AM
• JKatzWMF closed this task as Resolved.Apr 13 2015, 7:20 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits