Page MenuHomePhabricator
Create Task
Maniphest T94504

MobileWebUIClickTracking main menu event logging can leak into desktop (EventLogging exception on Special:Gather in Vector)
Closed, ResolvedPublic
Actions

Description

Goto https://en.wikipedia.org/wiki/Special:Gather/by/Robmoen/5 and click in the search box

JS on page is broken due to event logging exception:

[MobileWebUIClickTracking] Value null is the wrong type for property "mobileMode" (string expected)
VM537:81 Uncaught TypeError: Cannot read property 'top' of undefined

Details

SubjectRepoBranchLines +/-
Do not load Minerva modules outside Minervamediawiki/extensions/MobileFrontendmaster+44 -24
Customize query in gerrit

Related Objects

Event Timeline

• rmoen created this task.Mar 30 2015, 11:32 PM
• rmoen raised the priority of this task from to Needs Triage.
• rmoen updated the task description. (Show Details)
• rmoen added a project: Gather Sprint Enwiki.
• rmoen subscribed.
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMar 30 2015, 11:32 PM
• rmoen updated the task description. (Show Details)Mar 30 2015, 11:32 PM
• rmoen set Security to None.
• rmoen updated the task description. (Show Details)
Jdlrobson moved this task from In Analysis to Ready for dev on the Gather Sprint Enwiki board.Mar 31 2015, 10:57 PM
Jdlrobson claimed this task.Apr 1 2015, 4:33 PM
Jdlrobson moved this task from Ready for dev to In development on the Gather Sprint Enwiki board.
Jdlrobson renamed this task from EventLogging exception on Special:Gather in Vector to MobileWebUIClickTracking main menu event logging can leak into desktop (EventLogging exception on Special:Gather in Vector).Apr 1 2015, 4:42 PM
Jdlrobson added a project: Web-Team-Backlog.

This will provide some fiddling around in MobileFrontend

Jdlrobson moved this task from In development to Code review needed on the Gather Sprint Enwiki board.Apr 1 2015, 5:11 PM
Jdlrobson moved this task from Code review needed to In development on the Gather Sprint Enwiki board.
• KLans_WMF moved this task from Incoming to 2016-17 Q4 on the Web-Team-Backlog board.Apr 1 2015, 5:11 PM
gerritbot subscribed.Apr 1 2015, 10:07 PM

Change 201364 had a related patch set uploaded (by Jdlrobson):
Do not load Minerva modules outside Minerva

https://gerrit.wikimedia.org/r/201364

gerritbot added a project: Patch-For-Review.Apr 1 2015, 10:07 PM
Jdlrobson moved this task from 2016-17 Q4 to Needs Prioritization on the Web-Team-Backlog board.Apr 1 2015, 10:10 PM
Jdlrobson triaged this task as Medium priority.Apr 1 2015, 10:15 PM

Note this bug is pretty serious for Gather as it stops us rolling this out for desktop users.

Jdlrobson moved this task from In development to Code review needed on the Gather Sprint Enwiki board.Apr 2 2015, 4:50 PM
gerritbot added a comment.Apr 2 2015, 11:03 PM

Change 201364 merged by jenkins-bot:
Do not load Minerva modules outside Minerva

https://gerrit.wikimedia.org/r/201364

Jdlrobson mentioned this in rEMFR78d42f926997: Do not load Minerva modules outside Minerva.Apr 2 2015, 11:04 PM
Diffusion mentioned this in rMEXT330398721721: Updated mediawiki/extensions Project: mediawiki/extensions/MobileFrontend….Apr 2 2015, 11:04 PM
Jdlrobson closed this task as Resolved.Apr 2 2015, 11:11 PM

thanks guys!

• Jhernandez moved this task from Code review needed to Done on the Gather Sprint Enwiki board.Apr 3 2015, 11:52 AM
• Phabricator_maintenance moved this task from Needs Prioritization to 2014-15 Q4 on the Web-Team-Backlog board.Mar 7 2018, 1:33 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL