"[dismiss]" shown on all desktop/mobile pages regardless of the wiki having any sitenotice at the time
Closed, DeclinedPublic

Description

I've noticed past week when browsing Wikipedia on Mobile Safari (en.m.wikipedia.org) and mediawiki.org in Chrome (desktop, OSX), there's a [dismiss] everywhere. Closing it works, but it should not be shown.


See Also: T94374: DismissableSiteNotice's close link is shown even when JavaScript is disabled

Krinkle updated the task description. (Show Details)
Krinkle raised the priority of this task from to High.
Krinkle moved this task to Backlog on the DismissableSiteNotice board.
Krinkle added a subscriber: Krinkle.
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMar 31 2015, 5:51 AM
Krinkle set Security to None.Mar 31 2015, 5:53 AM
Krinkle added a subscriber: Nemo_bis.

I haven't seen it on en.m.wikipedia.org, though recently I have on en.m.wiktionary.org when logged out (since $wgDismissableSiteNoticeForAnons was enabled).

On enwiktionary, MediaWiki:Anonnotice is <span></span>. This is because core provides no better way for wiki sysops to disable the normal sitenotice for anons. So IMO this is an issue in core, not in DismissableSiteNotice.

It looks like mediawiki.org uses a similar hack (<p></p>). I'm working on a core patch to allow setting the anonnotice to the empty string.

Change 200900 had a related patch set uploaded (by PleaseStand):
Allow setting the anonnotice to the empty string

https://gerrit.wikimedia.org/r/200900

Change 200900 had a related patch set uploaded (by PleaseStand):
Allow setting the anonnotice to the empty string

https://gerrit.wikimedia.org/r/200900

This is a very good change for core, regardless of whether one is using the extension or not. We've had people quarrel on &nbsp; vs. <p></p> vs. random empty HTML tag for too long. :)

That said, perhaps DismissableSiteNotice might be made smarter at finding out whether there is content in the sitenotice.

Still broken in 1.25wmf23 causing things like this for all readers not logged-in.

Change 202313 had a related patch set uploaded (by Krinkle):
Allow setting anonnotice to "" to prevent fallback to sitenotice

https://gerrit.wikimedia.org/r/202313

Change 200900 merged by jenkins-bot:
Allow setting anonnotice to "" to prevent fallback to sitenotice

https://gerrit.wikimedia.org/r/200900

Change 202391 had a related patch set uploaded (by Krinkle):
Allow setting anonnotice to "" to prevent fallback to sitenotice

https://gerrit.wikimedia.org/r/202391

Change 202313 merged by jenkins-bot:
Allow setting anonnotice to "" to prevent fallback to sitenotice

https://gerrit.wikimedia.org/r/202313

Change 202391 merged by jenkins-bot:
Allow setting anonnotice to "" to prevent fallback to sitenotice

https://gerrit.wikimedia.org/r/202391

@Krinkle, aren't we done with this now? Can we close it?

Krinkle closed this task as Declined.May 23 2015, 3:46 PM
Krinkle claimed this task.

@Krinkle, aren't we done with this now? Can we close it?

Yep. There may still be wikis that have this, in which case a local sysop or editinterface user should fix the sitenotice to be properly empty.

Yep. There may still be wikis that have this, in which case a local sysop or editinterface user should fix the sitenotice to be properly empty.

Can we get a list?