Page MenuHomePhabricator
Create Task
Maniphest T94536

"[dismiss]" shown on all desktop/mobile pages regardless of the wiki having any sitenotice at the time
Closed, DeclinedPublic
Actions

Description

I've noticed past week when browsing Wikipedia on Mobile Safari (en.m.wikipedia.org) and mediawiki.org in Chrome (desktop, OSX), there's a [dismiss] everywhere. Closing it works, but it should not be shown.

See Also: T94374: DismissableSiteNotice's close link is shown even when JavaScript is disabled

Details

SubjectRepoBranchLines +/-
Allow setting anonnotice to "" to prevent fallback to sitenoticemediawiki/corewmf/1.25wmf23+10 -4
Allow setting anonnotice to "" to prevent fallback to sitenoticemediawiki/corewmf/1.25wmf24+10 -4
Allow setting anonnotice to "" to prevent fallback to sitenoticemediawiki/coremaster+10 -4
Customize query in gerrit

Related Objects

Event Timeline

Krinkle created this task.Mar 31 2015, 5:51 AM
Krinkle raised the priority of this task from to High.
Krinkle updated the task description. (Show Details)
Krinkle added projects: DismissableSiteNotice, Regression.
Krinkle moved this task to Backlog on the DismissableSiteNotice board.
Krinkle subscribed.
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMar 31 2015, 5:51 AM
Krinkle set Security to None.Mar 31 2015, 5:53 AM
Krinkle added a subscriber: Nemo_bis.
Aklapper updated the task description. (Show Details)Mar 31 2015, 11:51 AM
Aklapper mentioned this in T94374: DismissableSiteNotice's close link is shown even when JavaScript is disabled.
PleaseStand subscribed.Mar 31 2015, 4:47 PM

I haven't seen it on en.m.wikipedia.org, though recently I have on en.m.wiktionary.org when logged out (since $wgDismissableSiteNoticeForAnons was enabled).

On enwiktionary, MediaWiki:Anonnotice is <span></span>. This is because core provides no better way for wiki sysops to disable the normal sitenotice for anons. So IMO this is an issue in core, not in DismissableSiteNotice.

PleaseStand added a comment.Mar 31 2015, 5:14 PM

It looks like mediawiki.org uses a similar hack (<p></p>). I'm working on a core patch to allow setting the anonnotice to the empty string.

gerritbot subscribed.Mar 31 2015, 5:47 PM

Change 200900 had a related patch set uploaded (by PleaseStand):
Allow setting the anonnotice to the empty string

https://gerrit.wikimedia.org/r/200900

gerritbot added a project: Patch-For-Review.Mar 31 2015, 5:47 PM
Nemo_bis added a subscriber: FreedomFighterSparrow.Apr 1 2015, 9:00 AM
In T94536#1167618, @gerritbot wrote:

Change 200900 had a related patch set uploaded (by PleaseStand):
Allow setting the anonnotice to the empty string

https://gerrit.wikimedia.org/r/200900

This is a very good change for core, regardless of whether one is using the extension or not. We've had people quarrel on &nbsp; vs. <p></p> vs. random empty HTML tag for too long. :)

That said, perhaps DismissableSiteNotice might be made smarter at finding out whether there is content in the sitenotice.

Krinkle added a comment.Apr 7 2015, 2:31 AM

Still broken in 1.25wmf23 causing things like this for all readers not logged-in.

Screen_Shot_2015-04-07_at_03.30.40.png (406×1 px, 89 KB)

gerritbot added a comment.Apr 7 2015, 2:31 AM

Change 202313 had a related patch set uploaded (by Krinkle):
Allow setting anonnotice to "" to prevent fallback to sitenotice

https://gerrit.wikimedia.org/r/202313

gerritbot added a comment.Apr 7 2015, 2:44 AM

Change 200900 merged by jenkins-bot:
Allow setting anonnotice to "" to prevent fallback to sitenotice

https://gerrit.wikimedia.org/r/200900

Krinkle mentioned this in rMW251b345151a1: Allow setting anonnotice to "" to prevent fallback to sitenotice.Apr 7 2015, 2:44 AM
gerritbot added a comment.Apr 7 2015, 2:13 PM

Change 202391 had a related patch set uploaded (by Krinkle):
Allow setting anonnotice to "" to prevent fallback to sitenotice

https://gerrit.wikimedia.org/r/202391

gerritbot added a comment.Apr 7 2015, 4:46 PM

Change 202313 merged by jenkins-bot:
Allow setting anonnotice to "" to prevent fallback to sitenotice

https://gerrit.wikimedia.org/r/202313

Krinkle mentioned this in rMWf08519b3c544: Allow setting anonnotice to "" to prevent fallback to sitenotice.Apr 7 2015, 4:47 PM
gerritbot added a comment.Apr 7 2015, 4:48 PM

Change 202391 merged by jenkins-bot:
Allow setting anonnotice to "" to prevent fallback to sitenotice

https://gerrit.wikimedia.org/r/202391

Krinkle mentioned this in rMW2f3a3dcf3c88: Allow setting anonnotice to "" to prevent fallback to sitenotice.Apr 7 2015, 4:48 PM
FreedomFighterSparrow added a comment.May 23 2015, 2:56 PM

@Krinkle, aren't we done with this now? Can we close it?

Krinkle closed this task as Declined.May 23 2015, 3:46 PM
Krinkle claimed this task.
In T94536#1305233, @FreedomFighterSparrow wrote:

@Krinkle, aren't we done with this now? Can we close it?

Yep. There may still be wikis that have this, in which case a local sysop or editinterface user should fix the sitenotice to be properly empty.

Nemo_bis added a comment.May 24 2015, 5:55 AM
In T94536#1305341, @Krinkle wrote:

Yep. There may still be wikis that have this, in which case a local sysop or editinterface user should fix the sitenotice to be properly empty.

Can we get a list?

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits