Page MenuHomePhabricator
Create Task
Maniphest T94556

[code] Hygiene: improve isOwner on collection
Closed, ResolvedPublic
Actions

Description

Improve isOwner on models\CollectionBase to do the check as in Special:Gather with the equals method on User.

Actually use that method in SpecialGather.php whenever possible.

Details

SubjectRepoBranchLines +/-
Hygiene: Improve Collection::isOwnermediawiki/extensions/Gathermaster+10 -18
Customize query in gerrit

Related Objects

Event Timeline

• Jhernandez created this task.Mar 31 2015, 10:56 AM
• Jhernandez claimed this task.
• Jhernandez raised the priority of this task from to Medium.
• Jhernandez updated the task description. (Show Details)
• Jhernandez added a project: Gather Sprint Enwiki.
• Jhernandez subscribed.
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMar 31 2015, 10:56 AM
• Jhernandez moved this task from In Analysis to Code review needed on the Gather Sprint Enwiki board.Mar 31 2015, 10:57 AM
gerritbot subscribed.Mar 31 2015, 10:57 AM

Change 200844 had a related patch set uploaded (by Jhernandez):
Hygiene: Improve Collection::isOwner

https://gerrit.wikimedia.org/r/200844

gerritbot added a project: Patch-For-Review.Mar 31 2015, 10:57 AM
Jdlrobson moved this task from Code review needed to Ready for signoff on the Gather Sprint Enwiki board.Mar 31 2015, 9:33 PM
Jdlrobson moved this task from Ready for signoff to Done on the Gather Sprint Enwiki board.
gerritbot added a comment.Mar 31 2015, 9:38 PM

Change 200844 merged by jenkins-bot:
Hygiene: Improve Collection::isOwner

https://gerrit.wikimedia.org/r/200844

Diffusion mentioned this in rMEXT68468ab8f91c: Updated mediawiki/extensions Project: mediawiki/extensions/Gather….Mar 31 2015, 9:38 PM
Jdlrobson closed this task as Resolved.Apr 2 2015, 11:20 PM
Jdlrobson subscribed.
Diffusion mentioned this in rEGAT3783915f8c98: Hygiene: Improve Collection::isOwner.Apr 8 2015, 6:17 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits