pywikibot fails with SVN version 1.8.11
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	jayvdb
	Apr 4 2015, 2:39 AM

Description

SVN format 29 was supported last time I used an SVN checkout (Aug 2014 for 9a2d001c and 7a6dbf4d)

Now SVN on my Fedora box fails with

[workarea] is too old (format 29) to work with client version '1.8.11 (r1643975)' (expects format 31). You need to upgrade the working copy first.

After upgrading the SVN, the following error occurs in both core and compat (slightly different backtrace, failing much earlier):

core$ python pwb.py shell
WARNING: ...pywikibot/tools/ip.py:37: ImportWarning: ipaddress backport is defective; patching.
Welcome to the Pywikibot interactive shell!
>>> import pywikibot
>>> pywikibot.version.getversiondict()
Traceback (most recent call last):
  File "<console>", line 1, in <module>
  File ".../pywikibot/version.py", line 64, in getversiondict
    (tag, rev, date, hsh) = getversion_svn(_program_dir)
  File ".../pywikibot/version.py", line 171, in getversion_svn
    tag, rev, date = svn_rev_info(_program_dir)
  File ".../pywikibot/version.py", line 102, in svn_rev_info
    entries = open(os.path.join(_program_dir, '.svn/entries'))
IOError: [Errno 2] No such file or directory: '.../.svn/entries'

compat$ python pwb.py shell
setting UA
Traceback (most recent call last):
  File "pwb.py", line 50, in <module>
    import userlib
  File ".../userlib.py", line 13, in <module>
    import wikipedia as pywikibot
  File ".../wikipedia.py", line 6063, in <module>
    versionrev=(version.getversiondict()["rev"])
  File ".../pywikibot/version.py", line 68, in getversiondict
    (tag, rev, date, hsh) = getversion_svn(_program_dir)
  File ".../pywikibot/version.py", line 128, in getversion_svn
    entries = open(os.path.join(_program_dir, '.svn/entries'))
IOError: [Errno 2] No such file or directory: '.../.svn/entries'

And the entries file is missing from the .svn directory.

core$ ls .svn
pristine tmp wc.db

Details

	Subject	Repo	Branch	Lines +/-
	[FEAT] version: Use svn info command	pywikibot/core	master	+70 -30
	Use setuptools for SVN support	pywikibot/core	master	+150 -34

Customize query in gerrit

Related Objects

Mentioned In: T97241: version.py fails for svn
rPWBC7446058e814d: Use setuptools for SVN support
Mentioned Here: T95077: pywikibot fails with SVN file formats before 12
rPWBC9a2d001c1a86: Split getversion_svn into two utility functions
rPWBC7a6dbf4d3983: Replace httplib and urllib with httplib2

Event Timeline

jayvdb created this task.Apr 4 2015, 2:39 AM

jayvdb raised the priority of this task from to Needs Triage.

jayvdb updated the task description. (Show Details)

jayvdb added projects: Pywikibot, Pywikibot-compat.

jayvdb subscribed.

Restricted Application added subscribers: Aklapper, Unknown Object (MLST). · View Herald TranscriptApr 4 2015, 2:39 AM

We have users that cant use GIT, and instead use SVN. Since it is broken, they must not be on a recent SVN version, or they are very quiet :/

jayvdb updated the task description. (Show Details)Apr 4 2015, 5:47 AM

jayvdb set Security to None.

~~There are three dots in the path?~~

Ah that's not the problem but the missing file in .svn. Have they changed how that path looks?!

Can't reproduce this:

xzise@localhost:~/Programms/pywikibot/core-svn$ svn --version
svn, version 1.8.11 (r1643975)
   compiled Dec 16 2014, 13:31:09 on x86_64-redhat-linux-gnu

Copyright (C) 2014 The Apache Software Foundation.
This software consists of contributions made by many people;
see the NOTICE file for more information.
Subversion is open source software, see http://subversion.apache.org/

The following repository access (RA) modules are available:

* ra_svn : Module for accessing a repository using the svn network protocol.
  - with Cyrus SASL authentication
  - handles 'svn' scheme
* ra_local : Module for accessing a repository on local disk.
  - handles 'file' scheme
* ra_serf : Module for accessing a repository via WebDAV protocol using serf.
  - using serf 1.3.7
  - handles 'http' scheme
  - handles 'https' scheme
xzise@localhost:~/Programms/pywikibot/core-svn/core$ cat .svn/entries 
12

Now I don't know when svn info was introduced but it could be used instead and maybe fix T95077: pywikibot fails with SVN file formats before 12 too:

core$ svn info --xml
<?xml version="1.0" encoding="UTF-8"?>
<info>
<entry
   path="."
   revision="6313"
   kind="dir">
<url>https://github.com/wikimedia/pywikibot-core/trunk</url>
<relative-url>^/trunk</relative-url>
<repository>
<root>https://github.com/wikimedia/pywikibot-core</root>
<uuid>0f328886-bf45-b297-fba8-ce57b7db7bff</uuid>
</repository>
<wc-info>
<wcroot-abspath>/home/xzise/Programms/pywikibot/core-svn/core</wcroot-abspath>
<schedule>normal</schedule>
<depth>infinity</depth>
</wc-info>
<commit
   revision="6313">
<author>jenkins.bot</author>
<date>2015-04-02T15:00:24.000000Z</date>
</commit>
</entry>
</info>

This returns very cleanly the date and revision. Only the tag is not directly apparent from that and I'm not exactly sure what that tag actually is.

Change 201907 had a related patch set uploaded (by XZise):
[FEAT] version: Use svn info command

https://gerrit.wikimedia.org/r/201907

gerritbot added a project: Patch-For-Review.Apr 4 2015, 8:11 PM

In T95075#1179877, @XZise wrote:

Can't reproduce this:

xzise@localhost:~/Programms/pywikibot/core-svn$ svn --version
svn, version 1.8.11 (r1643975)
   compiled Dec 16 2014, 13:31:09 on x86_64-redhat-linux-gnu

Copyright (C) 2014 The Apache Software Foundation.
This software consists of contributions made by many people;
see the NOTICE file for more information.
Subversion is open source software, see http://subversion.apache.org/

The following repository access (RA) modules are available:

* ra_svn : Module for accessing a repository using the svn network protocol.
  - with Cyrus SASL authentication
  - handles 'svn' scheme
* ra_local : Module for accessing a repository on local disk.
  - handles 'file' scheme
* ra_serf : Module for accessing a repository via WebDAV protocol using serf.
  - using serf 1.3.7
  - handles 'http' scheme
  - handles 'https' scheme
xzise@localhost:~/Programms/pywikibot/core-svn/core$ cat .svn/entries 
12

You have the exact same version of SVN.
When I do a fresh checkout using svn 1.8.11, entries does exist.

$ ls .svn
entries  format  pristine  tmp  wc.db
$ cat .svn/entries 
12

So it looks like this problem may only exist when a old svn workarea is upgraded using svn upgrade...?

In T95075#1180239, @jayvdb wrote:

So it looks like this problem may only exist when a old svn workarea is upgraded using svn upgrade...?

I've confirmed this by using TortoiseSVN 1.8 to svn upgrade an SVN workarea checked out with TortoiseSVN 1.7, and there is no entries file, even after svn update and the SVN Update GUI.