Page MenuHomePhabricator

Find new position for Font changer in alpha mode
Closed, ResolvedPublic

Description

(I thought we already have this task, but i couldn't find it?)

After https://gerrit.wikimedia.org/r/#/c/193373/ the font changer in alpha mode is useless, because there is no content on Special:MobileMenu where you can change the font size (sure, it will be saved, but you can't see any difference).

So we need to find a new place for the font changer link :)

Event Timeline

Florian created this task.Apr 6 2015, 6:06 PM
Florian raised the priority of this task from to Needs Triage.
Florian updated the task description. (Show Details)
Florian added a project: Readers-Web-Backlog.
Florian added a subscriber: Florian.
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptApr 6 2015, 6:06 PM

Change 202077 had a related patch set uploaded (by Florianschmidtwelzow):
Disable mobile.fontchanger after it is useful again

https://gerrit.wikimedia.org/r/202077

Change 202077 merged by jenkins-bot:
Disable mobile.fontchanger after it is useful again

https://gerrit.wikimedia.org/r/202077

@Florian can you confirm that this is resolved? Thanks!

@JKatzWMF: Not really :) We still need, like KLans_WMF wrote, some design input. My change only disables the fontchanger (because it's useless now). After we have a better position for the fontchanger link (somewhere on the article page), we can reactivate it :)

Change 213288 had a related patch set uploaded (by Florianschmidtwelzow):
Re-enable fontchanger in alpha

https://gerrit.wikimedia.org/r/213288

Florian claimed this task.May 24 2015, 2:08 PM

Like i wrote in the commit message: The main menu is rendered via JS again, so the font changer can get it's old place :)

Change 213288 merged by jenkins-bot:
Re-enable fontchanger in alpha

https://gerrit.wikimedia.org/r/213288

Florian closed this task as Resolved.May 24 2015, 10:36 PM