batch deletions in pruneChanges script
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	aude
	Apr 10 2015, 3:50 PM

Description

00:17 < pastacat> aude: PruneChanges from WB should probably batch the DELETE query for sanity
00:28 < pastacat> aude: and waitForSlaves in EntityPerPageBuilder should use wfWaitForSlaves since $lb->getMaxLag() so too cached
00:30 * pastacat notices random stuff
00:38 < pastacat> though I guess if getLagTimes gets hit enough it regenerates a lot

Details

	Subject	Repo	Branch	Lines +/-
	Batch deletions in pruneChanges script	mediawiki/extensions/Wikibase	master	+23 -17

Customize query in gerrit

Related Objects

Mentioned In: rMEXTf65ec9494c06: Updated mediawiki/extensions Project: mediawiki/extensions/Wikibase…
rEWBAa2d105f56b77: Batch deletions in pruneChanges script

Event Timeline

aude created this task.Apr 10 2015, 3:50 PM

aude raised the priority of this task from to Needs Triage.

aude updated the task description. (Show Details)

aude added projects: Wikidata, MediaWiki-extensions-WikibaseRepository.

aude subscribed.

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptApr 10 2015, 3:50 PM

aude added a project: Wikidata-Sprint-2015-04-07.Apr 10 2015, 3:57 PM

aude set Security to None.

Change 203371 had a related patch set uploaded (by Aude):
Batch deletions in pruneChanges script

https://gerrit.wikimedia.org/r/203371

gerritbot added a project: Patch-For-Review.Apr 10 2015, 4:46 PM

aude triaged this task as Medium priority.Apr 10 2015, 7:31 PM

aaron added a project: Sustainability.Apr 11 2015, 5:49 AM

Lydia_Pintscher moved this task from incoming to ready to go on the Wikidata board.Apr 13 2015, 10:17 AM

aude claimed this task.Apr 14 2015, 6:30 AM

aude moved this task from Backlog to Doing on the Wikidata-Sprint-2015-04-07 board.Apr 14 2015, 6:35 AM

A few minor log entries:

2015-04-15 07:45:01 terbium wikidatawiki: Query affected 2498 row(s):
query-m: DELETE FROM wb_changes WHERE (change_time < 'X')
TransactionProfiler.php line 173 calls wfBacktrace()
Database.php line 1165 calls TransactionProfiler->recordQueryCompletion()
Database.php line 3102 calls DatabaseBase->query()
pruneChanges.php line 174 calls DatabaseBase->delete()
pruneChanges.php line 100 calls Wikibase\PruneChanges->pruneChanges()
doMaintenance.php line 103 calls Wikibase\PruneChanges->execute()
pruneChanges.php line 182 calls require_once()
MWScript.php line 97 calls require_once()