Error during editor initialization makes it impossible to try to edit a second time
Closed, ResolvedPublic8 Estimated Story Points
Actions

Assigned To

Authored By

	matmarex
	Apr 17 2015, 9:04 PM

Description

Discovered after T96435. That error during editor initialization leaves it in half-loaded unrecoverable state. Progress bar is still displayed, content is greyed out, there is no way to go back to reading the content (other than refreshing the page).

Details

	Subject	Repo	Branch	Lines +/-
	If init fails once, don't completely break when the user retries	mediawiki/extensions/VisualEditor	master	+3 -0

Customize query in gerrit

Related Objects

Mentioned In: rEVED23691dc8610f: If init fails once, don't completely break when the user retries
Mentioned Here: T96435: Unable to edit any page with VE using Opera 12: "ve-api: Revision IDs (doc=0,api=NNN) returned by server do not match."

Event Timeline

matmarex created this task.Apr 17 2015, 9:04 PM

matmarex raised the priority of this task from to Needs Triage.

matmarex updated the task description. (Show Details)

matmarex added projects: VisualEditor, VisualEditor-MediaWiki.

matmarex added subscribers: matmarex, Aklapper.

Jdforrester-WMF assigned this task to Krenair.Aug 25 2015, 7:21 PM

Jdforrester-WMF triaged this task as High priority.

Jdforrester-WMF added a project: VisualEditor-Initialisation.

Jdforrester-WMF set Security to None.

Jdforrester-WMF edited a custom field.

Jdforrester-WMF moved this task from To Triage to TR0: Interrupt on the VisualEditor board.

I made Target's loadSuccess function call loadFail and return (like it does for "Revision IDs (doc=x,api=y) returned by server do not match"), but it removed the progress bar and you're sent back to reading the page... Stuff only breaks if you then click the Edit button again.
Does this match the current behaviour you see when these errors happen, @matmarex?

Yeah.

Krenair renamed this task from Error during editor initialization leaves it in half-loaded unrecoverable state to Error during editor initialization makes it impossible to try to edit a second time.Aug 27 2015, 1:27 AM

Change 238303 had a related patch set uploaded (by Alex Monk):
If init fails once, don't completely break when the user retries

https://gerrit.wikimedia.org/r/238303

gerritbot added a project: Patch-For-Review.Sep 14 2015, 8:15 PM

Jdforrester-WMF closed this task as Resolved.Sep 14 2015, 9:51 PM

Jdforrester-WMF removed a project: Patch-For-Review.

Change 238303 merged by jenkins-bot:
If init fails once, don't completely break when the user retries

https://gerrit.wikimedia.org/r/238303

Krenair mentioned this in rEVED23691dc8610f: If init fails once, don't completely break when the user retries.Sep 14 2015, 9:56 PM

ReleaseTaggerBot added a project: WMF-deploy-2015-09-15_(1.26wmf23).Sep 14 2015, 10:00 PM

Error during editor initialization makes it impossible to try to edit a second timeClosed, ResolvedPublic8 Estimated Story PointsActions

Description

Details

Related Objects

Event Timeline

Error during editor initialization makes it impossible to try to edit a second time
Closed, ResolvedPublic8 Estimated Story Points
Actions