Page MenuHomePhabricator
Create Task
Maniphest T97436

Redirect /by/User/123 to /id/123/My-awesome-collection
Closed, ResolvedPublic
Actions

Description

Redirect /by/User/123 to /id/123/My-awesome-collection to have a canonical url instead of two pointing at the same place (and duplicated code BTW).

See includes/specials/SpecialGather.php' line 79`

Details

SubjectRepoBranchLines +/-
Unify collections urlmediawiki/extensions/Gathermaster+6 -13
Customize query in gerrit

Related Objects

Event Timeline

• Jhernandez created this task.Apr 28 2015, 5:12 PM
• Jhernandez raised the priority of this task from to Needs Triage.
• Jhernandez updated the task description. (Show Details)
• Jhernandez added a project: Gather Sprint Greatest Hits.
• Jhernandez moved this task to In Analysis on the Gather Sprint Greatest Hits board.
• Jhernandez subscribed.
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptApr 28 2015, 5:12 PM
• Jhernandez updated the task description. (Show Details)Apr 28 2015, 5:13 PM
• Jhernandez set Security to None.
Jdlrobson added subscribers: • Moushira, Jdlrobson.Apr 29 2015, 4:57 PM

Ping @Moushira

Jdlrobson added a comment.Apr 29 2015, 5:01 PM

Sorry @Moushira wrong bug.

@Jhernandez what is the motivation here?
Avoiding us showing up twice in search results?
Tech debt?

I actually think multiple urls are great when they follow logical patterns.

• Jhernandez added a comment.Apr 29 2015, 5:01 PM

Sorry I meant to suggest to ping her on T97488 not on this one :S Crappy internet :(

• Jhernandez added a comment.Apr 29 2015, 5:05 PM

@Jdlrobson I don't know I feel like it should have a unique url, I guess it is just taste.

Jdlrobson moved this task from In Analysis to Ready for dev on the Gather Sprint Greatest Hits board.Apr 30 2015, 4:54 PM
• Jhernandez claimed this task.May 5 2015, 4:28 PM
• Jhernandez moved this task from Ready for dev to In development on the Gather Sprint Greatest Hits board.
gerritbot subscribed.May 5 2015, 5:05 PM

Change 209003 had a related patch set uploaded (by Jhernandez):
Unify collections url

https://gerrit.wikimedia.org/r/209003

gerritbot added a project: Patch-For-Review.May 5 2015, 5:05 PM
• Jhernandez moved this task from In development to Code review needed on the Gather Sprint Greatest Hits board.May 5 2015, 5:06 PM
Jdlrobson moved this task from Code review needed to Ready for signoff on the Gather Sprint Greatest Hits board.May 5 2015, 6:12 PM
gerritbot added a comment.May 5 2015, 6:15 PM

Change 209003 merged by jenkins-bot:
Unify collections url

https://gerrit.wikimedia.org/r/209003

Diffusion mentioned this in rMEXTbcb342a8b1db: Updated mediawiki/extensions Project: mediawiki/extensions/Gather….May 5 2015, 6:16 PM
Diffusion mentioned this in rEGAT654e752aaadc: Unify collections url.
Jdlrobson closed this task as Resolved.May 7 2015, 7:56 PM
Jdlrobson moved this task from Ready for signoff to Done on the Gather Sprint Greatest Hits board.

http://en.m.wikipedia.beta.wmflabs.org/wiki/Special:Gather/by/Jdlrobson/5 redirects for me.

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits