Page MenuHomePhabricator

Simplify selector for main menu button
Closed, ResolvedPublic

Description

The main menu in alpha uses a different selector(s) from the main menu button. This has resulted in additional css rules and JS code in our stable site.
e.g.
'#mw-mf-main-menu-button, .alpha .header a.header-icon, .alpha .header .header-title a'

This is really not acceptable, no matter how minor - it makes the code less readable, it risks regressions in stable and if done too many times can cause problems with firstPaint time and redundant css.

Please make this a single selector and add classes to the elements it applies to.

Event Timeline

Jdlrobson raised the priority of this task from to Needs Triage.
Jdlrobson updated the task description. (Show Details)
Jdlrobson added a project: Web-Team-Backlog.
Jdlrobson moved this task to Incoming on the Web-Team-Backlog board.
Jdlrobson subscribed.