Page MenuHomePhabricator
Create Task
Maniphest T98947

'New' tag duplicated on menu when creating collection
Closed, ResolvedPublic
Actions

Description

Created a collection and added a few items on https://test.m.wikipedia.org a few times without leaving page and the tag on the menu is duplicated:

Screen Shot 2015-05-13 at 11.32.06 AM.png (301×433 px, 27 KB)

Also there are multiple CTA overlays even if you can only see one.

Details

SubjectRepoBranchLines +/-
Fix duplicate 'new' tag and menu item CTAmediawiki/extensions/Gatherwmf/1.26wmf5+17 -11
Fix duplicate 'new' tag and menu item CTAmediawiki/extensions/Gathermaster+17 -11
Customize query in gerrit

Related Objects

Event Timeline

• Jhernandez created this task.May 13 2015, 9:36 AM
• Jhernandez claimed this task.
• Jhernandez raised the priority of this task from to Unbreak Now!.
• Jhernandez updated the task description. (Show Details)
• Jhernandez added a project: Gather Sprint Help!.
• Jhernandez moved this task to In development on the Gather Sprint Help! board.
• Jhernandez subscribed.
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMay 13 2015, 9:36 AM
• Jhernandez added a comment.May 13 2015, 9:43 AM

I've created another one on the same page without leaving and it gets worse 😓😂

Screen Shot 2015-05-13 at 11.42.20 AM.png (417×673 px, 50 KB)

gerritbot subscribed.May 13 2015, 10:22 AM

Change 210668 had a related patch set uploaded (by Jhernandez):
Fix duplicate 'new' tag and menu item CTA

https://gerrit.wikimedia.org/r/210668

gerritbot added a project: Patch-For-Review.May 13 2015, 10:23 AM
• Jhernandez added a comment.May 13 2015, 10:23 AM

Basically, this bug and patch is an example of how event handler hell exists.

• Jhernandez moved this task from In development to Code review needed on the Gather Sprint Help! board.May 13 2015, 10:24 AM
• Jhernandez updated the task description. (Show Details)May 13 2015, 10:30 AM
• Jhernandez set Security to None.
Jdlrobson subscribed.May 13 2015, 10:49 AM

It's new new!! :) will look at this later today.

Jdlrobson moved this task from Code review needed to Needs more development (-1) on the Gather Sprint Help! board.May 13 2015, 4:47 PM
gerritbot added a comment.May 13 2015, 5:13 PM

Change 210668 merged by jenkins-bot:
Fix duplicate 'new' tag and menu item CTA

https://gerrit.wikimedia.org/r/210668

Diffusion mentioned this in rEGAT368b15f3e24e: Fix duplicate 'new' tag and menu item CTA.May 13 2015, 5:13 PM
Diffusion mentioned this in rMEXT95000eeae46f: Updated mediawiki/extensions Project: mediawiki/extensions/Gather….
• Jhernandez moved this task from Needs more development (-1) to Ready for signoff on the Gather Sprint Help! board.May 13 2015, 5:25 PM
gerritbot added a comment.May 13 2015, 6:44 PM

Change 210745 had a related patch set uploaded (by Robmoen):
Fix duplicate 'new' tag and menu item CTA

https://gerrit.wikimedia.org/r/210745

gerritbot added a comment.May 13 2015, 11:01 PM

Change 210745 merged by jenkins-bot:
Fix duplicate 'new' tag and menu item CTA

https://gerrit.wikimedia.org/r/210745

• rmoen mentioned this in rEGATefee6215b6d2: Fix duplicate 'new' tag and menu item CTA.May 13 2015, 11:01 PM
• JKatzWMF closed this task as Resolved.May 21 2015, 2:30 PM
• JKatzWMF moved this task from Ready for signoff to Done on the Gather Sprint Help! board.
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL