Page MenuHomePhabricator

fred
User

Projects

User does not belong to any projects.

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Sunday

  • Clear sailing ahead.

User Details

User Since
May 20 2015, 12:00 AM (466 w, 2 d)
Availability
Available
LDAP User
Unknown
MediaWiki User
FredEmmott [ Global Accounts ]

Recent Activity

Sep 13 2018

fred added a comment to T176370: Migrate to PHP 7 in WMF production.

3.30 (due mid-December) will be the last HHVM release that aims to support PHP: https://hhvm.com/blog/2018/09/12/end-of-php-support-future-of-hack.html

Sep 13 2018, 3:22 PM · Platform Team Initiatives (PHP7 (TEC4)), TechCom-RFC (TechCom-RFC-Closed), User-ArielGlenn, HHVM, SRE

Jan 25 2018

fred added a comment to T185024: Re-add complete URL parsing fix from HHVM 3.18.7 release.

If it's practical, I'm going to do it even if it's not necessary for Wikipedia - breaking things 4 days before the end of support and not fixing them isn't ideal, and we have other reports of this issue.

Jan 25 2018, 6:24 PM · MediaWiki-Core-Tests, SRE, HHVM
fred added a comment to T185024: Re-add complete URL parsing fix from HHVM 3.18.7 release.

Also:

  • From Facebook's perspective, HHVM 3.18 is unsupported as of 2018-01-16; that said, I'm likely to make an exception for the a fix for this issue given how recently we introduced the regression, if backporting it isn't too involved.
  • Travis uses our packages, not the DFSG ones
  • We're not ready to announce this yet (want a little more testing first), but as of last week, we started packaging for Trusty again, and Travis now has 3.21 and 3.24 available: https://travis-ci.org/fredemmott/travistest/builds/333382730
Jan 25 2018, 5:58 PM · MediaWiki-Core-Tests, SRE, HHVM
fred added a comment to T185024: Re-add complete URL parsing fix from HHVM 3.18.7 release.

https://gist.github.com/fredemmott/39c9abef4571f1e337d339fd8355da60 should resolve this, and will hopefully land to HHVM master, 3.21, and 3.24 in the next few days.

Jan 25 2018, 5:52 PM · MediaWiki-Core-Tests, SRE, HHVM

Jan 20 2016

fred added a comment to T124163: Fatal error: Cannot access protected property DiffEngine::$seq.

I'm not directly working on HHVM any more, though I'll see if I can get that issue prioritized: the trigger here is https://github.com/facebook/hhvm/commit/d7ce713deeb541e05c0b2b66c30114f6931c1bb5

Jan 20 2016, 6:03 PM · affects-translatewiki.net, MediaWiki-Page-history, MW-1.26-release, Patch-For-Review, MW-1.27-release (WMF-deploy-2016-03-08_(1.27.0-wmf.16)), MW-1.27-release-notes, HHVM, MediaWiki-Page-diffs

Jul 8 2015

fred added a comment to T99740: Use static php array files for l10n cache at WMF (instead of CDB).

Is there any data yet from wikipedia deployments?

Jul 8 2015, 9:26 PM · Wikimedia-Performance-recommendation, Release-Engineering-Team (Radar), Scap, MediaWiki-Internationalization

Jun 12 2015

fred added a comment to T100976: Thumbnails should embed tinyRGB instead of sRGB when they include that ICC profile.

TinyRGB can be redistributed under the terms of CC0, available at https://creativecommons.org/publicdomain/zero/1.0/

Jun 12 2015, 5:39 PM · MW-1.26-release, WMF-deploy-2015-06-23_(1.26wmf11), Performance-Team, Performance Issue, Commons
fred added a comment to T100976: Thumbnails should embed tinyRGB instead of sRGB when they include that ICC profile.

We're likely to make this available under CC0 - hopefully will have this finalized soon :)

Jun 12 2015, 4:58 PM · MW-1.26-release, WMF-deploy-2015-06-23_(1.26wmf11), Performance-Team, Performance Issue, Commons

Jun 5 2015

fred added a comment to T99740: Use static php array files for l10n cache at WMF (instead of CDB).

Re-ran the benchmarks.

Jun 5 2015, 9:23 PM · Wikimedia-Performance-recommendation, Release-Engineering-Team (Radar), Scap, MediaWiki-Internationalization

May 20 2015

fred added a comment to T99740: Use static php array files for l10n cache at WMF (instead of CDB).

More results:

  • if you were already using repo-auth, this would be a 12% improvement
  • if you were using PHP7, this would be a ~ 1% improvement
May 20 2015, 6:14 PM · Wikimedia-Performance-recommendation, Release-Engineering-Team (Radar), Scap, MediaWiki-Internationalization
fred added a comment to T99740: Use static php array files for l10n cache at WMF (instead of CDB).

Done

May 20 2015, 4:36 PM · Wikimedia-Performance-recommendation, Release-Engineering-Team (Radar), Scap, MediaWiki-Internationalization
fred added a comment to T99740: Use static php array files for l10n cache at WMF (instead of CDB).

Looked at this in a bit more detail - as well as array access being faster, the main advantage is actually that this significantly reduces the use of unserialize(), which does a lot of memcpys when making the strings.

May 20 2015, 4:21 PM · Wikimedia-Performance-recommendation, Release-Engineering-Team (Radar), Scap, MediaWiki-Internationalization
fred added a comment to T99740: Use static php array files for l10n cache at WMF (instead of CDB).

This naive implementation shows a ~ 7% win on HHVM, without using repo-authoritative mode: https://gist.github.com/fredemmott/2f760a7702ac2234d38a

May 20 2015, 12:04 AM · Wikimedia-Performance-recommendation, Release-Engineering-Team (Radar), Scap, MediaWiki-Internationalization