Page MenuHomePhabricator

ti_infotrad
User

Projects

User does not belong to any projects.

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Sunday

  • Clear sailing ahead.

User Details

User Since
Dec 19 2017, 8:59 PM (102 w, 3 d)
Availability
Available
LDAP User
Unknown
MediaWiki User
Ti infotrad [ Global Accounts ]

Recent Activity

Fri, Nov 15

ti_infotrad added a comment to T236247: Collapsible elements are not visible in VisualEditor.

Yes I will.

Fri, Nov 15, 11:57 AM · Patch-For-Review, MW-1.35-notes (1.35.0-wmf.5; 2019-11-05), VisualEditor-ContentEditable, VisualEditor (Current work)

Nov 6 2019

ti_infotrad added a comment to T236247: Collapsible elements are not visible in VisualEditor.

The code change below (implemented in extensions/VisualEditor/modules/ve-mw/init/styles/ve.init.mw.Target.css) fixes the issues my clients are experiencing

Nov 6 2019, 8:43 PM · Patch-For-Review, MW-1.35-notes (1.35.0-wmf.5; 2019-11-05), VisualEditor-ContentEditable, VisualEditor (Current work)

Oct 31 2019

ti_infotrad added a comment to T236247: Collapsible elements are not visible in VisualEditor.

To be more specific, the line that causes the issue described above is

tr:not( :first-child ),
Oct 31 2019, 6:35 PM · Patch-For-Review, MW-1.35-notes (1.35.0-wmf.5; 2019-11-05), VisualEditor-ContentEditable, VisualEditor (Current work)
ti_infotrad added a comment to T236247: Collapsible elements are not visible in VisualEditor.

Commenting out following section in resources\src\jquery\jquery.makeCollapsible.styles.less fixes the issue

Oct 31 2019, 6:20 PM · Patch-For-Review, MW-1.35-notes (1.35.0-wmf.5; 2019-11-05), VisualEditor-ContentEditable, VisualEditor (Current work)
ti_infotrad added a comment to T236247: Collapsible elements are not visible in VisualEditor.

Here is a sample code where the client is experiencing an issue:

Oct 31 2019, 5:58 PM · Patch-For-Review, MW-1.35-notes (1.35.0-wmf.5; 2019-11-05), VisualEditor-ContentEditable, VisualEditor (Current work)
ti_infotrad added a comment to T236247: Collapsible elements are not visible in VisualEditor.

Still running into issues, collision with collapsible table option in VE. I will try and post an example.

Oct 31 2019, 5:41 PM · Patch-For-Review, MW-1.35-notes (1.35.0-wmf.5; 2019-11-05), VisualEditor-ContentEditable, VisualEditor (Current work)
ti_infotrad added a comment to T236247: Collapsible elements are not visible in VisualEditor.

It seems to work nicely. One question, though: was the change designed to show the inactive [Expand] toggle?

Oct 31 2019, 12:56 AM · Patch-For-Review, MW-1.35-notes (1.35.0-wmf.5; 2019-11-05), VisualEditor-ContentEditable, VisualEditor (Current work)

Oct 30 2019

ti_infotrad added a comment to T236247: Collapsible elements are not visible in VisualEditor.
  • In 1.27, when editing a collapsible div, the collapsed element was automatically expanded (and the js toggle disappeared)
  • In 1.33, when editing the same collapsible div, the collapsed element remains hidded and what looks like the js toggle is displayed but it does not work (i.e clicking on it does nothing)
Oct 30 2019, 1:54 AM · Patch-For-Review, MW-1.35-notes (1.35.0-wmf.5; 2019-11-05), VisualEditor-ContentEditable, VisualEditor (Current work)

Oct 23 2019

ti_infotrad created T236247: Collapsible elements are not visible in VisualEditor.
Oct 23 2019, 12:14 PM · Patch-For-Review, MW-1.35-notes (1.35.0-wmf.5; 2019-11-05), VisualEditor-ContentEditable, VisualEditor (Current work)

Sep 27 2019

ti_infotrad added a comment to T233628: Wrong hyperlink in link dialog in VisualEditor.

OK so the change describe by the diff below seems to work, at least for me...
In file modules\ve-mw\ui\contextitemsve.ui.MWInternalLinkContextItem.js

Sep 27 2019, 12:22 AM · Verified, MW-1.35-notes (1.35.0-wmf.1; 2019-10-08), VisualEditor (Current work)

Sep 23 2019

ti_infotrad added a comment to T233628: Wrong hyperlink in link dialog in VisualEditor.
  • Your fix is for media dialogs; the issue I described is for internal link dialogs (see screenshot below):


I may be able to use your method to fix the related code, looking into it.

Sep 23 2019, 6:01 PM · Verified, MW-1.35-notes (1.35.0-wmf.1; 2019-10-08), VisualEditor (Current work)
ti_infotrad created T233628: Wrong hyperlink in link dialog in VisualEditor.
Sep 23 2019, 1:59 PM · Verified, MW-1.35-notes (1.35.0-wmf.1; 2019-10-08), VisualEditor (Current work)

Sep 19 2019

ti_infotrad added a comment to T232754: Mangling of non existing media links by VisualEditor.

Yes:

  • Excerpt or JSON returned by api.php (see Special:FilePath string)
Sep 19 2019, 11:17 AM · MW-1.34-notes (1.34.0-wmf.25; 2019-10-01), VisualEditor (Current work), Patch-For-Review, Parsoid, VisualEditor-MediaWiki-Links

Sep 12 2019

ti_infotrad created T232754: Mangling of non existing media links by VisualEditor.
Sep 12 2019, 3:26 PM · MW-1.34-notes (1.34.0-wmf.25; 2019-10-01), VisualEditor (Current work), Patch-For-Review, Parsoid, VisualEditor-MediaWiki-Links

Mar 6 2019

ti_infotrad added a comment to T176657: Page editing difference (Collapse/Expand) between test and test2: One shows [Expand] on the right, one expands by clicking the text.

For the record, this issue still exists in MW 1.27.3 but seems to be fixed in later versions [1.33] (confirmed by testing at https://test.wikipedia.org/w/index.php?title=T176657&action=history). Anyway of backporting the fix?

Mar 6 2019, 1:41 PM · MediaWiki-General

Dec 13 2018

ti_infotrad created T211918: Error when editing a page: Error loading data from server: HTTP 0. .
Dec 13 2018, 7:23 PM · VisualEditor, Parsoid