[Notifications] Add secondary actions for cells (swipe + swipe menu)
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	• Dmantena
	Aug 11 2021, 10:57 PM

Description

Add in secondary swipe actions and "More" action sheet actions for notification cells.

Show "More" and "Mark as Read" actions when left swiping a Notification cell in an LTR device language, right swiping in a RTL device language
Present action sheet with actions per notification type
Route user to destination when action sheet button tapped

Designs

Mappings

Link mappings for notification cells: https://docs.google.com/spreadsheets/d/1q4uI3mrz7CnKJsJ1srGXJVgWIhXmvs9dYH7u-6H29Us/edit#gid=0 (Notifications Settings should appear at the bottom)

Design details

Please note that not all cell types have associated secondary links. See the above spreadsheet and mocks for specifics.

Dependencies

https://phabricator.wikimedia.org/T287298
https://phabricator.wikimedia.org/T288662

Related Objects
Search...

Status	Assigned	Task
Open	None	T278838 Mobile user communication issues ([[Wikipedia:Mobile communication bugs]])
Resolved	• JMinor	T274404 Support notifications on the iOS app
Resolved	• JMinor	T287308 Notification Center UI
Resolved	• Dmantena	T288687 [Notifications] Add secondary actions for cells (swipe + swipe menu)

Event Timeline

• Dmantena created this task.Aug 11 2021, 10:57 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptAug 11 2021, 10:57 PM

• Dmantena triaged this task as Medium priority.Aug 11 2021, 11:51 PM

• Dmantena moved this task from Tasks from Product Backlog to Needs Design on the iOS-app-v6.9-Carp-On-A-Zamboni board.

@Dmantena is this spreadsheet sufficient for mapping? https://docs.google.com/spreadsheets/d/1RSDY7ZZ4nOzUUOnZtJvLBJ1bDjrxP5gL_22dit38LDM/edit?usp=sharing

LGoto moved this task from Needs Triage to Product Backlog on the Wikipedia-iOS-App-Backlog board.Aug 16 2021, 6:48 PM

@cmadeo See https://phabricator.wikimedia.org/T288670#7287048

@Dmantena please see this spread sheet: https://docs.google.com/spreadsheets/d/10Gkjd6GWFNDXzPnZhDJ2NvPqNvqoTTCFHMnSUtf3ex8/edit?usp=sharing

Additionally here are the touch targets for alerts:

Screen Shot 2021-08-17 at 2.16.36 PM.png (486×1 px, 80 KB)

cmadeo moved this task from Needs Design to Needs Acceptance Criteria on the iOS-app-v6.9-Carp-On-A-Zamboni board.Aug 17 2021, 6:17 PM

LGoto moved this task from Needs Acceptance Criteria to Needs Engineering Sync on the iOS-app-v6.9-Carp-On-A-Zamboni board.Aug 17 2021, 6:46 PM

Tsevener moved this task from Needs Engineering Sync to Blocked or Waiting on the iOS-app-v6.9-Carp-On-A-Zamboni board.Aug 24 2021, 7:28 PM

Blocked on other engineering work that needs to happen first.

cmadeo updated the task description. (Show Details)Sep 3 2021, 6:25 PM

Tsevener mentioned this in T272499: As someone with notifications turned on, I want notifications to lead me to somewhere that is actionable / appropriate.Sep 10 2021, 2:26 PM

Tsevener updated the task description. (Show Details)Sep 10 2021, 2:39 PM

Tsevener mentioned this in T287033: "Default" notification handling on iOS .Sep 10 2021, 2:47 PM

Tsevener moved this task from Blocked or Waiting to Ready for Development on the iOS-app-v6.9-Carp-On-A-Zamboni board.Sep 10 2021, 4:12 PM

Tsevener updated the task description. (Show Details)Sep 10 2021, 6:40 PM

• Dmantena claimed this task.Sep 24 2021, 8:42 PM

• Dmantena moved this task from Ready for Development to Doing on the iOS-app-v6.9-Carp-On-A-Zamboni board.

• Dmantena removed • Dmantena as the assignee of this task.Oct 19 2021, 6:20 PM

• Dmantena moved this task from Doing to Ready for Development on the iOS-app-v6.9-Carp-On-A-Zamboni board.

• Dmantena claimed this task.Oct 21 2021, 10:10 PM

• Dmantena moved this task from Ready for Development to Doing on the iOS-app-v6.9-Carp-On-A-Zamboni board.

https://github.com/wikimedia/wikipedia-ios/pull/4066 (data and routing portion, mark as read and notifications settings routing to come in a followup PR)

Tsevener mentioned this in T293944: Notifications - Early testing notes for QA.Oct 28 2021, 11:35 PM

• Dmantena updated the task description. (Show Details)Dec 10 2021, 5:00 PM

• Dmantena moved this task from Doing to Needs Code Review on the iOS-app-v6.9-Carp-On-A-Zamboni board.Dec 10 2021, 8:40 PM

https://github.com/wikimedia/wikipedia-ios/pull/4085 (swipe portion)

Tsevener moved this task from Needs Code Review to Needs Design Review on the iOS-app-v6.9-Carp-On-A-Zamboni board.Dec 20 2021, 11:41 PM

cmadeo renamed this task from [Notifications] Add secondary actions for cells to [Notifications] Add secondary actions for cells (swipe + swipe menu) .Jan 31 2022, 9:06 PM

cmadeo updated the task description. (Show Details)

cmadeo moved this task from Needs Design Review to Needs QA on the iOS-app-v6.9-Carp-On-A-Zamboni board.

Looks good to me on 6.9.0 (1882)

@Tsevener + @Dmantena I'm sorry I didn't catch this earlier, but I noticed today that the swipe menu on Notifications has a different animate in than our swipe menus on History, Reading lists, etc (which more closely match standard iOS components).

In Notifications it looks like the notification cell is 'moving to the left' to expose a static presentation of the menu below, in more standard components like in Reading lists or in the default messaging app, the swipe menu expands as the cell is swiped.

Would it be okay to re-open this ticket? And if so do you need any additional resources from design?

@cmadeo

Sorry for the delay on this! We decided to rewrite this functionality for the Notifications Center view. With the old method (that our other list screens use), it felt like we would be inheriting a lot of baggage for a screen that really didn't need to be complicated, and probably ultimately wouldn't have saved us much (if any) time due to tiptoeing around it's complexity. This rewrite felt like a more maintainable direction. But unfortunately I didn't catch that this accordion effect was lost because of this - sorry about that.

I talked it over with @Dmantena, and we have a few options, but none are quick fixes. I'm happy to discuss these options in planning tomorrow, but for now we suggest holding off on this until we're feature complete and are at a polish stage.

Sounds good! Thanks for the update @Tsevener, would love to keep track of this for later :)

@cmadeo thanks! I added a new task to track this in https://phabricator.wikimedia.org/T303299.

Tsevener mentioned this in T303299: Notifications - restore accordion effect for swipe actions.Mar 8 2022, 5:19 PM

Thanks @Toni Sevener <tsevener@wikimedia.org> !

• Dmantena claimed this task.Apr 20 2022, 4:30 PM

• Dmantena moved this task from Ready for PM Signoff to Doing on the iOS-app-v6.9-Carp-On-A-Zamboni board.

• Dmantena updated the task description. (Show Details)Apr 20 2022, 4:46 PM

PR that updates swipe action order: https://github.com/wikimedia/wikipedia-ios/pull/4197

Tsevener moved this task from Needs Code Review to Ready for PM Signoff on the iOS-app-v6.9-Carp-On-A-Zamboni board.Apr 25 2022, 6:22 PM

Those of us who live by the swipe-to-triage method of iOS inbox management thank you deeply.

	F34598511: Screen Shot 2021-08-17 at 2.16.36 PM.png
	Aug 17 2021, 6:17 PM

	F34938561: image.png
	Jan 31 2022, 9:06 PM

	F34631173: Frame 3.png
	Sep 3 2021, 6:25 PM

[Notifications] Add secondary actions for cells (swipe + swipe menu) Closed, ResolvedPublicActions