Page MenuHomePhabricator

https://gerrit.wikimedia.org/r/#/c/355636/12
OpenPublic

Authored By
bmansurov, Jul 6 2017
Tags
None
Referenced Files
F8633371: Screenshot from 2017-07-06 11-59-02.png
Jul 6 2017, 4:00 PM
F8633368: Screenshot from 2017-07-06 11-58-30.png
Jul 6 2017, 4:00 PM
F8633308: Screenshot from 2017-07-06 11-36-02.png
Jul 6 2017, 3:36 PM
F8633303: Screenshot from 2017-07-06 11-34-39.png
Jul 6 2017, 3:35 PM
F8633276: Screenshot from 2017-07-06 11-30-06.png
Jul 6 2017, 3:30 PM
F8633239: Screenshot from 2017-07-06 11-24-16.png
Jul 6 2017, 3:28 PM
F8633237: Screenshot from 2017-07-06 11-24-30.png
Jul 6 2017, 3:28 PM
F8633249: Screenshot from 2017-07-06 11-27-50.png
Jul 6 2017, 3:28 PM

Mock History

Current Revision

Mock Description

regressions

Before:

Screenshot from 2017-07-06 11-24-30.png (517×1 px, 90 KB)

After:

Screenshot from 2017-07-06 11-24-16.png (515×1 px, 90 KB)

Event Timeline

This is how 4 articles are being shown:

Screenshot from 2017-07-06 11-30-06.png (709×1 px, 94 KB)

@Nirzar is this fine?

Regression in Monobook

Before:

Screenshot from 2017-07-06 11-58-30.png (529×1 px, 42 KB)

After:

Screenshot from 2017-07-06 11-59-02.png (534×1 px, 50 KB)

None of these screens are fine. They clearly don't match the mocks and we don't need nirzar to see that.

Are you sure you pulled from latest master?

Which browser? What screen resolution?

Also we don't support monobook.

It should follow the grid. the tile size should not change. mock in the original ticket

and yeah, if it's only in monobook.. that's fine... in vector it should follow the grid.

Also we don't support monobook.

We don't? I saw something related to monobook in https://gerrit.wikimedia.org/r/#/c/355636/12/extension.json.

and yeah, if it's only in monobook.. that's fine... in vector it should follow the grid.

It's not only monobook. The last problem is, others are minerva.

Are you sure you pulled from latest master?

I pulled the patch https://gerrit.wikimedia.org/r/#/c/355636/12

Which browser? What screen resolution?

Chromium Version 59.0.3071.104 (Developer Build) Fedora Project (64-bit)
1920x1080