Page MenuHomePhabricator

License picker is broken in installer (stylesheet not allowed by CreativeCommons HTTPS)
Closed, ResolvedPublic

Description

The "https://creativecommons.org/choose/" iframe is hardcoded as HTTPS. This becomes a problem when a user is installer MediaWiki on an HTTP server.

Urls like https://creativecommons.org/choose/?partner=MediaWiki&exit_url=http%3A%2F%2F...&stylesheet=http%3A%2F%2Fmediawiki.dev%2Fw%2Fmw-config%2Fconfig-cc.css

Results in the following in Chrome 45:

Mixed Content: The page at 'https://creativecommons.org/choose/?partner=MediaWiki&exit_url=http%3A%2F%2…t=http%3A%2F%2Fmediawiki%2Fw%2Fmw-config%2Fconfig-cc.css' was loaded over HTTPS, but requested an insecure stylesheet 'http://mediawiki.dev/w/mw-config/config-cc.css'. This request has been blocked; the content must be served over HTTPS.

We should load creativecommons over HTTP instead of HTTPS. Most likely by using a protocol relative url.

Event Timeline

Krinkle raised the priority of this task from to Unbreak Now!.
Krinkle updated the task description. (Show Details)
Krinkle added subscribers: demon, Krinkle, Aklapper.

Change 213222 had a related patch set uploaded (by Chad):
Installer: use proto-relative URLs for license picker

https://gerrit.wikimedia.org/r/213222

Change 213222 merged by jenkins-bot:
Installer: use proto-relative URLs for license picker

https://gerrit.wikimedia.org/r/213222

Change 213226 had a related patch set uploaded (by Chad):
Installer: use proto-relative URLs for license picker

https://gerrit.wikimedia.org/r/213226

Change 213226 merged by jenkins-bot:
Installer: use proto-relative URLs for license picker

https://gerrit.wikimedia.org/r/213226

demon claimed this task.

WMF-deploy tag doesn't make much sense imho....