Page MenuHomePhabricator

Password reset function should error on blocked accounts if $wgBlockDisablesLogin
Open, MediumPublic

Description

On private wikis (where wgBlockDisablesLogin is enabled), blocked users should not receive password reset emails when requested for their username. If they cannot access the content, there's no need to send the password.

Similar task: T54453, though that is more of a blanket eradication of watchlist notifications for the same users.

Event Timeline

Rjd0060 raised the priority of this task from to Needs Triage.
Rjd0060 updated the task description. (Show Details)
Rjd0060 added subscribers: Rjd0060, Krenair, MZMcBride.
Krenair renamed this task from Password reset emails should not be sent to blocked accounts on private wikis to Password reset emails should not be sent to blocked accounts if $wgBlockDisablesLogin.EditedMay 27 2015, 9:30 PM
Krenair set Security to None.
Krenair added a subscriber: csteipp.

Hmmm. So we'd return an error saying that the account is blocked? It looks like we already expose account existence, so OK...
What are we going to do about email address-based password reset?

Krenair renamed this task from Password reset emails should not be sent to blocked accounts if $wgBlockDisablesLogin to Password reset function should error on blocked accounts if $wgBlockDisablesLogin.May 27 2015, 9:31 PM

Hmmm. So we'd return an error saying that the account is blocked? It looks like we already expose account existence, so OK...

We return the block information in the user query api, so we already make that public.

What are we going to do about email address-based password reset?

I think we should take blocked users off the list of users who email matches the reset request. If no unblocked accounts are still in the list, then the resetting user gets the standard response that no user accounts have that email.

Hmmm. So we'd return an error saying that the account is blocked? It looks like we already expose account existence, so OK...

We return the block information in the user query api, so we already make that public.

We expose the user query API on private wikis to logged out users? That's not what I was thinking of.

What are we going to do about email address-based password reset?

I think we should take blocked users off the list of users who email matches the reset request. If no unblocked accounts are still in the list, then the resetting user gets the standard response that no user accounts have that email.

I don't think we actually provide such an error? When I try resetting for completely nonsense email addresses (e.g. DoesNotActuallyExist@wikimedia.org), it pretends that it's sent an email.

What are we going to do about email address-based password reset?

I think we should take blocked users off the list of users who email matches the reset request. If no unblocked accounts are still in the list, then the resetting user gets the standard response that no user accounts have that email.

I don't think we actually provide such an error? When I try resetting for completely nonsense email addresses (e.g. DoesNotActuallyExist@wikimedia.org), it pretends that it's sent an email.

What's wrong with that? (My opinion is nothing - it also helps alleviate some of the other concern about being able to find out which accounts exist on the private wiki)