Pastes don't allow lua syntax highlighting
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	Bene
	May 30 2015, 4:49 PM

Description

While in tasks, syntaxhighlighting is supported for lua uing lang=lua this option is not available when creating a paste. Pastes should also allow syntaxhighlighting for lua as it becomes more and more important to show examples of how lua can be used on Wikipedias.

Details

	Subject	Repo	Branch	Lines +/-
	Add "Lua" to syntax highlighting dropdown choices in Phab's "Paste"	operations/puppet	production	+49 -0

Customize query in gerrit

Related Objects

Mentioned In: rOPUP62f3c28abcb4: Add "Lua" to syntax highlighting dropdown choices in Phab's "Paste"
rOPUP4e01c4b14913: Add "Lua" to syntax highlighting dropdown choices in Phab's "Paste"
E196: Code Review Office Hours
Mentioned Here: P3177 lua syntax highlight

Event Timeline

Bene created this task.May 30 2015, 4:49 PM

Bene raised the priority of this task from to Needs Triage.

Bene updated the task description. (Show Details)

Bene added a project: Phabricator.

Bene subscribed.

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMay 30 2015, 4:49 PM

Aklapper triaged this task as Lowest priority.May 31 2015, 1:12 PM

Aklapper edited projects, added Phabricator (Upstream); removed Phabricator.

Aklapper set Security to None.

Qgil moved this task from Backlog to Ready To Go on the Phabricator (Upstream) board.Jun 1 2015, 7:52 PM

This is configurable in pygments.dropdown-choices.

Naming a file something.lua and leaving "Language" set to "Detect Automatically" should also engage the Lua highlighter.

• Lemondoge subscribed.Mar 8 2016, 10:13 PM

Danny_B added a project: Upstream.May 23 2016, 6:01 PM

Restricted Application added a subscriber: TerraCodes. · View Herald TranscriptMay 23 2016, 6:01 PM

Change 290409 had a related patch set uploaded (by Aklapper):
Add "Lua" to syntax highlighting dropdown choices in Phab's "Paste"

https://gerrit.wikimedia.org/r/290409

gerritbot added a project: Patch-For-Review.May 24 2016, 8:57 AM

(Assuming as per previous comment that Lua is not wanted as a default choice in upstream, I've prepared a downstream configuration patch, for the lulz.)

Danny_B mentioned this in E196: Code Review Office Hours.May 25 2016, 11:20 AM

Change 290409 merged by Dzahn:
Add "Lua" to syntax highlighting dropdown choices in Phab's "Paste"

https://gerrit.wikimedia.org/r/290409

• mmodell mentioned this in rOPUP4e01c4b14913: Add "Lua" to syntax highlighting dropdown choices in Phab's "Paste".May 25 2016, 6:21 PM

Lua is now an option in the dropdown

Here's a paste with Lua code and highlighting:

P3177 lua syntax highlight

1	print("Hello World")
2
3
4	-- defines a factorial function
5	function fact (n)
6	if n == 0 then
7	return 1
8	else
9	return n * fact(n-1)
10	end
11	end
12
13	print("enter a number:")
14	a = io.read("*number") -- read a number
15	print(fact(a))
16

Dzahn closed this task as Resolved.May 25 2016, 6:28 PM

Dzahn claimed this task.

Dzahn removed a project: Patch-For-Review.

Thanks @Aklapper and @Dzahn

Diffusion mentioned this in rOPUP62f3c28abcb4: Add "Lua" to syntax highlighting dropdown choices in Phab's "Paste".Jun 17 2016, 6:08 PM

Pastes don't allow lua syntax highlightingClosed, ResolvedPublicActions

Description

Details

Related Objects

Event Timeline

Pastes don't allow lua syntax highlighting
Closed, ResolvedPublic
Actions