Page MenuHomePhabricator

Edit conflict not detected (3 involved persons)
Closed, DuplicatePublic

Description

Edit conflict not detected in following case

  • User A starts editing section
  • User B starts editing another section on same page
  • Bot C edit page
  • User A clicks 'save' -> edit conflict (with Bot-edit) detected -> User A starts solving conflict on page
  • User B clicks 'save' -> edit conflict (with Bot-edit) detected -> User B starts solving conflict on page
  • User A saves page -> all right
  • User B saves page -> edit conflict with user A not detected -> changes of user A reverted without hint

Could be a general problem in case of 3 involved persons, but case above is what happend.

If not allready happend, maybe include version-ID of conflict-edit in save operation (on edit conflict page) to prevent this.

Details

Related Gerrit Patches:
mediawiki/core : masterTest for T100912

Event Timeline

FeddaHeiko raised the priority of this task from to Needs Triage.
FeddaHeiko updated the task description. (Show Details)
FeddaHeiko added a subscriber: FeddaHeiko.
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMay 31 2015, 12:12 AM

So what you're saying is, when we have the user resolve an edit conflict, we don't account for a further separate conflict?

FeddaHeiko added a comment.EditedMay 31 2015, 3:59 AM

thats what i suppose - but im not sure about it

Change 266772 had a related patch set uploaded (by Addshore):
Test for T100912

https://gerrit.wikimedia.org/r/266772

Restricted Application added a subscriber: StudiesWorld. · View Herald TranscriptJan 29 2016, 1:16 PM

Change 266772 abandoned by Addshore:
Test for T100912

https://gerrit.wikimedia.org/r/266772