Page MenuHomePhabricator

Edit conflict not detected (3 involved persons)
Closed, DuplicatePublic

Description

Edit conflict not detected in following case

  • User A starts editing section
  • User B starts editing another section on same page
  • Bot C edit page
  • User A clicks 'save' -> edit conflict (with Bot-edit) detected -> User A starts solving conflict on page
  • User B clicks 'save' -> edit conflict (with Bot-edit) detected -> User B starts solving conflict on page
  • User A saves page -> all right
  • User B saves page -> edit conflict with user A not detected -> changes of user A reverted without hint

Could be a general problem in case of 3 involved persons, but case above is what happend.

If not allready happend, maybe include version-ID of conflict-edit in save operation (on edit conflict page) to prevent this.

Event Timeline

FeddaHeiko raised the priority of this task from to Needs Triage.
FeddaHeiko updated the task description. (Show Details)
FeddaHeiko subscribed.

So what you're saying is, when we have the user resolve an edit conflict, we don't account for a further separate conflict?

thats what i suppose - but im not sure about it

Change 266772 had a related patch set uploaded (by Addshore):
Test for T100912

https://gerrit.wikimedia.org/r/266772