imageinfo should return info for other files when one file gets a iiurlparamnormal error.
Open, LowPublic
Actions

Assigned To

None

Authored By

	Ragesoss
	Jun 4 2015, 10:50 PM

Description

I've been working on a tool that uses the imageinfo API to get thumbnail urls and their heights for all the files contributed by a set of users. I query a batch of files, but one file that hits the iiurlparamnormal error ruins a whole query.

For example:

https://commons.wikimedia.org/w/api.php?action=query&titles=File:Jewish_Encyclopedia_Volume_6.pdf|File:Example.jpg&prop=imageinfo&iilimit=50&iiend=2007-12-31T23:59:59Z&iiprop=timestamp|user|url&iiurlheight

It would be nice if this query still returned the data for the file that doesn't hit the iiurlparamnormal error and just returned the error info inside that item for that file. Even better would be if it still returned other requested data for the file, and simply left out the height value that can't be calcuated.

Slightly better than the status quo would be if the error message included the pageid and not just the file name.

Related Objects
Search...

Status	Subtype	Assigned	Task
Open		None	T101457 imageinfo should return info for other files when one file gets a iiurlparamnormal error.
Open		None	T89971 ApiQueryImageInfo is crufty, needs rewrite
Open		None	T132947 Make it possible for extensions to add additional info to the fileinfo/imageinfo response.
Declined		None	T134641 Make TextHandler use the timedtext videoinfo api for remoteDB sources
Invalid		None	T187759 API is returning 500 status code
Open		None	T201205 Bad metadata for a single file errors out the complete imageinfo prop request
Invalid		None	T235011 API query times out
Open	BUG REPORT	None	T311633 Unable to get imageinfo only for the latest revision
Open		None	T67251 Query-continue for imageinfo returns timestamp which is ambiguous if multiple files were uploaded within the same second under the same file name
Open		None	T67264 File storage uses (title,timestamp) as a unique key, but this is not unique
Open		Ladsgroup	T28741 Migrate file tables to a modern layout (image/oldimage; file/filerevision; add primary keys)
Resolved		Krinkle	T589 RFC: image and oldimage tables
Resolved		Ladsgroup	T368113 Design and merge the new tables of file tables
Resolved		mforns	T389800 Update Commons Impact Metrics to account for new File table
Resolved		Ladsgroup	T383093 Set beta cluster to write both in file schema and thoroughly test it
Resolved		Ladsgroup	T383491 Deploy new file tables in production
Resolved		Ladsgroup	T383492 Write the migration script
Resolved		• Zabe	T383496 Add support for reading new file schema into MediaWiki
Resolved		Dreamy_Jazz	T383555 Add support for reading new file schema in MediaModeration
Resolved		Ladsgroup	T384481 Set new file tables to write both in production
Resolved		Ladsgroup	T385167 Run data migration script for file migration
Duplicate		None	T386133 Update Data Pipelines with new image table schema
Resolved		• Zabe	T412164 Set beta cluster to read new in file schema and thoroughly test it
Open		Ladsgroup	T415330 Add support for stop writing to the old file db schema
Open		• Zabe	T416548 Start reading from file table on wmf production
Open	PRODUCTION ERROR	None	T418007 Wikimedia\Rdbms\DBQueryError: Error 1062: Duplicate entry 'Savannah_River_(26769689014).jpg' for key 'file_name'Function: MediaWiki\FileRepo\File\LocalFile::acquireFileIdFromNameQuery: INSERT INTO `file` (file_name,file_lates
Resolved	PRODUCTION ERROR	• Zabe	T418327 PHP Deprecated: Caller from MediaWiki\Exception\MWExceptionHandler::rollbackPrimaryChanges ignored an error originally raised from MediaWiki\Pager\IndexPager::buildQueryInfo (MediaWiki\Specials\Pager\ImageListPager): [1054] Unk
Resolved	PRODUCTION ERROR	• Zabe	T419062 Wikimedia\Rdbms\DBQueryError: Error 1054: Unknown column 'img_timestamp' in 'WHERE'Function: MediaWiki\Pager\IndexPager::buildQueryInfo (MediaWiki\Specials\Pager\NewFilesPager)Query: SELECT /! STRAIGHT_JOIN / file_name AS
Resolved	PRODUCTION ERROR	• Zabe	T422946 Expectation (readQueryTime <= 5) by MediaWiki\Actions\ActionEntryPoint::execute not met (actual: {actualSeconds}) in trx #{trxId}:{query}
Resolved	Security	• Zabe	T423654 Expectation (readQueryTime <= 5) by MediaWiki\Actions\ActionEntryPoint::execute not met (actual: {actualSeconds}) in trx #{trxId}:{query}
Resolved	BUG REPORT	Ladsgroup	T423978 Special:Mediastatistics is being weird and not grouping similar file types together
Open		• Zabe	T425191 Drop old image tables from wikireplicas

Event Timeline

Ragesoss created this task.Jun 4 2015, 10:50 PM

Ragesoss raised the priority of this task from to Needs Triage.

Ragesoss updated the task description. (Show Details)

Ragesoss added a project: MediaWiki-Action-API.

Ragesoss subscribed.

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJun 4 2015, 10:50 PM

Anomie added a subtask: T89971: ApiQueryImageInfo is crufty, needs rewrite.Jun 5 2015, 2:13 PM

Anomie moved this task from Unsorted to Needs Code on the MediaWiki-Action-API board.

Aklapper triaged this task as Low priority.Jul 17 2015, 1:05 PM

I'll note that this URL doesn't seem to produce any errors now.

{
    "batchcomplete": "",
    "query": {
        "normalized": [
            {
                "from": "File:Jewish_Encyclopedia_Volume_6.pdf",
                "to": "File:Jewish Encyclopedia Volume 6.pdf"
            }
        ],
        "pages": {
            "6428847": {
                "pageid": 6428847,
                "ns": 6,
                "title": "File:Example.jpg",
                "imagerepository": "local",
                "imageinfo": [
                    {
                        "timestamp": "2010-03-14T17:20:20Z",
                        "user": "Bdk",
                        "thumburl": "https://upload.wikimedia.org/wikipedia/commons/thumb/a/a9/Example.jpg/1px-Example.jpg",
                        "thumbwidth": 1,
                        "thumbheight": 0,
                        "url": "https://upload.wikimedia.org/wikipedia/commons/a/a9/Example.jpg",
                        "descriptionurl": "https://commons.wikimedia.org/wiki/File:Example.jpg",
                        "descriptionshorturl": "https://commons.wikimedia.org/w/index.php?curid=6428847"
                    }
                ]
            },
            "28591020": {
                "pageid": 28591020,
                "ns": 6,
                "title": "File:Jewish Encyclopedia Volume 6.pdf",
                "imagerepository": "local",
                "imageinfo": [
                    {
                        "timestamp": "2016-02-25T13:26:10Z",
                        "user": "Skim",
                        "thumburl": "https://upload.wikimedia.org/wikipedia/commons/thumb/9/97/Jewish_Encyclopedia_Volume_6.pdf/page1-1px-Jewish_Encyclopedia_Volume_6.pdf.jpg",
                        "thumbwidth": 1,
                        "thumbheight": 0,
                        "url": "https://upload.wikimedia.org/wikipedia/commons/9/97/Jewish_Encyclopedia_Volume_6.pdf",
                        "descriptionurl": "https://commons.wikimedia.org/wiki/File:Jewish_Encyclopedia_Volume_6.pdf",
                        "descriptionshorturl": "https://commons.wikimedia.org/w/index.php?curid=28591020"
                    },
                    {
                        "timestamp": "2013-09-26T16:23:46Z",
                        "user": "John Carter",
                        "thumburl": "https://commons.wikimedia.org/w/resources/assets/file-type-icons/fileicon-pdf.png",
                        "thumbwidth": 120,
                        "thumbheight": 120,
                        "url": "https://upload.wikimedia.org/wikipedia/commons/archive/9/97/20160225132600%21Jewish_Encyclopedia_Volume_6.pdf",
                        "descriptionurl": "https://commons.wikimedia.org/wiki/File:Jewish_Encyclopedia_Volume_6.pdf",
                        "descriptionshorturl": "https://commons.wikimedia.org/w/index.php?curid=28591020"
                    }
                ]
            }
        }
    }
}

Pppery added a project: MediaWiki-File-management.Dec 26 2024, 7:11 PM

Maintenance_bot added a project: Commons.Dec 26 2024, 7:30 PM

imageinfo should return info for other files when one file gets a iiurlparamnormal error.Open, LowPublicActions

Description

Related ObjectsSearch...

Event Timeline

imageinfo should return info for other files when one file gets a iiurlparamnormal error.
Open, LowPublic
Actions

Related Objects
Search...