Page MenuHomePhabricator
Create Task
Maniphest T101564

Forms seem to be fitting to size of security text instead of what we had before
Closed, ResolvedPublic1 Estimated Story Points
Actions

Description

Maybe during mustache forms or refactor in March? but the grey GC box is fitting to width of the card security text, which is awkward in some languages. Text should wrap.

Screen Shot 2015-06-05 at 11.45.47 PM.png (900×1 px, 303 KB)

Screen Shot 2015-06-05 at 11.47.15 PM.png (900×1 px, 285 KB)

Details

SubjectRepoBranchLines +/-
Allow text in the payment table to wrapmediawiki/extensions/DonationInterfacedeployment+0 -4
Allow text in the payment table to wrapmediawiki/extensions/DonationInterfacemaster+0 -4
Customize query in gerrit

Related Objects

Event Timeline

• atgo created this task.Jun 5 2015, 9:47 PM
• atgo raised the priority of this task from to Medium.
• atgo updated the task description. (Show Details)
• atgo added projects: Fundraising Sprint Miles Davis, Fundraising-Backlog.
• atgo added subscribers: • atgo, • jrobell, MeganHernandez_WMF.
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJun 5 2015, 9:47 PM
• atgo moved this task from Triage to Closed Sprint Work Q4 1415 on the Fundraising-Backlog board.Jun 9 2015, 6:18 PM
• atgo added a project: [DO NOT USE] Astropay [superseded by #FR-Astropay].Jun 10 2015, 11:07 PM
• atgo set Security to None.
• atgo edited a custom field.
• atgo moved this task from Closed Sprint Work Q4 1415 to Sprint +1 on the Fundraising-Backlog board.Jun 12 2015, 5:20 PM
• atgo moved this task from Sprint +1 to Closed Sprint Work Q4 1415 on the Fundraising-Backlog board.Jun 12 2015, 5:35 PM
• atgo moved this task from Closed Sprint Work Q4 1415 to Closed Sprint Work Q1 1516 on the Fundraising-Backlog board.Jun 12 2015, 9:21 PM
• atgo moved this task from Backlog to Required for donor testing on the [DO NOT USE] Astropay [superseded by #FR-Astropay] board.Jun 16 2015, 8:30 PM
Ejegg claimed this task.Jun 17 2015, 9:34 PM
Ejegg moved this task from Backlog to Doing on the Fundraising Sprint Miles Davis board.
gerritbot subscribed.Jun 17 2015, 10:08 PM

Change 219051 had a related patch set uploaded (by Ejegg):
Allow text in the payment table to wrap

https://gerrit.wikimedia.org/r/219051

gerritbot added a project: Patch-For-Review.Jun 17 2015, 10:08 PM
Ejegg moved this task from Doing to Review on the Fundraising Sprint Miles Davis board.Jun 17 2015, 10:11 PM
gerritbot added a comment.Jun 18 2015, 12:16 AM

Change 219051 merged by jenkins-bot:
Allow text in the payment table to wrap

https://gerrit.wikimedia.org/r/219051

Ejegg mentioned this in rMEXTaf43f1eae030: Updated mediawiki/extensions Project: mediawiki/extensions/DonationInterface….Jun 18 2015, 12:17 AM
Ejegg mentioned this in rEDOI8b478fa35b63: Allow text in the payment table to wrap.
gerritbot added a comment.Jun 18 2015, 1:21 AM

Change 219117 had a related patch set uploaded (by Ejegg):
Allow text in the payment table to wrap

https://gerrit.wikimedia.org/r/219117

gerritbot added a comment.Jun 18 2015, 1:23 AM

Change 219117 merged by Ejegg:
Allow text in the payment table to wrap

https://gerrit.wikimedia.org/r/219117

Ejegg mentioned this in rEDOI4793a7b6c463: Allow text in the payment table to wrap.Jun 18 2015, 1:23 AM
Ejegg moved this task from Review to Done on the Fundraising Sprint Miles Davis board.Jun 18 2015, 1:49 AM
Ejegg added a comment.Jun 18 2015, 1:53 AM

Just deployed a CSS change to let the text wrap. That helps a lot, but the grey box is still a bit wider in language=ru than in language=en.

• atgo closed this task as Resolved.Jun 18 2015, 9:08 PM

Thanks @Ejegg. I think this looks good, but we still have some issues with the astropay form looking a bit strange. I'll follow up in the other task

• jrobell added a comment.Jun 22 2015, 5:45 PM

Thanks @Ejegg and @atgo for fixing this!

• DStrine moved this task from Closed Sprint Work Q1 1516 to Closed Sprint Work Q3 1415 on the Fundraising-Backlog board.Jun 25 2015, 4:30 PM
• atgo moved this task from Closed Sprint Work Q3 1415 to Closed Sprint Work Q4 1415 on the Fundraising-Backlog board.Jun 30 2015, 10:28 PM
• atgo moved this task from Required for donor testing to Done on the [DO NOT USE] Astropay [superseded by #FR-Astropay] board.Jul 7 2015, 4:24 PM
• DStrine added a project: FR-dlocal.Dec 14 2015, 7:15 PM
• atgo unsubscribed.Mar 30 2016, 10:13 PM
• Phabricator_maintenance removed a project: [DO NOT USE] Astropay [superseded by #FR-Astropay].Aug 10 2016, 11:47 PM
• DStrine edited projects, added Fr-tech-archived-from-FY-2014/15; removed Fundraising-Backlog.Jan 11 2018, 9:35 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL